nosu
/
taskana
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

TSK-1498: Created specific error message if workbasket already exists (#1399)

This commit is contained in:
tge20 2021-01-20 09:06:03 +01:00 committed by GitHub
parent fbf615b2c5
commit 0994f14b3b
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 8 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
lib/taskana-core/src/main/java/pro/taskana/workbasket/api/exceptions/WorkbasketAlreadyExistException.java
View File

@ -8,12 +8,10 @@ public class WorkbasketAlreadyExistException extends TaskanaException {
public WorkbasketAlreadyExistException(Workbasket workbasket) { public WorkbasketAlreadyExistException(Workbasket workbasket) {
super( super(
"ID='" "A workbasket with key '"
+ workbasket.getId()
+ "', KEY=' "
+ workbasket.getKey() + workbasket.getKey()
+ "', DOMAIN='" + "' already exists in domain '"
+ workbasket.getDomain() + workbasket.getDomain()
+ "';"); + "'.");
} }
} }

2
lib/taskana-core/src/test/java/acceptance/task/CompleteTaskAccTest.java
View File

@ -192,7 +192,7 @@ class CompleteTaskAccTest extends AbstractAccTest {
assertThat(createdTask).isNotNull(); assertThat(createdTask).isNotNull();
assertThat(createdTask.getOwner()).isEqualTo("other_user"); assertThat(createdTask.getOwner()).isEqualTo("other_user");
Instant beforeForceClaim = Instant.now(); Instant beforeForceClaim = Instant.now().truncatedTo(ChronoUnit.MILLIS);
Task taskAfterClaim = TASK_SERVICE.forceClaim(createdTask.getId()); Task taskAfterClaim = TASK_SERVICE.forceClaim(createdTask.getId());
assertThat(taskAfterClaim.getOwner()) assertThat(taskAfterClaim.getOwner())

7
lib/taskana-core/src/test/java/acceptance/task/TransferTaskAccTest.java
View File

@ -6,6 +6,7 @@ import static org.assertj.core.api.Assertions.assertThatThrownBy;
import acceptance.AbstractAccTest; import acceptance.AbstractAccTest;
import java.time.Instant; import java.time.Instant;
import java.time.temporal.ChronoUnit;
import java.util.ArrayList; import java.util.ArrayList;
import java.util.Arrays; import java.util.Arrays;
import java.util.List; import java.util.List;
@ -197,7 +198,7 @@ class TransferTaskAccTest extends AbstractAccTest {
@WithAccessId(user = "teamlead-1", groups = GROUP_1_DN) @WithAccessId(user = "teamlead-1", groups = GROUP_1_DN)
@Test @Test
void should_BulkTransferTasks_When_WorkbasketIdIsProvided() throws Exception { void should_BulkTransferTasks_When_WorkbasketIdIsProvided() throws Exception {
final Instant before = Instant.now(); final Instant before = Instant.now().truncatedTo(ChronoUnit.MILLIS);
TaskService taskService = taskanaEngine.getTaskService(); TaskService taskService = taskanaEngine.getTaskService();
ArrayList<String> taskIdList = new ArrayList<>(); ArrayList<String> taskIdList = new ArrayList<>();
taskIdList.add("TKI:000000000000000000000000000000000004"); taskIdList.add("TKI:000000000000000000000000000000000004");
@ -236,7 +237,7 @@ class TransferTaskAccTest extends AbstractAccTest {
TaskService taskService = taskanaEngine.getTaskService(); TaskService taskService = taskanaEngine.getTaskService();
final Workbasket wb = final Workbasket wb =
taskanaEngine.getWorkbasketService().getWorkbasket("USER-1-1", "DOMAIN_A"); taskanaEngine.getWorkbasketService().getWorkbasket("USER-1-1", "DOMAIN_A");
final Instant before = Instant.now(); final Instant before = Instant.now().truncatedTo(ChronoUnit.MILLIS);
ArrayList<String> taskIdList = new ArrayList<>(); ArrayList<String> taskIdList = new ArrayList<>();
taskIdList.add("TKI:000000000000000000000000000000000006"); // working taskIdList.add("TKI:000000000000000000000000000000000006"); // working
taskIdList.add("TKI:000000000000000000000000000000000041"); // NotAuthorized READ taskIdList.add("TKI:000000000000000000000000000000000041"); // NotAuthorized READ
@ -358,7 +359,7 @@ class TransferTaskAccTest extends AbstractAccTest {
@WithAccessId(user = "teamlead-1", groups = GROUP_1_DN) @WithAccessId(user = "teamlead-1", groups = GROUP_1_DN)
@Test @Test
void should_BulkTransferTasks_When_WorkbasketKeyAndDomainIsProvided() throws Exception { void should_BulkTransferTasks_When_WorkbasketKeyAndDomainIsProvided() throws Exception {
final Instant before = Instant.now(); final Instant before = Instant.now().truncatedTo(ChronoUnit.MILLIS);
TaskService taskService = taskanaEngine.getTaskService(); TaskService taskService = taskanaEngine.getTaskService();
List<String> taskIdList = new ArrayList<>(); List<String> taskIdList = new ArrayList<>();