From 1fe5aa7e723b11a7852b202a7d0256d305272bf6 Mon Sep 17 00:00:00 2001
From: Mustapha Zorgati <15628173+mustaphazorgati@users.noreply.github.com>
Date: Tue, 30 Mar 2021 16:21:35 +0200
Subject: [PATCH] TSK-1611: updated checkstyle to 8.41.1

---
 .../pro/taskana/common/api/exceptions/TaskanaException.java     | 2 +-
 .../common/internal/util/ObjectAttributeChangeDetector.java     | 2 +-
 .../java/pro/taskana/common/internal/TaskanaEngineImpl.java     | 1 +
 pom.xml                                                         | 2 +-
 4 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/common/taskana-common/src/main/java/pro/taskana/common/api/exceptions/TaskanaException.java b/common/taskana-common/src/main/java/pro/taskana/common/api/exceptions/TaskanaException.java
index 92a3b608b..28c7ef836 100644
--- a/common/taskana-common/src/main/java/pro/taskana/common/api/exceptions/TaskanaException.java
+++ b/common/taskana-common/src/main/java/pro/taskana/common/api/exceptions/TaskanaException.java
@@ -1,6 +1,6 @@
 package pro.taskana.common.api.exceptions;
 
-/** common base class for Taskana's checked exceptions. */
+/** common base class for TASKANA's checked exceptions. */
 public class TaskanaException extends Exception {
 
   public TaskanaException() {
diff --git a/common/taskana-common/src/main/java/pro/taskana/common/internal/util/ObjectAttributeChangeDetector.java b/common/taskana-common/src/main/java/pro/taskana/common/internal/util/ObjectAttributeChangeDetector.java
index d70a0a869..c9ac70f51 100644
--- a/common/taskana-common/src/main/java/pro/taskana/common/internal/util/ObjectAttributeChangeDetector.java
+++ b/common/taskana-common/src/main/java/pro/taskana/common/internal/util/ObjectAttributeChangeDetector.java
@@ -27,6 +27,7 @@ public class ObjectAttributeChangeDetector {
    * @param newObject the new object for the comparison
    * @param <T> The generic type parameter
    * @return the details of all changed fields as JSON string
+   * @throws SystemException when any parameter is null
    */
   public static <T> String determineChangesInAttributes(T oldObject, T newObject) {
     LOGGER.debug(
@@ -37,7 +38,6 @@ public class ObjectAttributeChangeDetector {
     List<Field> fields = new ArrayList<>();
 
     if (Objects.isNull(oldObject) || Objects.isNull(newObject)) {
-
       throw new SystemException(
           "Null was provided as a parameter. Please provide two objects of the same type");
     }
diff --git a/lib/taskana-core/src/main/java/pro/taskana/common/internal/TaskanaEngineImpl.java b/lib/taskana-core/src/main/java/pro/taskana/common/internal/TaskanaEngineImpl.java
index 51df23b44..b8fbc1207 100644
--- a/lib/taskana-core/src/main/java/pro/taskana/common/internal/TaskanaEngineImpl.java
+++ b/lib/taskana-core/src/main/java/pro/taskana/common/internal/TaskanaEngineImpl.java
@@ -257,6 +257,7 @@ public class TaskanaEngineImpl implements TaskanaEngine {
    * sets the databaseId attribute.
    *
    * @return a {@link SqlSessionFactory}
+   * @throws SystemException when a connection to the database could not be opened.
    */
   protected SqlSessionManager createSqlSessionManager() {
     Environment environment =
diff --git a/pom.xml b/pom.xml
index 82f3d440a..b694d2f7d 100644
--- a/pom.xml
+++ b/pom.xml
@@ -31,7 +31,7 @@
     <version.json>20210307</version.json>
 
     <!-- build dependencies -->
-    <version.checkstyle>8.41</version.checkstyle>
+    <version.checkstyle>8.41.1</version.checkstyle>
     <version.maven.checkstyle>3.1.2</version.maven.checkstyle>
     <version.maven.jar>3.2.0</version.maven.jar>
     <version.maven.compiler>3.8.1</version.maven.compiler>