nosu
/
taskana
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

TSK-1991: verify immutability for TaskanaConf Map<?, Collection<?>> 

and restructured TaskanaConfigurationTest for better readability / maintainability
This commit is contained in:
Mustapha Zorgati 2023-03-15 22:43:33 +01:00 committed by Alex
parent 3ebbb5da14
commit 2592a7f562
3 changed files with 987 additions and 818 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1795
lib/taskana-core-test/src/test/java/acceptance/TaskanaConfigurationTest.java
View File

File diff suppressed because it is too large Load Diff

6
lib/taskana-core-test/src/test/resources/fullTaskana.properties
View File

@ -4,7 +4,7 @@ taskana.servicelevel.validation.enforce=false
# authentication configuration
taskana.roles.user=user-1 | user-2
taskana.roles.admin=admin-1 | admin-2
taskana.roles.business_admin=businessadmin-1 | businessadmin-2
taskana.roles.business_admin=business_admin-1 | business_admin-2
taskana.roles.monitor=monitor-1 | monitor-2
taskana.roles.task_admin=taskadmin-1 | taskadmin-2
taskana.roles.task_router=taskrouter-1 | taskrouter-2
@ -54,5 +54,5 @@ taskana.jobs.customJobs=A | B | C
taskana.user.addAdditionalUserInfo=true
taskana.user.minimalPermissionsToAssignDomains=READ | OPEN
# custom configuration
mycustomproperty1=mycustomvalue1
mycustomproperty2=mycustomvalue2
my_custom_property1=my_custom_value1
my_custom_property2=my_custom_value2

4
lib/taskana-core/src/main/java/pro/taskana/TaskanaConfiguration.java
View File

@ -1128,7 +1128,7 @@ public class TaskanaConfiguration {
// endregion
public TaskanaConfiguration build() {
transformConfiguration();
adjustConfiguration();
validateConfiguration();
return new TaskanaConfiguration(this);
}
@ -1157,7 +1157,7 @@ public class TaskanaConfiguration {
}
}
private void transformConfiguration() {
private void adjustConfiguration() {
domains = domains.stream().map(String::toUpperCase).collect(Collectors.toSet());
classificationTypes =
classificationTypes.stream().map(String::toUpperCase).collect(Collectors.toSet());