nosu
/
taskana
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

TSK-1924: fix guideline violations, so ArchUnitTests are green

This commit is contained in:
Oliver Koch 2022-08-05 08:26:38 +02:00 committed by Mustapha Zorgati
parent 5c18cc9b4a
commit 2bc1c7ca01
3 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
.run/Run ArchitectureTest.run.xml
View File

@ -1,6 +1,6 @@
<component name="ProjectRunConfigurationManager"> <component name="ProjectRunConfigurationManager">
<configuration default="false" name="Run ArchitectureTest" type="JUnit" factoryName="JUnit" folderName="lib"> <configuration default="false" name="Run ArchitectureTest" type="JUnit" factoryName="JUnit" folderName="lib">
<module name="taskana-core" /> <module name="taskana-core-test" />
<extension name="coverage"> <extension name="coverage">
<pattern> <pattern>
<option name="PATTERN" value="pro.taskana.*" /> <option name="PATTERN" value="pro.taskana.*" />

4
lib/taskana-core-test/src/test/java/acceptance/classification/get/GetClassificationAccTest.java
View File

@ -66,7 +66,7 @@ class GetClassificationAccTest {
@WithAccessId(user = "user-1-1") @WithAccessId(user = "user-1-1")
@Test @Test
void should_getClassificationById_When_AllPropertiesSet() throws Exception { void should_GetClassificationById_When_AllPropertiesSet() throws Exception {
Classification classification = Classification classification =
classificationService.getClassification(classificationWithAllProperties.getId()); classificationService.getClassification(classificationWithAllProperties.getId());
@ -77,7 +77,7 @@ class GetClassificationAccTest {
@WithAccessId(user = "user-1-1") @WithAccessId(user = "user-1-1")
@Test @Test
void should_getClassificationByKeyAndDomain_When_AllPropertiesSet() throws Exception { void should_GetClassificationByKeyAndDomain_When_AllPropertiesSet() throws Exception {
Classification classification = Classification classification =
classificationService.getClassification( classificationService.getClassification(
classificationWithAllProperties.getKey(), classificationWithAllProperties.getDomain()); classificationWithAllProperties.getKey(), classificationWithAllProperties.getDomain());

4
lib/taskana-core-test/src/test/java/acceptance/task/requestchanges/RequestChangesAccTest.java
View File

@ -77,7 +77,7 @@ class RequestChangesAccTest {
@WithAccessId(user = "user-1-1") @WithAccessId(user = "user-1-1")
@Test @Test
void should_ForceRequestChanges_WhenTaskIsInReviewByDifferentUser() throws Exception { void should_ForceRequestChanges_When_TaskIsInReviewByDifferentUser() throws Exception {
Instant now = Instant.now(); Instant now = Instant.now();
Task task = createTaskInReviewByUser("user-1-2").buildAndStore(taskService); Task task = createTaskInReviewByUser("user-1-2").buildAndStore(taskService);
@ -90,7 +90,7 @@ class RequestChangesAccTest {
@WithAccessId(user = "user-1-1") @WithAccessId(user = "user-1-1")
@TestFactory @TestFactory
Stream<DynamicTest> should_ForceRequestChanges_WhenTaskIsNotInEndState() { Stream<DynamicTest> should_ForceRequestChanges_When_TaskIsNotInEndState() {
List<TaskState> testCases = Arrays.asList(EnumUtil.allValuesExceptFor(TaskState.END_STATES)); List<TaskState> testCases = Arrays.asList(EnumUtil.allValuesExceptFor(TaskState.END_STATES));
ThrowingConsumer<TaskState> test = ThrowingConsumer<TaskState> test =
state -> { state -> {