nosu
/
taskana
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

TSK-59 implement comments from holger - toLowerCase only for setters not for getters and change useContainerManagedTransactions to useManagedTransactions

This commit is contained in:
BerndBreier 2018-01-03 17:04:02 +01:00 committed by Marcel Lengl
parent f3f46e1ed5
commit 37bb8535a3
3 changed files with 8 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
lib/taskana-core/src/main/java/pro/taskana/configuration/TaskanaEngineConfiguration.java
View File

@ -34,14 +34,14 @@ public class TaskanaEngineConfiguration {
public TaskanaEngineConfiguration() { public TaskanaEngineConfiguration() {
} }
public TaskanaEngineConfiguration(DataSource dataSource, boolean useContainerManagedTransactions) public TaskanaEngineConfiguration(DataSource dataSource, boolean useManagedTransactions)
throws SQLException { throws SQLException {
this(dataSource, useContainerManagedTransactions, true); this(dataSource, useManagedTransactions, true);
} }
public TaskanaEngineConfiguration(DataSource dataSource, boolean useContainerManagedTransactions, public TaskanaEngineConfiguration(DataSource dataSource, boolean useManagedTransactions,
boolean securityEnabled) throws SQLException { boolean securityEnabled) throws SQLException {
this.useManagedTransactions = useContainerManagedTransactions; this.useManagedTransactions = useManagedTransactions;
if (dataSource != null) { if (dataSource != null) {
this.dataSource = dataSource; this.dataSource = dataSource;

6
lib/taskana-core/src/main/java/pro/taskana/impl/TaskanaEngineImpl.java
View File

@ -242,10 +242,10 @@ public class TaskanaEngineImpl implements TaskanaEngine {
/** /**
* creates the MyBatis transaction factory. * creates the MyBatis transaction factory.
* *
* @param useContainerManagedTransactions * @param useManagedTransactions
*/ */
private void createTransactionFactory(boolean useContainerManagedTransactions) { private void createTransactionFactory(boolean useManagedTransactions) {
if (useContainerManagedTransactions) { if (useManagedTransactions) {
this.transactionFactory = new ManagedTransactionFactory(); this.transactionFactory = new ManagedTransactionFactory();
} else { } else {
this.transactionFactory = new JdbcTransactionFactory(); this.transactionFactory = new JdbcTransactionFactory();

6
lib/taskana-core/src/main/java/pro/taskana/model/WorkbasketAccessItem.java
View File

@ -41,11 +41,7 @@ public class WorkbasketAccessItem {
} }
public String getAccessId() { public String getAccessId() {
if (TaskanaEngineConfiguration.shouldUseLowerCaseForAccessIds()) { return accessId;
return accessId != null ? accessId.toLowerCase() : null;
} else {
return accessId;
}
} }
public void setAccessId(String accessId) { public void setAccessId(String accessId) {