Closes #2521 - Fix code smells Stream.collect(Collectors.toList()) to Stream.toList()

This commit is contained in:
Maria Margaritis 2024-03-06 00:25:16 +01:00
parent 81f0745b56
commit 4b48c0d1fb
1 changed files with 4 additions and 7 deletions

View File

@ -2,7 +2,6 @@ package pro.taskana.task.rest.assembler;
import java.util.Collection; import java.util.Collection;
import java.util.List; import java.util.List;
import java.util.stream.Collectors;
import org.springframework.beans.factory.annotation.Autowired; import org.springframework.beans.factory.annotation.Autowired;
import org.springframework.lang.NonNull; import org.springframework.lang.NonNull;
import org.springframework.stereotype.Component; import org.springframework.stereotype.Component;
@ -79,14 +78,12 @@ public class TaskSummaryRepresentationModelAssembler
repModel.setSecondaryObjectReferences( repModel.setSecondaryObjectReferences(
taskSummary.getSecondaryObjectReferences().stream() taskSummary.getSecondaryObjectReferences().stream()
.map(objectReferenceAssembler::toModel) .map(objectReferenceAssembler::toModel)
.collect(Collectors.toList())); .toList());
repModel.setRead(taskSummary.isRead()); repModel.setRead(taskSummary.isRead());
repModel.setTransferred(taskSummary.isTransferred()); repModel.setTransferred(taskSummary.isTransferred());
repModel.setGroupByCount(taskSummary.getGroupByCount()); repModel.setGroupByCount(taskSummary.getGroupByCount());
repModel.setAttachmentSummaries( repModel.setAttachmentSummaries(
taskSummary.getAttachmentSummaries().stream() taskSummary.getAttachmentSummaries().stream().map(attachmentAssembler::toModel).toList());
.map(attachmentAssembler::toModel)
.collect(Collectors.toList()));
repModel.setCustom1(taskSummary.getCustomField(TaskCustomField.CUSTOM_1)); repModel.setCustom1(taskSummary.getCustomField(TaskCustomField.CUSTOM_1));
repModel.setCustom2(taskSummary.getCustomField(TaskCustomField.CUSTOM_2)); repModel.setCustom2(taskSummary.getCustomField(TaskCustomField.CUSTOM_2));
repModel.setCustom3(taskSummary.getCustomField(TaskCustomField.CUSTOM_3)); repModel.setCustom3(taskSummary.getCustomField(TaskCustomField.CUSTOM_3));
@ -146,14 +143,14 @@ public class TaskSummaryRepresentationModelAssembler
taskSummary.setSecondaryObjectReferences( taskSummary.setSecondaryObjectReferences(
repModel.getSecondaryObjectReferences().stream() repModel.getSecondaryObjectReferences().stream()
.map(objectReferenceAssembler::toEntity) .map(objectReferenceAssembler::toEntity)
.collect(Collectors.toList())); .toList());
taskSummary.setRead(repModel.isRead()); taskSummary.setRead(repModel.isRead());
taskSummary.setTransferred(repModel.isTransferred()); taskSummary.setTransferred(repModel.isTransferred());
taskSummary.setGroupByCount(repModel.getGroupByCount()); taskSummary.setGroupByCount(repModel.getGroupByCount());
taskSummary.setAttachmentSummaries( taskSummary.setAttachmentSummaries(
repModel.getAttachmentSummaries().stream() repModel.getAttachmentSummaries().stream()
.map(attachmentAssembler::toEntityModel) .map(attachmentAssembler::toEntityModel)
.collect(Collectors.toList())); .toList());
taskSummary.setCustom1(repModel.getCustom1()); taskSummary.setCustom1(repModel.getCustom1());
taskSummary.setCustom2(repModel.getCustom2()); taskSummary.setCustom2(repModel.getCustom2());
taskSummary.setCustom3(repModel.getCustom3()); taskSummary.setCustom3(repModel.getCustom3());