From 56fd4a77c20425f147d8fd5f46c22c6f263fc375 Mon Sep 17 00:00:00 2001 From: BerndBreier <33351391+BerndBreier@users.noreply.github.com> Date: Mon, 4 Nov 2019 14:13:35 +0100 Subject: [PATCH] TSK-943 remove setters from ClassificationSummary --- .../main/java/pro/taskana/Classification.java | 115 +----------------- .../pro/taskana/ClassificationSummary.java | 66 +--------- .../impl/ClassificationSummaryImpl.java | 8 -- 3 files changed, 2 insertions(+), 187 deletions(-) diff --git a/lib/taskana-core/src/main/java/pro/taskana/Classification.java b/lib/taskana-core/src/main/java/pro/taskana/Classification.java index 54c1931a1..e74847447 100644 --- a/lib/taskana-core/src/main/java/pro/taskana/Classification.java +++ b/lib/taskana-core/src/main/java/pro/taskana/Classification.java @@ -10,24 +10,7 @@ import pro.taskana.impl.ClassificationImpl; * Interface used to specify the Classification-Model. */ @JsonDeserialize(as = ClassificationImpl.class) -public interface Classification { - - /** - * @return unique classification ID - */ - String getId(); - - /** - * @return externally known key to the classification like a code or abbreviation. - */ - String getKey(); - - /** - * Used to get the ID of the parent classification. - * - * @return unique ID or null if parent itself. - */ - String getParentId(); +public interface Classification extends ClassificationSummary { /** * Set/Change a reference to the current parent classification via ID. EMPTY if there is no parent. @@ -37,13 +20,6 @@ public interface Classification { */ void setParentId(String parentId); - /** - * Used to get the key of the parent classification. - * - * @return key of the parent classification or null if there is no parent. - */ - String getParentKey(); - /** * Set/Change a reference to the current parent classification via key. EMPTY if there is no parent. * @@ -52,11 +28,6 @@ public interface Classification { */ void setParentKey(String parentKey); - /** - * @return category of this classification. - */ - String getCategory(); - /** * Set/Change the category of this classification. * @@ -65,13 +36,6 @@ public interface Classification { */ void setCategory(String category); - /** - * Get the type of the current classification. - * - * @return type - */ - String getType(); - /** * Get the current domain-name of this classification. * @@ -108,13 +72,6 @@ public interface Classification { */ Instant getModified(); - /** - * Get the classification name. - * - * @return name - */ - String getName(); - /** * Set/Change the classification name. * @@ -138,13 +95,6 @@ public interface Classification { */ void setDescription(String description); - /** - * Get the current classification priority (numeric). - * - * @return priority - */ - int getPriority(); - /** * Set/Change the numeric priority of a classification. * @@ -153,13 +103,6 @@ public interface Classification { */ void setPriority(int priority); - /** - * Get the current service level. - * - * @return serviceLevel - */ - String getServiceLevel(); - /** * Set/Change the service level. * @@ -184,13 +127,6 @@ public interface Classification { */ void setApplicationEntryPoint(String applicationEntryPoint); - /** - * Get the 1. custom-attribute. - * - * @return custom1 - */ - String getCustom1(); - /** * Set/Change the 1. custom-attribute. * @@ -199,13 +135,6 @@ public interface Classification { */ void setCustom1(String custom1); - /** - * Get the 2. custom-attribute. - * - * @return custom2 - */ - String getCustom2(); - /** * Set/Change the 2. custom-attribute. * @@ -214,13 +143,6 @@ public interface Classification { */ void setCustom2(String custom2); - /** - * Get the 3. custom-attribute. - * - * @return custom3 - */ - String getCustom3(); - /** * Set/Change the 3. custom-attribute. * @@ -229,13 +151,6 @@ public interface Classification { */ void setCustom3(String custom3); - /** - * Get the 4. custom-attribute. - * - * @return custom4 - */ - String getCustom4(); - /** * Set/Change the 4. custom-attribute. * @@ -244,13 +159,6 @@ public interface Classification { */ void setCustom4(String custom4); - /** - * Get the 5. custom-attribute. - * - * @return custom5 - */ - String getCustom5(); - /** * Set/Change the 5. custom-attribute. * @@ -259,13 +167,6 @@ public interface Classification { */ void setCustom5(String custom5); - /** - * Get the 6. custom-attribute. - * - * @return custom6 - */ - String getCustom6(); - /** * Set/Change the 6. custom-attribute. * @@ -274,13 +175,6 @@ public interface Classification { */ void setCustom6(String custom6); - /** - * Get the 7. custom-attribute. - * - * @return custom7 - */ - String getCustom7(); - /** * Set/Change the 7. custom-attribute. * @@ -289,13 +183,6 @@ public interface Classification { */ void setCustom7(String custom7); - /** - * Get the 8. custom-attribute. - * - * @return custom8 - */ - String getCustom8(); - /** * Set/Change the 8. custom-attribute. * diff --git a/lib/taskana-core/src/main/java/pro/taskana/ClassificationSummary.java b/lib/taskana-core/src/main/java/pro/taskana/ClassificationSummary.java index a390cc86d..fcc188439 100644 --- a/lib/taskana-core/src/main/java/pro/taskana/ClassificationSummary.java +++ b/lib/taskana-core/src/main/java/pro/taskana/ClassificationSummary.java @@ -84,14 +84,6 @@ public interface ClassificationSummary { */ String getCustom1(); - /** - * Set/Change the 1. custom-attribute. - * - * @param custom1 - * the first custom attribute - */ - void setCustom1(String custom1); - /** * Get the 2. custom-attribute. * @@ -99,14 +91,6 @@ public interface ClassificationSummary { */ String getCustom2(); - /** - * Set/Change the 2. custom-attribute. - * - * @param custom2 - * the second custom attribute - */ - void setCustom2(String custom2); - /** * Get the 3. custom-attribute. * @@ -114,14 +98,6 @@ public interface ClassificationSummary { */ String getCustom3(); - /** - * Set/Change the 3. custom-attribute. - * - * @param custom3 - * the third custom attribute - */ - void setCustom3(String custom3); - /** * Get the 4. custom-attribute. * @@ -129,14 +105,6 @@ public interface ClassificationSummary { */ String getCustom4(); - /** - * Set/Change the 4. custom-attribute. - * - * @param custom4 - * the fourth custom attribute - */ - void setCustom4(String custom4); - /** * Get the 5. custom-attribute. * @@ -144,14 +112,6 @@ public interface ClassificationSummary { */ String getCustom5(); - /** - * Set/Change the 5. custom-attribute. - * - * @param custom5 - * the fifth custom attribute - */ - void setCustom5(String custom5); - /** * Get the 6. custom-attribute. * @@ -159,29 +119,13 @@ public interface ClassificationSummary { */ String getCustom6(); - /** - * Set/Change the 6. custom-attribute. - * - * @param custom6 - * the sixth custom attribute - */ - void setCustom6(String custom6); - - /** + /** * Get the 7. custom-attribute. * * @return custom7 */ String getCustom7(); - /** - * Set/Change the 7. custom-attribute. - * - * @param custom7 - * the seventh custom attribute - */ - void setCustom7(String custom7); - /** * Get the 8. custom-attribute. * @@ -189,12 +133,4 @@ public interface ClassificationSummary { */ String getCustom8(); - /** - * Set/Change the 8. custom-attribute. - * - * @param custom8 - * the eight custom attribute - */ - void setCustom8(String custom8); - } diff --git a/lib/taskana-core/src/main/java/pro/taskana/impl/ClassificationSummaryImpl.java b/lib/taskana-core/src/main/java/pro/taskana/impl/ClassificationSummaryImpl.java index a6c6a784b..4b7fc829f 100644 --- a/lib/taskana-core/src/main/java/pro/taskana/impl/ClassificationSummaryImpl.java +++ b/lib/taskana-core/src/main/java/pro/taskana/impl/ClassificationSummaryImpl.java @@ -126,7 +126,6 @@ public class ClassificationSummaryImpl implements ClassificationSummary { return custom1; } - @Override public void setCustom1(String custom1) { this.custom1 = custom1; } @@ -136,7 +135,6 @@ public class ClassificationSummaryImpl implements ClassificationSummary { return custom2; } - @Override public void setCustom2(String custom2) { this.custom2 = custom2; } @@ -146,7 +144,6 @@ public class ClassificationSummaryImpl implements ClassificationSummary { return custom3; } - @Override public void setCustom3(String custom3) { this.custom3 = custom3; } @@ -156,7 +153,6 @@ public class ClassificationSummaryImpl implements ClassificationSummary { return custom4; } - @Override public void setCustom4(String custom4) { this.custom4 = custom4; } @@ -166,7 +162,6 @@ public class ClassificationSummaryImpl implements ClassificationSummary { return custom5; } - @Override public void setCustom5(String custom5) { this.custom5 = custom5; } @@ -176,7 +171,6 @@ public class ClassificationSummaryImpl implements ClassificationSummary { return custom6; } - @Override public void setCustom6(String custom6) { this.custom6 = custom6; } @@ -186,7 +180,6 @@ public class ClassificationSummaryImpl implements ClassificationSummary { return custom7; } - @Override public void setCustom7(String custom7) { this.custom7 = custom7; } @@ -196,7 +189,6 @@ public class ClassificationSummaryImpl implements ClassificationSummary { return custom8; } - @Override public void setCustom8(String custom8) { this.custom8 = custom8; }