nosu
/
taskana
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

TSK-1976: set ownerLongName during Task creation

This commit is contained in:
Elena Mokeeva 2023-01-13 09:37:22 +01:00 committed by Mustapha Zorgati
parent a6ede02524
commit 68eacbbc3e
2 changed files with 46 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
lib/taskana-core/src/main/java/pro/taskana/task/internal/TaskServiceImpl.java
View File

@ -1716,6 +1716,13 @@ public class TaskServiceImpl implements TaskService {
if (task.getDescription() == null && classification != null) { if (task.getDescription() == null && classification != null) {
task.setDescription(classification.getDescription()); task.setDescription(classification.getDescription());
} }
if (task.getOwner() != null
&& taskanaEngine.getEngine().getConfiguration().getAddAdditionalUserInfo()) {
User user = userMapper.findById(task.getOwner());
if (user != null) {
task.setOwnerLongName(user.getLongName());
}
}
setDefaultTaskReceivedDateFromAttachments(task); setDefaultTaskReceivedDateFromAttachments(task);
attachmentHandler.insertNewAttachmentsOnTaskCreation(task); attachmentHandler.insertNewAttachmentsOnTaskCreation(task);

57
lib/taskana-core/src/test/java/acceptance/task/create/CreateTaskAccTest.java
View File

@ -108,8 +108,7 @@ class CreateTaskAccTest extends AbstractAccTest {
@WithAccessId(user = "user-1-1") @WithAccessId(user = "user-1-1")
@Test @Test
void testCreateSimpleManualTask() throws Exception { void should_CreateSimpleManualTask() throws Exception {
Task newTask = taskService.newTask("USER-1-1", "DOMAIN_A"); Task newTask = taskService.newTask("USER-1-1", "DOMAIN_A");
newTask.setClassificationKey("T2100"); newTask.setClassificationKey("T2100");
ObjectReferenceImpl objectReference = ObjectReferenceImpl objectReference =
@ -144,6 +143,27 @@ class CreateTaskAccTest extends AbstractAccTest {
assertThat(createdTask.isTransferred()).isFalse(); assertThat(createdTask.isTransferred()).isFalse();
} }
@WithAccessId(user = "user-1-1")
@Test
void should_CreateTaskWithAdditionalUserInfo() throws Exception {
taskanaEngine.getConfiguration().setAddAdditionalUserInfo(true);
Task newTask = taskService.newTask("USER-1-1", "DOMAIN_A");
newTask.setClassificationKey("T2100");
ObjectReferenceImpl objectReference =
createObjectReference("COMPANY_A", "SYSTEM_A", "INSTANCE_A", "VNR", "1234567");
objectReference.setTaskId(newTask.getId());
newTask.setPrimaryObjRef(objectReference);
newTask.setOwner("user-1-1");
Task createdTask = taskService.createTask(newTask);
assertThat(createdTask).isNotNull();
assertThat(createdTask.getOwner()).isEqualTo("user-1-1");
assertThat(createdTask.getOwnerLongName()).isEqualTo("Mustermann, Max - (user-1-1)");
taskanaEngine.getConfiguration().setAddAdditionalUserInfo(false);
}
@WithAccessId(user = "user-1-1") @WithAccessId(user = "user-1-1")
@Test @Test
void should_PreventTimestampServiceLevelMismatch_When_ConfigurationPreventsIt() { void should_PreventTimestampServiceLevelMismatch_When_ConfigurationPreventsIt() {
@ -237,7 +257,7 @@ class CreateTaskAccTest extends AbstractAccTest {
@WithAccessId(user = "user-1-1") @WithAccessId(user = "user-1-1")
@Test @Test
void testIdempotencyOfTaskCreation() throws Exception { void should_ThrowException_When_CreatingTheSameTaskTwice() throws Exception {
Task newTask = taskService.newTask("USER-1-1", "DOMAIN_A"); Task newTask = taskService.newTask("USER-1-1", "DOMAIN_A");
newTask.setExternalId("MyExternalId"); newTask.setExternalId("MyExternalId");
@ -278,7 +298,7 @@ class CreateTaskAccTest extends AbstractAccTest {
@WithAccessId(user = "user-1-1") @WithAccessId(user = "user-1-1")
@Test @Test
void testCreateSimpleTaskWithCustomAttributes() throws Exception { void should_CreateTask_When_CustomAttributesAreSpecified() throws Exception {
Task newTask = taskService.newTask("USER-1-1", "DOMAIN_A"); Task newTask = taskService.newTask("USER-1-1", "DOMAIN_A");
newTask.setClassificationKey("T2100"); newTask.setClassificationKey("T2100");
@ -346,7 +366,7 @@ class CreateTaskAccTest extends AbstractAccTest {
@WithAccessId(user = "user-1-1") @WithAccessId(user = "user-1-1")
@Test @Test
void testCreateExternalTaskWithAttachment() throws Exception { void should_CreateTask_When_AttachmentIsSpecified() throws Exception {
Task newTask = taskService.newTask("USER-1-1", "DOMAIN_A"); Task newTask = taskService.newTask("USER-1-1", "DOMAIN_A");
newTask.setClassificationKey("L12010"); newTask.setClassificationKey("L12010");
@ -422,7 +442,7 @@ class CreateTaskAccTest extends AbstractAccTest {
@WithAccessId(user = "user-1-1") @WithAccessId(user = "user-1-1")
@Test @Test
void testCreateExternalTaskWithMultipleAttachments() throws Exception { void should_CreateTask_When_MultipleAttachmentsAreSpecified() throws Exception {
Instant earlierInstant = Instant.parse("2018-01-12T00:00:00Z"); Instant earlierInstant = Instant.parse("2018-01-12T00:00:00Z");
Instant laterInstant = Instant.parse("2018-01-15T00:00:00Z"); Instant laterInstant = Instant.parse("2018-01-15T00:00:00Z");
@ -477,7 +497,8 @@ class CreateTaskAccTest extends AbstractAccTest {
@WithAccessId(user = "user-1-1") @WithAccessId(user = "user-1-1")
@Test @Test
void testPrioDurationOfTaskFromAttachmentsAtCreate() throws Exception { void should_SetPriorityAndDurationCorrectly_When_UsingClassificationOfAttachment()
throws Exception {
Task newTask = taskService.newTask("USER-1-1", "DOMAIN_A"); Task newTask = taskService.newTask("USER-1-1", "DOMAIN_A");
newTask.setClassificationKey("L12010"); // prio 8, SL P7D newTask.setClassificationKey("L12010"); // prio 8, SL P7D
@ -536,7 +557,7 @@ class CreateTaskAccTest extends AbstractAccTest {
@WithAccessId(user = "user-1-1") @WithAccessId(user = "user-1-1")
@Test @Test
void testThrowsExceptionIfAttachmentIsInvalid() throws Exception { void should_ThrowException_When_AttachmentIsInvalid() throws Exception {
Consumer<Attachment> testCreateTask = Consumer<Attachment> testCreateTask =
invalidAttachment -> { invalidAttachment -> {
@ -595,7 +616,7 @@ class CreateTaskAccTest extends AbstractAccTest {
@WithAccessId(user = "user-1-1") @WithAccessId(user = "user-1-1")
@Test @Test
void testUseCustomNameIfSetForNewTask() throws Exception { void should_UseCustomName_For_NewTask() throws Exception {
Task newTask = taskService.newTask("USER-1-1", "DOMAIN_A"); Task newTask = taskService.newTask("USER-1-1", "DOMAIN_A");
newTask.setClassificationKey("T2100"); newTask.setClassificationKey("T2100");
@ -612,7 +633,7 @@ class CreateTaskAccTest extends AbstractAccTest {
@WithAccessId(user = "user-1-1") @WithAccessId(user = "user-1-1")
@Test @Test
void testUseClassificationMetadataFromCorrectDomainForNewTask() throws Exception { void should_UseClassificationMetadataFromCorrectDomain_For_NewTask() throws Exception {
Task newTask = taskService.newTask("USER-1-1", "DOMAIN_A"); Task newTask = taskService.newTask("USER-1-1", "DOMAIN_A");
newTask.setClassificationKey("T2100"); newTask.setClassificationKey("T2100");
@ -629,7 +650,7 @@ class CreateTaskAccTest extends AbstractAccTest {
@WithAccessId(user = "user-1-1") @WithAccessId(user = "user-1-1")
@Test @Test
void testGetExceptionIfWorkbasketDoesNotExist() { void should_ThrowExceptionIfWorkbasketDoesNotExist() {
Task newTask = taskService.newTask("UNKNOWN"); Task newTask = taskService.newTask("UNKNOWN");
newTask.setClassificationKey("T2100"); newTask.setClassificationKey("T2100");
@ -655,7 +676,7 @@ class CreateTaskAccTest extends AbstractAccTest {
@WithAccessId(user = "user-1-1") @WithAccessId(user = "user-1-1")
@Test @Test
void testThrowsExceptionIfMandatoryPrimaryObjectReferenceIsNotSetOrIncomplete() { void should_ThrowException_When_MandatoryPrimaryObjectReferenceIsNotSetOrIncomplete() {
Consumer<ObjectReference> testCreateTask = Consumer<ObjectReference> testCreateTask =
(ObjectReference objectReference) -> { (ObjectReference objectReference) -> {
@ -681,7 +702,7 @@ class CreateTaskAccTest extends AbstractAccTest {
@WithAccessId(user = "user-1-1") @WithAccessId(user = "user-1-1")
@Test @Test
void testSetDomainFromWorkbasket() throws Exception { void should_SetDomainFromWorkbasket() throws Exception {
WorkbasketService workbasketService = taskanaEngine.getWorkbasketService(); WorkbasketService workbasketService = taskanaEngine.getWorkbasketService();
@ -702,7 +723,7 @@ class CreateTaskAccTest extends AbstractAccTest {
@WithAccessId(user = "user-1-1") @WithAccessId(user = "user-1-1")
@Test @Test
void testCreatedTaskObjectEqualsReadTaskObject() throws Exception { void should_ReadSameTaskObjectAsCreated() throws Exception {
Task newTask = taskService.newTask("USER-1-1", "DOMAIN_A"); Task newTask = taskService.newTask("USER-1-1", "DOMAIN_A");
newTask.setClassificationKey("T2100"); newTask.setClassificationKey("T2100");
@ -734,7 +755,7 @@ class CreateTaskAccTest extends AbstractAccTest {
@WithAccessId(user = "user-1-1") @WithAccessId(user = "user-1-1")
@Test @Test
void testCreateSimpleTaskWithCallbackInfo() throws Exception { void should_CreateSimpleTask_When_CallbackInfoIsSet() throws Exception {
Task newTask = taskService.newTask("USER-1-1", "DOMAIN_A"); Task newTask = taskService.newTask("USER-1-1", "DOMAIN_A");
newTask.setClassificationKey("T2100"); newTask.setClassificationKey("T2100");
@ -766,7 +787,7 @@ class CreateTaskAccTest extends AbstractAccTest {
} }
@Test @Test
void testCreateTaskWithSecurityButNoUserId() { void should_ThrowException_When_NoUserIdIsSetAndSecurityIsOn() {
Task newTask = taskService.newTask("USER-1-1", "DOMAIN_A"); Task newTask = taskService.newTask("USER-1-1", "DOMAIN_A");
newTask.setClassificationKey("T2100"); newTask.setClassificationKey("T2100");
@ -790,7 +811,7 @@ class CreateTaskAccTest extends AbstractAccTest {
@WithAccessId(user = "user-1-1") @WithAccessId(user = "user-1-1")
@Test @Test
void testCreateTaskNotAuthorizedOnWorkbasket() { void should_ThrowException_When_UserNotAuthorizedOnWorkbasket() {
Task task = taskService.newTask("TEAMLEAD-2", "DOMAIN_A"); Task task = taskService.newTask("TEAMLEAD-2", "DOMAIN_A");
@ -809,7 +830,7 @@ class CreateTaskAccTest extends AbstractAccTest {
@WithAccessId(user = "admin") @WithAccessId(user = "admin")
@Test @Test
void testCreateTaskWithWorkbasketMarkedForDeletion() throws Exception { void should_ThrowException_When_WorkbasketMarkedForDeletion() throws Exception {
String wbId = "WBI:100000000000000000000000000000000008"; String wbId = "WBI:100000000000000000000000000000000008";
Task taskToPreventWorkbasketDeletion = taskService.newTask(wbId); Task taskToPreventWorkbasketDeletion = taskService.newTask(wbId);