TSK-1838: automatic linting fixes introduced from dependency upgrades

This commit is contained in:
Mustapha Zorgati 2022-04-06 15:39:45 +02:00
parent 541985b007
commit 6fb9dcf1c7
11 changed files with 319 additions and 347 deletions

View File

@ -104,49 +104,47 @@ describe('ClassificationDetailsComponent', () => {
let store: Store;
let actions$: Observable<any>;
beforeEach(
waitForAsync(() => {
TestBed.configureTestingModule({
imports: [
NgxsModule.forRoot([ClassificationState, EngineConfigurationState]),
FormsModule,
MatIconModule,
MatToolbarModule,
MatDividerModule,
MatFormFieldModule,
MatInputModule,
MatOptionModule,
MatSelectModule,
MatProgressBarModule,
MatMenuModule,
MatTooltipModule,
NoopAnimationsModule
],
declarations: [ClassificationDetailsComponent, InputStub, FieldErrorDisplayStub, SvgIconStub, TextareaStub],
providers: [
{ provide: ClassificationsService, useValue: classificationServiceSpy },
{ provide: ClassificationCategoriesService, useValue: classificationCategoriesServiceSpy },
{ provide: DomainService, useValue: domainServiceSpy },
{ provide: ImportExportService, useValue: importExportServiceSpy },
{ provide: RequestInProgressService, useValue: requestInProgressServiceSpy },
{ provide: FormsValidatorService, useValue: formsValidatorServiceSpy },
{ provide: NotificationService, useValue: notificationServiceSpy }
]
}).compileComponents();
beforeEach(waitForAsync(() => {
TestBed.configureTestingModule({
imports: [
NgxsModule.forRoot([ClassificationState, EngineConfigurationState]),
FormsModule,
MatIconModule,
MatToolbarModule,
MatDividerModule,
MatFormFieldModule,
MatInputModule,
MatOptionModule,
MatSelectModule,
MatProgressBarModule,
MatMenuModule,
MatTooltipModule,
NoopAnimationsModule
],
declarations: [ClassificationDetailsComponent, InputStub, FieldErrorDisplayStub, SvgIconStub, TextareaStub],
providers: [
{ provide: ClassificationsService, useValue: classificationServiceSpy },
{ provide: ClassificationCategoriesService, useValue: classificationCategoriesServiceSpy },
{ provide: DomainService, useValue: domainServiceSpy },
{ provide: ImportExportService, useValue: importExportServiceSpy },
{ provide: RequestInProgressService, useValue: requestInProgressServiceSpy },
{ provide: FormsValidatorService, useValue: formsValidatorServiceSpy },
{ provide: NotificationService, useValue: notificationServiceSpy }
]
}).compileComponents();
fixture = TestBed.createComponent(ClassificationDetailsComponent);
debugElement = fixture.debugElement;
component = fixture.debugElement.componentInstance;
store = TestBed.inject(Store);
actions$ = TestBed.inject(Actions);
store.reset({
...store.snapshot(),
classification: classificationStateMock,
engineConfiguration: engineConfigurationMock
});
fixture.detectChanges();
})
);
fixture = TestBed.createComponent(ClassificationDetailsComponent);
debugElement = fixture.debugElement;
component = fixture.debugElement.componentInstance;
store = TestBed.inject(Store);
actions$ = TestBed.inject(Actions);
store.reset({
...store.snapshot(),
classification: classificationStateMock,
engineConfiguration: engineConfigurationMock
});
fixture.detectChanges();
}));
it('should create component', () => {
expect(component).toBeTruthy();

View File

@ -43,33 +43,31 @@ xdescribe('ImportExportComponent', () => {
})
);
beforeEach(
waitForAsync(() => {
TestBed.configureTestingModule({
imports: [],
declarations: [ImportExportComponent],
providers: [
StartupService,
TaskanaEngineService,
WindowRefService,
WorkbasketDefinitionService,
ClassificationDefinitionService,
ImportExportService,
{ provide: DomainService, useClass: domainServiceSpy },
{ provide: NotificationService, useClass: notificationServiceSpy },
{ provide: HttpClient, useClass: httpSpy }
]
}).compileComponents();
beforeEach(waitForAsync(() => {
TestBed.configureTestingModule({
imports: [],
declarations: [ImportExportComponent],
providers: [
StartupService,
TaskanaEngineService,
WindowRefService,
WorkbasketDefinitionService,
ClassificationDefinitionService,
ImportExportService,
{ provide: DomainService, useClass: domainServiceSpy },
{ provide: NotificationService, useClass: notificationServiceSpy },
{ provide: HttpClient, useClass: httpSpy }
]
}).compileComponents();
jest.clearAllMocks();
jest.clearAllMocks();
fixture = TestBed.createComponent(ImportExportComponent);
debugElement = fixture.debugElement;
app = fixture.debugElement.componentInstance;
app.currentSelection = TaskanaType.WORKBASKETS;
fixture.detectChanges();
})
);
fixture = TestBed.createComponent(ImportExportComponent);
debugElement = fixture.debugElement;
app = fixture.debugElement.componentInstance;
app.currentSelection = TaskanaType.WORKBASKETS;
fixture.detectChanges();
}));
it('should create component', () => {
expect(app).toBeTruthy();

View File

@ -73,46 +73,44 @@ describe('WorkbasketDistributionTargetsListComponent', () => {
setRequestInProgress: jest.fn().mockReturnValue(of(null))
};
beforeEach(
waitForAsync(() => {
TestBed.configureTestingModule({
imports: [
MatIconModule,
MatToolbarModule,
MatListModule,
MatDialogModule,
MatTooltipModule,
InfiniteScrollModule,
ScrollingModule,
NoopAnimationsModule,
NgxsModule.forRoot([WorkbasketState])
],
declarations: [WorkbasketDistributionTargetsListComponent, FilterStub, SpinnerStub, IconTypeStub, OrderByMock],
providers: [
{ provide: HttpClient, useValue: httpSpy },
{
provide: DomainService,
useValue: domainServiceSpy
},
{ provide: ActivatedRoute, useValue: activatedRouteMock },
{ provide: RequestInProgressService, useValue: requestInProgressServiceSpy }
]
}).compileComponents();
beforeEach(waitForAsync(() => {
TestBed.configureTestingModule({
imports: [
MatIconModule,
MatToolbarModule,
MatListModule,
MatDialogModule,
MatTooltipModule,
InfiniteScrollModule,
ScrollingModule,
NoopAnimationsModule,
NgxsModule.forRoot([WorkbasketState])
],
declarations: [WorkbasketDistributionTargetsListComponent, FilterStub, SpinnerStub, IconTypeStub, OrderByMock],
providers: [
{ provide: HttpClient, useValue: httpSpy },
{
provide: DomainService,
useValue: domainServiceSpy
},
{ provide: ActivatedRoute, useValue: activatedRouteMock },
{ provide: RequestInProgressService, useValue: requestInProgressServiceSpy }
]
}).compileComponents();
fixture = TestBed.createComponent(WorkbasketDistributionTargetsListComponent);
debugElement = fixture.debugElement;
component = fixture.componentInstance;
component.distributionTargets = workbasketReadStateMock.paginatedWorkbasketsSummary.workbaskets;
component.side = Side.AVAILABLE;
component.transferDistributionTargetObservable = EMPTY;
store = TestBed.inject(Store);
store.reset({
...store.snapshot(),
engineConfiguration: engineConfigurationMock,
workbasket: workbasketReadStateMock
});
})
);
fixture = TestBed.createComponent(WorkbasketDistributionTargetsListComponent);
debugElement = fixture.debugElement;
component = fixture.componentInstance;
component.distributionTargets = workbasketReadStateMock.paginatedWorkbasketsSummary.workbaskets;
component.side = Side.AVAILABLE;
component.transferDistributionTargetObservable = EMPTY;
store = TestBed.inject(Store);
store.reset({
...store.snapshot(),
engineConfiguration: engineConfigurationMock,
workbasket: workbasketReadStateMock
});
}));
it('should create component', () => {
expect(component).toBeTruthy();

View File

@ -58,39 +58,37 @@ describe('WorkbasketDistributionTargetsComponent', () => {
let store: Store;
let actions$: Observable<any>;
beforeEach(
waitForAsync(() => {
TestBed.configureTestingModule({
imports: [
MatIconModule,
MatDialogModule,
MatToolbarModule,
MatButtonModule,
NgxsModule.forRoot([WorkbasketState])
],
declarations: [WorkbasketDistributionTargetsComponent, WorkbasketDistributionTargetsListStub],
providers: [
{ provide: WorkbasketService, useValue: workbasketServiceSpy },
{ provide: NotificationService, useValue: notificationsServiceSpy },
{ provide: ActivatedRoute, useValue: activatedRouteMock },
{ provide: RequestInProgressService, useValue: requestInProgressServiceSpy },
{ provide: DomainService, useValue: domainServiceSpy }
]
}).compileComponents();
beforeEach(waitForAsync(() => {
TestBed.configureTestingModule({
imports: [
MatIconModule,
MatDialogModule,
MatToolbarModule,
MatButtonModule,
NgxsModule.forRoot([WorkbasketState])
],
declarations: [WorkbasketDistributionTargetsComponent, WorkbasketDistributionTargetsListStub],
providers: [
{ provide: WorkbasketService, useValue: workbasketServiceSpy },
{ provide: NotificationService, useValue: notificationsServiceSpy },
{ provide: ActivatedRoute, useValue: activatedRouteMock },
{ provide: RequestInProgressService, useValue: requestInProgressServiceSpy },
{ provide: DomainService, useValue: domainServiceSpy }
]
}).compileComponents();
fixture = TestBed.createComponent(WorkbasketDistributionTargetsComponent);
debugElement = fixture.debugElement;
component = fixture.componentInstance;
store = TestBed.inject(Store);
actions$ = TestBed.inject(Actions);
store.reset({
...store.snapshot(),
engineConfiguration: engineConfigurationMock,
workbasket: workbasketReadStateMock
});
fixture.detectChanges();
})
);
fixture = TestBed.createComponent(WorkbasketDistributionTargetsComponent);
debugElement = fixture.debugElement;
component = fixture.componentInstance;
store = TestBed.inject(Store);
actions$ = TestBed.inject(Actions);
store.reset({
...store.snapshot(),
engineConfiguration: engineConfigurationMock,
workbasket: workbasketReadStateMock
});
fixture.detectChanges();
}));
it('should create component', () => {
expect(component).toBeTruthy();

View File

@ -86,63 +86,61 @@ describe('WorkbasketInformationComponent', () => {
let store: Store;
let actions$: Observable<any>;
beforeEach(
waitForAsync(() => {
TestBed.configureTestingModule({
imports: [
FormsModule,
HttpClientTestingModule,
MatDialogModule,
NgxsModule.forRoot([EngineConfigurationState, WorkbasketState]),
TypeaheadModule.forRoot(),
ReactiveFormsModule,
RouterTestingModule.withRoutes([]),
NoopAnimationsModule,
MatProgressBarModule,
MatDividerModule,
MatFormFieldModule,
MatInputModule,
MatSelectModule,
MatAutocompleteModule,
MatTooltipModule
],
declarations: [
WorkbasketInformationComponent,
FieldErrorDisplayStub,
IconTypeStub,
TypeAheadComponent,
MapValuesPipe,
RemoveNoneTypePipe
],
providers: [
{ provide: WorkbasketService, useValue: workbasketServiceMock },
{ provide: FormsValidatorService, useValue: formValidatorServiceMock },
{ provide: NotificationService, useValue: notificationServiceMock },
RequestInProgressService,
DomainService,
SelectedRouteService,
ClassificationCategoriesService,
StartupService,
TaskanaEngineService,
WindowRefService
]
}).compileComponents();
beforeEach(waitForAsync(() => {
TestBed.configureTestingModule({
imports: [
FormsModule,
HttpClientTestingModule,
MatDialogModule,
NgxsModule.forRoot([EngineConfigurationState, WorkbasketState]),
TypeaheadModule.forRoot(),
ReactiveFormsModule,
RouterTestingModule.withRoutes([]),
NoopAnimationsModule,
MatProgressBarModule,
MatDividerModule,
MatFormFieldModule,
MatInputModule,
MatSelectModule,
MatAutocompleteModule,
MatTooltipModule
],
declarations: [
WorkbasketInformationComponent,
FieldErrorDisplayStub,
IconTypeStub,
TypeAheadComponent,
MapValuesPipe,
RemoveNoneTypePipe
],
providers: [
{ provide: WorkbasketService, useValue: workbasketServiceMock },
{ provide: FormsValidatorService, useValue: formValidatorServiceMock },
{ provide: NotificationService, useValue: notificationServiceMock },
RequestInProgressService,
DomainService,
SelectedRouteService,
ClassificationCategoriesService,
StartupService,
TaskanaEngineService,
WindowRefService
]
}).compileComponents();
fixture = TestBed.createComponent(WorkbasketInformationComponent);
debugElement = fixture.debugElement;
component = fixture.componentInstance;
store = TestBed.inject(Store);
actions$ = TestBed.inject(Actions);
store.reset({
...store.snapshot(),
engineConfiguration: engineConfigurationMock,
workbasket: workbasketReadStateMock
});
component.workbasket = selectedWorkbasketMock;
fixture = TestBed.createComponent(WorkbasketInformationComponent);
debugElement = fixture.debugElement;
component = fixture.componentInstance;
store = TestBed.inject(Store);
actions$ = TestBed.inject(Actions);
store.reset({
...store.snapshot(),
engineConfiguration: engineConfigurationMock,
workbasket: workbasketReadStateMock
});
component.workbasket = selectedWorkbasketMock;
fixture.detectChanges();
})
);
fixture.detectChanges();
}));
it('should create component', () => {
expect(component).toBeTruthy();
@ -174,29 +172,23 @@ describe('WorkbasketInformationComponent', () => {
expect(component.workbasket).toMatchObject(component.workbasketClone);
});
it(
'should save workbasket when workbasketId there',
waitForAsync(() => {
component.workbasket = { ...selectedWorkbasketMock };
component.workbasket.workbasketId = '1';
component.action = ACTION.COPY;
let actionDispatched = false;
actions$.pipe(ofActionDispatched(UpdateWorkbasket)).subscribe(() => (actionDispatched = true));
component.onSave();
expect(actionDispatched).toBe(true);
expect(component.workbasketClone).toMatchObject(component.workbasket);
})
);
it('should save workbasket when workbasketId there', waitForAsync(() => {
component.workbasket = { ...selectedWorkbasketMock };
component.workbasket.workbasketId = '1';
component.action = ACTION.COPY;
let actionDispatched = false;
actions$.pipe(ofActionDispatched(UpdateWorkbasket)).subscribe(() => (actionDispatched = true));
component.onSave();
expect(actionDispatched).toBe(true);
expect(component.workbasketClone).toMatchObject(component.workbasket);
}));
it(
'should dispatch MarkWorkbasketforDeletion action when onRemoveConfirmed is called',
waitForAsync(() => {
let actionDispatched = false;
actions$.pipe(ofActionDispatched(MarkWorkbasketForDeletion)).subscribe(() => (actionDispatched = true));
component.onRemoveConfirmed();
expect(actionDispatched).toBe(true);
})
);
it('should dispatch MarkWorkbasketforDeletion action when onRemoveConfirmed is called', waitForAsync(() => {
let actionDispatched = false;
actions$.pipe(ofActionDispatched(MarkWorkbasketForDeletion)).subscribe(() => (actionDispatched = true));
component.onRemoveConfirmed();
expect(actionDispatched).toBe(true);
}));
it('should create new workbasket when workbasketId is undefined', () => {
component.workbasket.workbasketId = undefined;

View File

@ -13,25 +13,23 @@ describe('CanvasComponent', () => {
let debugElement: DebugElement;
let component: CanvasComponent;
beforeEach(
waitForAsync(() => {
TestBed.configureTestingModule({
imports: [NgxsModule.forRoot([SettingsState]), HttpClientTestingModule, MatDialogModule],
declarations: [CanvasComponent]
}).compileComponents();
beforeEach(waitForAsync(() => {
TestBed.configureTestingModule({
imports: [NgxsModule.forRoot([SettingsState]), HttpClientTestingModule, MatDialogModule],
declarations: [CanvasComponent]
}).compileComponents();
fixture = TestBed.createComponent(CanvasComponent);
debugElement = fixture.debugElement;
component = fixture.debugElement.componentInstance;
component.id = '1';
const store: Store = TestBed.inject(Store);
store.reset({
...store.snapshot(),
settings: settingsStateMock
});
fixture.detectChanges();
})
);
fixture = TestBed.createComponent(CanvasComponent);
debugElement = fixture.debugElement;
component = fixture.debugElement.componentInstance;
component.id = '1';
const store: Store = TestBed.inject(Store);
store.reset({
...store.snapshot(),
settings: settingsStateMock
});
fixture.detectChanges();
}));
it('should create the component', () => {
expect(component).toBeTruthy();

View File

@ -15,31 +15,29 @@ describe('TaskPriorityReportFilterComponent', () => {
let debugElement: DebugElement;
let component: TaskPriorityReportFilterComponent;
beforeEach(
waitForAsync(() => {
TestBed.configureTestingModule({
imports: [
NgxsModule.forRoot([SettingsState]),
HttpClientTestingModule,
MatCheckboxModule,
MatExpansionModule,
NoopAnimationsModule,
MatDialogModule
],
declarations: [TaskPriorityReportFilterComponent]
}).compileComponents();
beforeEach(waitForAsync(() => {
TestBed.configureTestingModule({
imports: [
NgxsModule.forRoot([SettingsState]),
HttpClientTestingModule,
MatCheckboxModule,
MatExpansionModule,
NoopAnimationsModule,
MatDialogModule
],
declarations: [TaskPriorityReportFilterComponent]
}).compileComponents();
fixture = TestBed.createComponent(TaskPriorityReportFilterComponent);
debugElement = fixture.debugElement;
component = fixture.debugElement.componentInstance;
const store: Store = TestBed.inject(Store);
store.reset({
...store.snapshot(),
settings: settingsStateMock
});
fixture.detectChanges();
})
);
fixture = TestBed.createComponent(TaskPriorityReportFilterComponent);
debugElement = fixture.debugElement;
component = fixture.debugElement.componentInstance;
const store: Store = TestBed.inject(Store);
store.reset({
...store.snapshot(),
settings: settingsStateMock
});
fixture.detectChanges();
}));
it('should create the component', () => {
expect(component).toBeTruthy();

View File

@ -43,29 +43,27 @@ describe('TaskPriorityReportComponent', () => {
let debugElement: DebugElement;
let component: TaskPriorityReportComponent;
beforeEach(
waitForAsync(() => {
TestBed.configureTestingModule({
imports: [NgxsModule.forRoot([SettingsState]), MatTableModule, HttpClientTestingModule, MatDividerModule],
declarations: [TaskPriorityReportComponent, GermanTimeFormatPipe, CanvasStub, TaskPriorityReportFilterStub],
providers: [
RequestInProgressService,
{ provide: MonitorService, useValue: monitorServiceSpy },
{ provide: NotificationService, useValue: notificationServiceSpy }
]
}).compileComponents();
beforeEach(waitForAsync(() => {
TestBed.configureTestingModule({
imports: [NgxsModule.forRoot([SettingsState]), MatTableModule, HttpClientTestingModule, MatDividerModule],
declarations: [TaskPriorityReportComponent, GermanTimeFormatPipe, CanvasStub, TaskPriorityReportFilterStub],
providers: [
RequestInProgressService,
{ provide: MonitorService, useValue: monitorServiceSpy },
{ provide: NotificationService, useValue: notificationServiceSpy }
]
}).compileComponents();
fixture = TestBed.createComponent(TaskPriorityReportComponent);
debugElement = fixture.debugElement;
component = fixture.debugElement.componentInstance;
const store: Store = TestBed.inject(Store);
store.reset({
...store.snapshot(),
settings: settingsStateMock
});
fixture.detectChanges();
})
);
fixture = TestBed.createComponent(TaskPriorityReportComponent);
debugElement = fixture.debugElement;
component = fixture.debugElement.componentInstance;
const store: Store = TestBed.inject(Store);
store.reset({
...store.snapshot(),
settings: settingsStateMock
});
fixture.detectChanges();
}));
it('should create the component', () => {
expect(component).toBeTruthy();

View File

@ -29,41 +29,39 @@ describe('SettingsComponent', () => {
let store: Store;
let actions$: Observable<any>;
beforeEach(
waitForAsync(() => {
TestBed.configureTestingModule({
imports: [
NgxsModule.forRoot([SettingsState]),
HttpClientTestingModule,
FormsModule,
MatIconModule,
MatFormFieldModule,
MatInputModule,
MatTooltipModule,
NoopAnimationsModule
],
declarations: [SettingsComponent],
providers: [
RequestInProgressService,
{
provide: NotificationService,
useValue: notificationServiceSpy
}
]
}).compileComponents();
beforeEach(waitForAsync(() => {
TestBed.configureTestingModule({
imports: [
NgxsModule.forRoot([SettingsState]),
HttpClientTestingModule,
FormsModule,
MatIconModule,
MatFormFieldModule,
MatInputModule,
MatTooltipModule,
NoopAnimationsModule
],
declarations: [SettingsComponent],
providers: [
RequestInProgressService,
{
provide: NotificationService,
useValue: notificationServiceSpy
}
]
}).compileComponents();
fixture = TestBed.createComponent(SettingsComponent);
debugElement = fixture.debugElement;
component = fixture.debugElement.componentInstance;
store = TestBed.inject(Store);
actions$ = TestBed.inject(Actions);
store.reset({
...store.snapshot(),
settings: settingsStateMock
});
fixture.detectChanges();
})
);
fixture = TestBed.createComponent(SettingsComponent);
debugElement = fixture.debugElement;
component = fixture.debugElement.componentInstance;
store = TestBed.inject(Store);
actions$ = TestBed.inject(Actions);
store.reset({
...store.snapshot(),
settings: settingsStateMock
});
fixture.detectChanges();
}));
it('should create component', () => {
expect(component).toBeTruthy();

View File

@ -28,18 +28,16 @@ describe('NavBarComponent', () => {
let debugElement: DebugElement;
let route = '';
beforeEach(
waitForAsync(() => {
TestBed.configureTestingModule({
declarations: [NavBarComponent, SvgIconStub],
imports: [MatIconModule, HttpClientTestingModule, MatToolbarModule],
providers: [
{ provide: SidenavService, useValue: SidenavServiceSpy },
{ provide: SelectedRouteService, useValue: SelectedRouteServiceSpy }
]
}).compileComponents();
})
);
beforeEach(waitForAsync(() => {
TestBed.configureTestingModule({
declarations: [NavBarComponent, SvgIconStub],
imports: [MatIconModule, HttpClientTestingModule, MatToolbarModule],
providers: [
{ provide: SidenavService, useValue: SidenavServiceSpy },
{ provide: SelectedRouteService, useValue: SelectedRouteServiceSpy }
]
}).compileComponents();
}));
beforeEach(() => {
fixture = TestBed.createComponent(NavBarComponent);

View File

@ -20,29 +20,27 @@ describe('TypeAheadComponent with AccessId input', () => {
let debugElement: DebugElement;
let component: TypeAheadComponent;
beforeEach(
waitForAsync(() => {
TestBed.configureTestingModule({
imports: [
NgxsModule.forRoot([]),
MatFormFieldModule,
MatInputModule,
MatAutocompleteModule,
MatTooltipModule,
NoopAnimationsModule,
FormsModule,
ReactiveFormsModule
],
declarations: [TypeAheadComponent],
providers: [{ provide: AccessIdsService, useValue: accessIdService }]
}).compileComponents();
beforeEach(waitForAsync(() => {
TestBed.configureTestingModule({
imports: [
NgxsModule.forRoot([]),
MatFormFieldModule,
MatInputModule,
MatAutocompleteModule,
MatTooltipModule,
NoopAnimationsModule,
FormsModule,
ReactiveFormsModule
],
declarations: [TypeAheadComponent],
providers: [{ provide: AccessIdsService, useValue: accessIdService }]
}).compileComponents();
fixture = TestBed.createComponent(TypeAheadComponent);
debugElement = fixture.debugElement;
component = fixture.componentInstance;
fixture.detectChanges();
})
);
fixture = TestBed.createComponent(TypeAheadComponent);
debugElement = fixture.debugElement;
component = fixture.componentInstance;
fixture.detectChanges();
}));
it('should create component', () => {
expect(component).toBeTruthy();