Closes #2232 - Refactor DeleteTaskAccTest to use test-api
This commit is contained in:
jamesrdi
Elena Mokeeva
parent
7ca8561955
commit
81b28274e7
|
|
@ -0,0 +1,269 @@
|
||||||
|
package acceptance.task.delete;
|
||||||
|
|
||||||
|
import static org.assertj.core.api.Assertions.assertThat;
|
||||||
|
import static org.assertj.core.api.Assertions.catchThrowableOfType;
|
||||||
|
import static pro.taskana.testapi.DefaultTestEntities.defaultTestClassification;
|
||||||
|
import static pro.taskana.testapi.DefaultTestEntities.defaultTestObjectReference;
|
||||||
|
import static pro.taskana.testapi.DefaultTestEntities.defaultTestWorkbasket;
|
||||||
|
|
||||||
|
import java.util.List;
|
||||||
|
import org.assertj.core.api.ThrowableAssert.ThrowingCallable;
|
||||||
|
import org.junit.jupiter.api.BeforeAll;
|
||||||
|
import org.junit.jupiter.api.Test;
|
||||||
|
import org.junit.jupiter.api.TestTemplate;
|
||||||
|
import pro.taskana.classification.api.ClassificationService;
|
||||||
|
import pro.taskana.classification.api.models.ClassificationSummary;
|
||||||
|
import pro.taskana.common.api.BulkOperationResults;
|
||||||
|
import pro.taskana.common.api.TaskanaEngine;
|
||||||
|
import pro.taskana.common.api.TaskanaRole;
|
||||||
|
import pro.taskana.common.api.exceptions.NotAuthorizedException;
|
||||||
|
import pro.taskana.common.api.exceptions.TaskanaException;
|
||||||
|
import pro.taskana.task.api.TaskService;
|
||||||
|
import pro.taskana.task.api.TaskState;
|
||||||
|
import pro.taskana.task.api.exceptions.InvalidTaskStateException;
|
||||||
|
import pro.taskana.task.api.exceptions.TaskNotFoundException;
|
||||||
|
import pro.taskana.task.api.models.Attachment;
|
||||||
|
import pro.taskana.task.api.models.ObjectReference;
|
||||||
|
import pro.taskana.task.api.models.Task;
|
||||||
|
import pro.taskana.task.internal.AttachmentMapper;
|
||||||
|
import pro.taskana.testapi.DefaultTestEntities;
|
||||||
|
import pro.taskana.testapi.TaskanaEngineProxy;
|
||||||
|
import pro.taskana.testapi.TaskanaInject;
|
||||||
|
import pro.taskana.testapi.TaskanaIntegrationTest;
|
||||||
|
import pro.taskana.testapi.builder.TaskAttachmentBuilder;
|
||||||
|
import pro.taskana.testapi.builder.TaskBuilder;
|
||||||
|
import pro.taskana.testapi.builder.WorkbasketAccessItemBuilder;
|
||||||
|
import pro.taskana.testapi.security.WithAccessId;
|
||||||
|
import pro.taskana.workbasket.api.WorkbasketPermission;
|
||||||
|
import pro.taskana.workbasket.api.WorkbasketService;
|
||||||
|
import pro.taskana.workbasket.api.models.WorkbasketSummary;
|
||||||
|
|
||||||
|
@TaskanaIntegrationTest
|
||||||
|
class DeleteTaskAccTest {
|
||||||
|
@TaskanaInject TaskService taskService;
|
||||||
|
@TaskanaInject ClassificationService classificationService;
|
||||||
|
@TaskanaInject WorkbasketService workbasketService;
|
||||||
|
@TaskanaInject TaskanaEngine taskanaEngine;
|
||||||
|
|
||||||
|
Task task1;
|
||||||
|
Task task2;
|
||||||
|
ClassificationSummary defaultClassificationSummary;
|
||||||
|
WorkbasketSummary defaultWorkbasketSummary;
|
||||||
|
ObjectReference defaultObjectReference;
|
||||||
|
|
||||||
|
@WithAccessId(user = "admin")
|
||||||
|
@BeforeAll
|
||||||
|
void setup() throws Exception {
|
||||||
|
defaultClassificationSummary =
|
||||||
|
defaultTestClassification().buildAndStoreAsSummary(classificationService);
|
||||||
|
defaultWorkbasketSummary = defaultTestWorkbasket().buildAndStoreAsSummary(workbasketService);
|
||||||
|
defaultObjectReference = defaultTestObjectReference().build();
|
||||||
|
|
||||||
|
WorkbasketAccessItemBuilder.newWorkbasketAccessItem()
|
||||||
|
.workbasketId(defaultWorkbasketSummary.getId())
|
||||||
|
.accessId("user-1-2")
|
||||||
|
.permission(WorkbasketPermission.OPEN)
|
||||||
|
.permission(WorkbasketPermission.READ)
|
||||||
|
.permission(WorkbasketPermission.APPEND)
|
||||||
|
.buildAndStore(workbasketService);
|
||||||
|
task1 =
|
||||||
|
TaskBuilder.newTask()
|
||||||
|
.classificationSummary(defaultClassificationSummary)
|
||||||
|
.workbasketSummary(defaultWorkbasketSummary)
|
||||||
|
.primaryObjRef(DefaultTestEntities.defaultTestObjectReference().build())
|
||||||
|
.state(TaskState.COMPLETED)
|
||||||
|
.buildAndStore(taskService);
|
||||||
|
task2 =
|
||||||
|
TaskBuilder.newTask()
|
||||||
|
.classificationSummary(defaultClassificationSummary)
|
||||||
|
.workbasketSummary(defaultWorkbasketSummary)
|
||||||
|
.primaryObjRef(DefaultTestEntities.defaultTestObjectReference().build())
|
||||||
|
.state(TaskState.COMPLETED)
|
||||||
|
.buildAndStore(taskService);
|
||||||
|
}
|
||||||
|
|
||||||
|
@WithAccessId(user = "admin")
|
||||||
|
@Test
|
||||||
|
void should_DeleteAttachments_When_MultipleTasksAreDeleted() throws Exception {
|
||||||
|
task1 = createNewCompletedTask();
|
||||||
|
task2 = createNewCompletedTask();
|
||||||
|
task1.addAttachment(createNewAttachment());
|
||||||
|
task2.addAttachment(createNewAttachment());
|
||||||
|
taskService.deleteTasks(List.of(task1.getId(), task2.getId()));
|
||||||
|
|
||||||
|
TaskanaEngineProxy engineProxy = new TaskanaEngineProxy(taskanaEngine);
|
||||||
|
AttachmentMapper attachmentMapper =
|
||||||
|
engineProxy.getEngine().getSqlSession().getMapper(AttachmentMapper.class);
|
||||||
|
try {
|
||||||
|
engineProxy.openConnection();
|
||||||
|
assertThat(
|
||||||
|
attachmentMapper.findAttachmentSummariesByTaskIds(
|
||||||
|
List.of(task1.getId(), task2.getId())))
|
||||||
|
.isEmpty();
|
||||||
|
} finally {
|
||||||
|
engineProxy.returnConnection();
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
@WithAccessId(user = "admin")
|
||||||
|
@Test
|
||||||
|
void should_DeleteAttachments_When_SingleTaskIsDeleted() throws Exception {
|
||||||
|
task1 = createNewCompletedTask();
|
||||||
|
task1.addAttachment(createNewAttachment());
|
||||||
|
task1.addAttachment(createNewAttachment());
|
||||||
|
taskService.deleteTask(task1.getId());
|
||||||
|
|
||||||
|
TaskanaEngineProxy engineProxy = new TaskanaEngineProxy(taskanaEngine);
|
||||||
|
AttachmentMapper attachmentMapper =
|
||||||
|
engineProxy.getSqlSession().getMapper(AttachmentMapper.class);
|
||||||
|
try {
|
||||||
|
engineProxy.openConnection();
|
||||||
|
assertThat(attachmentMapper.findAttachmentsByTaskId(task1.getId())).isEmpty();
|
||||||
|
} finally {
|
||||||
|
engineProxy.returnConnection();
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
@WithAccessId(user = "businessadmin")
|
||||||
|
@WithAccessId(user = "taskadmin")
|
||||||
|
@WithAccessId(user = "user-1-1")
|
||||||
|
@TestTemplate
|
||||||
|
void should_ThrowException_When_UserIsNotInAdminRoleButTriesToBulkDeleteTasks() {
|
||||||
|
ThrowingCallable call = () -> taskService.deleteTasks(List.of(task1.getId(), task2.getId()));
|
||||||
|
|
||||||
|
NotAuthorizedException e = catchThrowableOfType(call, NotAuthorizedException.class);
|
||||||
|
assertThat(e.getCurrentUserId()).isEqualTo(taskanaEngine.getCurrentUserContext().getUserid());
|
||||||
|
assertThat(e.getRoles()).containsExactly(TaskanaRole.ADMIN);
|
||||||
|
}
|
||||||
|
|
||||||
|
@WithAccessId(user = "admin")
|
||||||
|
@Test
|
||||||
|
void should_DeleteSingleTask() throws Exception {
|
||||||
|
task1 = createNewCompletedTask();
|
||||||
|
taskService.deleteTask(task1.getId());
|
||||||
|
|
||||||
|
ThrowingCallable call = () -> taskService.getTask(task1.getId());
|
||||||
|
|
||||||
|
TaskNotFoundException e = catchThrowableOfType(call, TaskNotFoundException.class);
|
||||||
|
assertThat(e.getTaskId()).isEqualTo(task1.getId());
|
||||||
|
}
|
||||||
|
|
||||||
|
@WithAccessId(user = "businessadmin")
|
||||||
|
@WithAccessId(user = "taskadmin")
|
||||||
|
@WithAccessId(user = "user-1-1")
|
||||||
|
@TestTemplate
|
||||||
|
void should_ThrowException_When_UserIsNotInAdminRole() {
|
||||||
|
ThrowingCallable call = () -> taskService.deleteTask(task1.getId());
|
||||||
|
|
||||||
|
NotAuthorizedException e = catchThrowableOfType(call, NotAuthorizedException.class);
|
||||||
|
assertThat(e.getCurrentUserId()).isEqualTo(taskanaEngine.getCurrentUserContext().getUserid());
|
||||||
|
assertThat(e.getRoles()).containsExactly(TaskanaRole.ADMIN);
|
||||||
|
}
|
||||||
|
|
||||||
|
@WithAccessId(user = "admin")
|
||||||
|
@Test
|
||||||
|
void should_ThrowException_When_TaskIsNotCompleted() throws Exception {
|
||||||
|
Task taskNotComplete =
|
||||||
|
TaskBuilder.newTask()
|
||||||
|
.classificationSummary(defaultClassificationSummary)
|
||||||
|
.workbasketSummary(defaultWorkbasketSummary)
|
||||||
|
.primaryObjRef(DefaultTestEntities.defaultTestObjectReference().build())
|
||||||
|
.state(TaskState.READY)
|
||||||
|
.buildAndStore(taskService);
|
||||||
|
|
||||||
|
ThrowingCallable call = () -> taskService.deleteTask(taskNotComplete.getId());
|
||||||
|
|
||||||
|
InvalidTaskStateException e = catchThrowableOfType(call, InvalidTaskStateException.class);
|
||||||
|
assertThat(e.getTaskId()).isEqualTo(taskNotComplete.getId());
|
||||||
|
assertThat(e.getTaskState()).isEqualTo(TaskState.READY);
|
||||||
|
assertThat(e.getRequiredTaskStates())
|
||||||
|
.containsExactlyInAnyOrder(TaskState.COMPLETED, TaskState.CANCELLED, TaskState.TERMINATED);
|
||||||
|
}
|
||||||
|
|
||||||
|
@WithAccessId(user = "admin")
|
||||||
|
@Test
|
||||||
|
void should_ForceDeleteTask_When_TaskIsNotCompleted() throws Exception {
|
||||||
|
Task taskNotComplete =
|
||||||
|
TaskBuilder.newTask()
|
||||||
|
.classificationSummary(defaultClassificationSummary)
|
||||||
|
.workbasketSummary(defaultWorkbasketSummary)
|
||||||
|
.primaryObjRef(DefaultTestEntities.defaultTestObjectReference().build())
|
||||||
|
.state(TaskState.READY)
|
||||||
|
.buildAndStore(taskService);
|
||||||
|
|
||||||
|
taskService.forceDeleteTask(taskNotComplete.getId());
|
||||||
|
ThrowingCallable call = () -> taskService.getTask(taskNotComplete.getId());
|
||||||
|
|
||||||
|
TaskNotFoundException e = catchThrowableOfType(call, TaskNotFoundException.class);
|
||||||
|
assertThat(e.getTaskId()).isEqualTo(taskNotComplete.getId());
|
||||||
|
}
|
||||||
|
|
||||||
|
@WithAccessId(user = "admin")
|
||||||
|
@Test
|
||||||
|
void should_BulkDeleteTask() throws Exception {
|
||||||
|
task1 = createNewCompletedTask();
|
||||||
|
task2 = createNewCompletedTask();
|
||||||
|
BulkOperationResults<String, TaskanaException> results =
|
||||||
|
taskService.deleteTasks(List.of(task1.getId(), task2.getId()));
|
||||||
|
|
||||||
|
assertThat(results.containsErrors()).isFalse();
|
||||||
|
|
||||||
|
ThrowingCallable call = () -> taskService.getTask(task1.getId());
|
||||||
|
TaskNotFoundException e = catchThrowableOfType(call, TaskNotFoundException.class);
|
||||||
|
assertThat(e.getTaskId()).isEqualTo(task1.getId());
|
||||||
|
|
||||||
|
ThrowingCallable call2 = () -> taskService.getTask(task2.getId());
|
||||||
|
TaskNotFoundException e2 = catchThrowableOfType(call2, TaskNotFoundException.class);
|
||||||
|
assertThat(e2.getTaskId()).isEqualTo(task2.getId());
|
||||||
|
}
|
||||||
|
|
||||||
|
@WithAccessId(user = "admin")
|
||||||
|
@Test
|
||||||
|
void should_BulkDeleteTasksWithException() throws Exception {
|
||||||
|
task1 = createNewCompletedTask();
|
||||||
|
task2 = createNewCompletedTask();
|
||||||
|
Task taskNotComplete =
|
||||||
|
TaskBuilder.newTask()
|
||||||
|
.classificationSummary(defaultClassificationSummary)
|
||||||
|
.workbasketSummary(defaultWorkbasketSummary)
|
||||||
|
.primaryObjRef(DefaultTestEntities.defaultTestObjectReference().build())
|
||||||
|
.state(TaskState.READY)
|
||||||
|
.buildAndStore(taskService);
|
||||||
|
BulkOperationResults<String, TaskanaException> results =
|
||||||
|
taskService.deleteTasks(
|
||||||
|
List.of(task1.getId(), task2.getId(), taskNotComplete.getId(), "INVALID_TASK_ID"));
|
||||||
|
|
||||||
|
assertThat(results.containsErrors()).isTrue();
|
||||||
|
assertThat(results.getErrorMap().keySet())
|
||||||
|
.containsExactlyInAnyOrder(taskNotComplete.getId(), "INVALID_TASK_ID");
|
||||||
|
assertThat(results.getErrorMap().get(taskNotComplete.getId()))
|
||||||
|
.isInstanceOf(InvalidTaskStateException.class);
|
||||||
|
assertThat(results.getErrorMap().get("INVALID_TASK_ID"))
|
||||||
|
.isInstanceOf(TaskNotFoundException.class);
|
||||||
|
|
||||||
|
Task notDeletedTask = taskService.getTask(taskNotComplete.getId());
|
||||||
|
assertThat(notDeletedTask).isNotNull();
|
||||||
|
ThrowingCallable call = () -> taskService.getTask(task1.getId());
|
||||||
|
TaskNotFoundException e = catchThrowableOfType(call, TaskNotFoundException.class);
|
||||||
|
assertThat(e.getTaskId()).isEqualTo(task1.getId());
|
||||||
|
ThrowingCallable call2 = () -> taskService.getTask(task2.getId());
|
||||||
|
TaskNotFoundException e2 = catchThrowableOfType(call2, TaskNotFoundException.class);
|
||||||
|
assertThat(e2.getTaskId()).isEqualTo(task2.getId());
|
||||||
|
}
|
||||||
|
|
||||||
|
private Task createNewCompletedTask() throws Exception {
|
||||||
|
return TaskBuilder.newTask()
|
||||||
|
.classificationSummary(defaultClassificationSummary)
|
||||||
|
.workbasketSummary(defaultWorkbasketSummary)
|
||||||
|
.primaryObjRef(DefaultTestEntities.defaultTestObjectReference().build())
|
||||||
|
.state(TaskState.COMPLETED)
|
||||||
|
.buildAndStore(taskService, "admin");
|
||||||
|
}
|
||||||
|
|
||||||
|
private Attachment createNewAttachment() throws Exception {
|
||||||
|
return TaskAttachmentBuilder.newAttachment()
|
||||||
|
.classificationSummary(defaultClassificationSummary)
|
||||||
|
.objectReference(defaultObjectReference)
|
||||||
|
.build();
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
@ -1,211 +0,0 @@
|
||||||
package acceptance.task.delete;
|
|
||||||
|
|
||||||
import static org.assertj.core.api.Assertions.assertThat;
|
|
||||||
import static org.assertj.core.api.Assertions.assertThatThrownBy;
|
|
||||||
|
|
||||||
import acceptance.AbstractAccTest;
|
|
||||||
import acceptance.TaskanaEngineProxy;
|
|
||||||
import java.util.List;
|
|
||||||
import org.assertj.core.api.ThrowableAssert.ThrowingCallable;
|
|
||||||
import org.junit.jupiter.api.Test;
|
|
||||||
import org.junit.jupiter.api.TestTemplate;
|
|
||||||
import org.junit.jupiter.api.extension.ExtendWith;
|
|
||||||
import pro.taskana.common.api.BulkOperationResults;
|
|
||||||
import pro.taskana.common.api.exceptions.NotAuthorizedException;
|
|
||||||
import pro.taskana.common.api.exceptions.TaskanaException;
|
|
||||||
import pro.taskana.common.test.security.JaasExtension;
|
|
||||||
import pro.taskana.common.test.security.WithAccessId;
|
|
||||||
import pro.taskana.task.api.exceptions.InvalidTaskStateException;
|
|
||||||
import pro.taskana.task.api.exceptions.TaskNotFoundException;
|
|
||||||
import pro.taskana.task.api.models.Task;
|
|
||||||
import pro.taskana.task.internal.AttachmentMapper;
|
|
||||||
|
|
||||||
/** Acceptance test for all "delete task" scenarios. */
|
|
||||||
@ExtendWith(JaasExtension.class)
|
|
||||||
class DeleteTaskAccTest extends AbstractAccTest {
|
|
||||||
|
|
||||||
@WithAccessId(user = "user-1-2")
|
|
||||||
@Test
|
|
||||||
void testDeleteSingleTaskNotAuthorized() {
|
|
||||||
ThrowingCallable call =
|
|
||||||
() -> taskService.deleteTask("TKI:000000000000000000000000000000000037");
|
|
||||||
|
|
||||||
assertThatThrownBy(call).isInstanceOf(NotAuthorizedException.class);
|
|
||||||
}
|
|
||||||
|
|
||||||
@WithAccessId(user = "user-taskrouter")
|
|
||||||
@Test
|
|
||||||
void should_ThrowNotAuthorizedException_When_UserIsMemberOfTaskRouterRole() {
|
|
||||||
ThrowingCallable call =
|
|
||||||
() -> taskService.deleteTask("TKI:000000000000000000000000000000000037");
|
|
||||||
assertThatThrownBy(call).isInstanceOf(NotAuthorizedException.class);
|
|
||||||
}
|
|
||||||
|
|
||||||
@WithAccessId(user = "admin")
|
|
||||||
@Test
|
|
||||||
void should_DeleteAttachments_When_MultipleTasksAreDeleted() throws Exception {
|
|
||||||
TaskanaEngineProxy engineProxy = new TaskanaEngineProxy(taskanaEngine);
|
|
||||||
AttachmentMapper attachmentMapper =
|
|
||||||
engineProxy.getEngine().getSqlSession().getMapper(AttachmentMapper.class);
|
|
||||||
|
|
||||||
try {
|
|
||||||
engineProxy.openConnection();
|
|
||||||
assertThat(
|
|
||||||
attachmentMapper.findAttachmentSummariesByTaskIds(
|
|
||||||
List.of(
|
|
||||||
"TKI:000000000000000000000000000000000067",
|
|
||||||
"TKI:000000000000000000000000000000000068")))
|
|
||||||
.hasSize(4);
|
|
||||||
} finally {
|
|
||||||
engineProxy.returnConnection();
|
|
||||||
}
|
|
||||||
|
|
||||||
taskService.deleteTasks(
|
|
||||||
List.of(
|
|
||||||
"TKI:000000000000000000000000000000000067",
|
|
||||||
"TKI:000000000000000000000000000000000068"));
|
|
||||||
try {
|
|
||||||
engineProxy.openConnection();
|
|
||||||
assertThat(
|
|
||||||
attachmentMapper.findAttachmentSummariesByTaskIds(
|
|
||||||
List.of(
|
|
||||||
"TKI:000000000000000000000000000000000067",
|
|
||||||
"TKI:000000000000000000000000000000000068")))
|
|
||||||
.isEmpty();
|
|
||||||
} finally {
|
|
||||||
engineProxy.returnConnection();
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
@WithAccessId(user = "admin")
|
|
||||||
@Test
|
|
||||||
void should_DeleteAttachments_When_SingleTaskIsDeleted() throws Exception {
|
|
||||||
TaskanaEngineProxy engineProxy = new TaskanaEngineProxy(taskanaEngine);
|
|
||||||
AttachmentMapper attachmentMapper =
|
|
||||||
engineProxy.getSqlSession().getMapper(AttachmentMapper.class);
|
|
||||||
|
|
||||||
try {
|
|
||||||
engineProxy.openConnection();
|
|
||||||
assertThat(
|
|
||||||
attachmentMapper.findAttachmentsByTaskId("TKI:000000000000000000000000000000000069"))
|
|
||||||
.hasSize(1);
|
|
||||||
|
|
||||||
} finally {
|
|
||||||
engineProxy.returnConnection();
|
|
||||||
}
|
|
||||||
|
|
||||||
taskService.deleteTask("TKI:000000000000000000000000000000000069");
|
|
||||||
|
|
||||||
try {
|
|
||||||
engineProxy.openConnection();
|
|
||||||
assertThat(
|
|
||||||
attachmentMapper.findAttachmentsByTaskId("TKI:000000000000000000000000000000000069"))
|
|
||||||
.isEmpty();
|
|
||||||
} finally {
|
|
||||||
engineProxy.returnConnection();
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
@WithAccessId(user = "businessadmin")
|
|
||||||
@WithAccessId(user = "taskadmin")
|
|
||||||
@WithAccessId(user = "user-1-1")
|
|
||||||
@TestTemplate
|
|
||||||
void should_ThrowException_When_UserIsNotInAdminRoleButTriesToBulkDeleteTasks() {
|
|
||||||
List<String> taskIds =
|
|
||||||
List.of(
|
|
||||||
"TKI:000000000000000000000000000000000008",
|
|
||||||
"TKI:000000000000000000000000000000000009",
|
|
||||||
"TKI:000000000000000000000000000000000008",
|
|
||||||
"TKI:000000000000000000000000000000000010");
|
|
||||||
|
|
||||||
ThrowingCallable call = () -> taskService.deleteTasks(taskIds);
|
|
||||||
assertThatThrownBy(call).isInstanceOf(NotAuthorizedException.class);
|
|
||||||
}
|
|
||||||
|
|
||||||
@WithAccessId(user = "admin")
|
|
||||||
@Test
|
|
||||||
void testDeleteSingleTask() throws Exception {
|
|
||||||
Task task = taskService.getTask("TKI:000000000000000000000000000000000036");
|
|
||||||
|
|
||||||
taskService.deleteTask(task.getId());
|
|
||||||
|
|
||||||
ThrowingCallable call = () -> taskService.getTask("TKI:000000000000000000000000000000000036");
|
|
||||||
assertThatThrownBy(call).isInstanceOf(TaskNotFoundException.class);
|
|
||||||
}
|
|
||||||
|
|
||||||
@WithAccessId(user = "businessadmin")
|
|
||||||
@WithAccessId(user = "taskadmin")
|
|
||||||
@WithAccessId(user = "user-1-1")
|
|
||||||
@TestTemplate
|
|
||||||
void should_ThrowException_When_UserIsNotInAdminRole() {
|
|
||||||
ThrowingCallable deleteTaskCall =
|
|
||||||
() -> taskService.deleteTask("TKI:000000000000000000000000000000000041");
|
|
||||||
assertThatThrownBy(deleteTaskCall).isInstanceOf(NotAuthorizedException.class);
|
|
||||||
}
|
|
||||||
|
|
||||||
@WithAccessId(user = "admin")
|
|
||||||
@Test
|
|
||||||
void testThrowsExceptionIfTaskIsNotCompleted() throws Exception {
|
|
||||||
Task task = taskService.getTask("TKI:000000000000000000000000000000000029");
|
|
||||||
|
|
||||||
ThrowingCallable call = () -> taskService.deleteTask(task.getId());
|
|
||||||
assertThatThrownBy(call).isInstanceOf(InvalidTaskStateException.class);
|
|
||||||
}
|
|
||||||
|
|
||||||
@WithAccessId(user = "admin")
|
|
||||||
@Test
|
|
||||||
void testForceDeleteTaskIfNotCompleted() throws Exception {
|
|
||||||
Task task = taskService.getTask("TKI:000000000000000000000000000000000027");
|
|
||||||
|
|
||||||
ThrowingCallable call = () -> taskService.deleteTask(task.getId());
|
|
||||||
assertThatThrownBy(call)
|
|
||||||
.describedAs("Should not be possible to delete claimed task without force flag")
|
|
||||||
.isInstanceOf(InvalidTaskStateException.class);
|
|
||||||
|
|
||||||
taskService.forceDeleteTask(task.getId());
|
|
||||||
|
|
||||||
call = () -> taskService.getTask("TKI:000000000000000000000000000000000027");
|
|
||||||
assertThatThrownBy(call).isInstanceOf(TaskNotFoundException.class);
|
|
||||||
}
|
|
||||||
|
|
||||||
@WithAccessId(user = "admin")
|
|
||||||
@Test
|
|
||||||
void testBulkDeleteTask() throws Exception {
|
|
||||||
List<String> taskIdList =
|
|
||||||
List.of(
|
|
||||||
"TKI:000000000000000000000000000000000037", "TKI:000000000000000000000000000000000038");
|
|
||||||
|
|
||||||
BulkOperationResults<String, TaskanaException> results = taskService.deleteTasks(taskIdList);
|
|
||||||
|
|
||||||
assertThat(results.containsErrors()).isFalse();
|
|
||||||
ThrowingCallable call = () -> taskService.getTask("TKI:000000000000000000000000000000000038");
|
|
||||||
assertThatThrownBy(call).isInstanceOf(TaskNotFoundException.class);
|
|
||||||
}
|
|
||||||
|
|
||||||
@WithAccessId(user = "admin")
|
|
||||||
@Test
|
|
||||||
void testBulkDeleteTasksWithException() throws Exception {
|
|
||||||
List<String> taskIdList =
|
|
||||||
List.of(
|
|
||||||
"TKI:000000000000000000000000000000000039",
|
|
||||||
"TKI:000000000000000000000000000000000040",
|
|
||||||
"TKI:000000000000000000000000000000000028",
|
|
||||||
"INVALID_TASK_ID");
|
|
||||||
|
|
||||||
BulkOperationResults<String, TaskanaException> results = taskService.deleteTasks(taskIdList);
|
|
||||||
|
|
||||||
assertThat(results.containsErrors()).isTrue();
|
|
||||||
|
|
||||||
assertThat(results.getErrorMap().keySet())
|
|
||||||
.containsExactlyInAnyOrder("TKI:000000000000000000000000000000000028", "INVALID_TASK_ID");
|
|
||||||
assertThat(results.getErrorMap().get("TKI:000000000000000000000000000000000028"))
|
|
||||||
.isInstanceOf(InvalidTaskStateException.class);
|
|
||||||
assertThat(results.getErrorMap().get("INVALID_TASK_ID"))
|
|
||||||
.isInstanceOf(TaskNotFoundException.class);
|
|
||||||
|
|
||||||
Task notDeletedTask = taskService.getTask("TKI:000000000000000000000000000000000028");
|
|
||||||
assertThat(notDeletedTask).isNotNull();
|
|
||||||
ThrowingCallable call = () -> taskService.getTask("TKI:000000000000000000000000000000000040");
|
|
||||||
assertThatThrownBy(call).isInstanceOf(TaskNotFoundException.class);
|
|
||||||
}
|
|
||||||
}
|
|
||||||
Loading…
Reference in New Issue