nosu
/
taskana
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

TSK-615 

- Added key and domain for those  exception messages which has access to key and domain values in classification and workbasket services.
This commit is contained in:
Martin Rojas Miguel Angel 2018-07-10 09:38:59 +02:00 committed by Holger Hagen
parent 1cd9b47c4e
commit 87140d05ea
2 changed files with 8 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
lib/taskana-core/src/main/java/pro/taskana/impl/ClassificationServiceImpl.java
View File

@ -172,7 +172,7 @@ public class ClassificationServiceImpl implements ClassificationService {
classificationImpl.getDomain());
if (!oldClassification.getModified().equals(classificationImpl.getModified())) {
throw new ConcurrencyException(
"The current Classification has been modified while editing. The values can not be updated. Classification="
"The current Classification has been modified while editing. The values can not be updated. Classification "
+ classificationImpl.toString());
}
classificationImpl.setModified(Instant.now());
@ -337,7 +337,7 @@ public class ClassificationServiceImpl implements ClassificationService {
result = classificationMapper.findByKeyAndDomain(key, "");
if (result == null) {
throw new ClassificationNotFoundException(key, domain,
"Classification for key " + key + " was not found");
"Classification for key = " + key + " and master domain was not found");
}
}
return result;
@ -429,8 +429,10 @@ public class ClassificationServiceImpl implements ClassificationService {
this.classificationMapper.deleteClassification(classificationId);
} catch (PersistenceException e) {
if (isReferentialIntegrityConstraintViolation(e)) {
throw new ClassificationInUseException("The classification " + classificationId
+ " is in use and cannot be deleted. There are either tasks or attachments associated with the classification.",
throw new ClassificationInUseException(
"The classification id = \"" + classificationId + "\" and key = \"" + classification.getKey()
+ "\" in domain = \"" + classification.getDomain()
+ "\" is in use and cannot be deleted. There are either tasks or attachments associated with the classification.",
e.getCause());
}
}

3
lib/taskana-core/src/main/java/pro/taskana/impl/WorkbasketServiceImpl.java
View File

@ -740,7 +740,8 @@ public class WorkbasketServiceImpl implements WorkbasketService {
if (numTasksInWorkbasket > 0) {
throw new WorkbasketInUseException(
"Workbasket is used on tasks and can´t be deleted. WorkbasketId=" + workbasketId);
"Workbasket is used on tasks and can´t be deleted. WorkbasketId = \"" + workbasketId
+ "\" and WorkbasketKey = \"" + wb.getKey() + "\" in domain = \"" + wb.getDomain() + "\"");
}
// delete workbasket and sub-tables