From 8832876b9372c135c2c2fce88bc4820a1cab37d7 Mon Sep 17 00:00:00 2001 From: Tristan Eisermann <19949441+Tristan2357@users.noreply.github.com> Date: Wed, 3 Jun 2020 11:48:19 +0200 Subject: [PATCH] TSK-1247: Removed LoggerUtils and replaced its usages with the standard toString implementations --- .../rest/TaskHistoryEventController.java | 5 +- .../taskana/TaskanaEngineConfiguration.java | 3 +- .../internal/ClassificationQueryImpl.java | 7 +- .../common/api/BulkOperationResults.java | 2 +- .../pro/taskana/common/api/LoggerUtils.java | 79 ------------------- .../common/internal/TaskanaEngineImpl.java | 4 +- .../internal/security/GroupPrincipal.java | 4 +- .../monitor/api/reports/row/FoldableRow.java | 3 +- .../WorkingDaysToDaysReportConverter.java | 3 +- .../TimeIntervalReportBuilderImpl.java | 3 +- .../internal/ObjectReferenceQueryImpl.java | 7 +- .../task/internal/ServiceLevelHandler.java | 5 +- .../taskana/task/internal/TaskQueryImpl.java | 9 +-- .../task/internal/TaskServiceImpl.java | 44 +++++------ .../task/internal/TaskTransferrer.java | 25 +++--- .../task/internal/jobs/TaskCleanupJob.java | 5 +- .../task/internal/jobs/TaskRefreshJob.java | 3 +- ...AbstractWorkbasketAccessItemQueryImpl.java | 7 +- .../WorkbasketAccessItemQueryImpl.java | 7 +- .../internal/WorkbasketQueryImpl.java | 7 +- .../internal/WorkbasketServiceImpl.java | 15 ++-- .../test/java/pro/taskana/ldap/LdapTest.java | 3 +- .../ClassificationDefinitionController.java | 3 +- .../taskana/common/rest/ldap/LdapClient.java | 9 +-- .../TaskanaUserInfoRepresentationModel.java | 5 +- .../workbasket/rest/WorkbasketController.java | 3 +- 26 files changed, 82 insertions(+), 188 deletions(-) delete mode 100644 lib/taskana-core/src/main/java/pro/taskana/common/api/LoggerUtils.java diff --git a/history/taskana-simplehistory-rest-spring/src/main/java/pro/taskana/simplehistory/rest/TaskHistoryEventController.java b/history/taskana-simplehistory-rest-spring/src/main/java/pro/taskana/simplehistory/rest/TaskHistoryEventController.java index b296904f4..705408cde 100644 --- a/history/taskana-simplehistory-rest-spring/src/main/java/pro/taskana/simplehistory/rest/TaskHistoryEventController.java +++ b/history/taskana-simplehistory-rest-spring/src/main/java/pro/taskana/simplehistory/rest/TaskHistoryEventController.java @@ -20,7 +20,6 @@ import org.springframework.web.bind.annotation.RestController; import pro.taskana.TaskanaEngineConfiguration; import pro.taskana.common.api.BaseQuery; -import pro.taskana.common.api.LoggerUtils; import pro.taskana.common.api.TimeInterval; import pro.taskana.common.api.exceptions.InvalidArgumentException; import pro.taskana.common.rest.AbstractPagingController; @@ -149,7 +148,7 @@ public class TaskHistoryEventController extends AbstractPagingController { public ResponseEntity getTaskHistoryEvents( @RequestParam MultiValueMap params) throws InvalidArgumentException { if (LOGGER.isDebugEnabled()) { - LOGGER.debug("Entry to getTaskHistoryEvents(params= {})", LoggerUtils.mapToString(params)); + LOGGER.debug("Entry to getTaskHistoryEvents(params= {})", params); } HistoryQuery query = simpleHistoryService.createHistoryQuery(); @@ -212,7 +211,7 @@ public class TaskHistoryEventController extends AbstractPagingController { private HistoryQuery applySortingParams(HistoryQuery query, MultiValueMap params) throws InvalidArgumentException { if (LOGGER.isDebugEnabled()) { - LOGGER.debug("Entry to applySortingParams(params= {})", LoggerUtils.mapToString(params)); + LOGGER.debug("Entry to applySortingParams(params= {})", params); } String sortBy = params.getFirst(SORT_BY); diff --git a/lib/taskana-core/src/main/java/pro/taskana/TaskanaEngineConfiguration.java b/lib/taskana-core/src/main/java/pro/taskana/TaskanaEngineConfiguration.java index 2c976c25d..c932f28fb 100644 --- a/lib/taskana-core/src/main/java/pro/taskana/TaskanaEngineConfiguration.java +++ b/lib/taskana-core/src/main/java/pro/taskana/TaskanaEngineConfiguration.java @@ -29,7 +29,6 @@ import org.slf4j.Logger; import org.slf4j.LoggerFactory; import pro.taskana.common.api.CustomHoliday; -import pro.taskana.common.api.LoggerUtils; import pro.taskana.common.api.TaskanaEngine; import pro.taskana.common.api.TaskanaRole; import pro.taskana.common.api.exceptions.SystemException; @@ -558,7 +557,7 @@ public class TaskanaEngineConfiguration { if (LOGGER.isDebugEnabled()) { roleMap.forEach( (k, v) -> - LOGGER.debug("Found Taskana RoleConfig {} : {} ", k, LoggerUtils.setToString(v))); + LOGGER.debug("Found Taskana RoleConfig {} : {} ", k, v)); } } diff --git a/lib/taskana-core/src/main/java/pro/taskana/classification/internal/ClassificationQueryImpl.java b/lib/taskana-core/src/main/java/pro/taskana/classification/internal/ClassificationQueryImpl.java index 1ce2c80d9..5bf1aae3b 100644 --- a/lib/taskana-core/src/main/java/pro/taskana/classification/internal/ClassificationQueryImpl.java +++ b/lib/taskana-core/src/main/java/pro/taskana/classification/internal/ClassificationQueryImpl.java @@ -11,7 +11,6 @@ import org.slf4j.LoggerFactory; import pro.taskana.classification.api.ClassificationQuery; import pro.taskana.classification.api.ClassificationQueryColumnName; import pro.taskana.classification.api.models.ClassificationSummary; -import pro.taskana.common.api.LoggerUtils; import pro.taskana.common.api.TimeInterval; import pro.taskana.common.api.exceptions.InvalidArgumentException; import pro.taskana.common.api.exceptions.TaskanaRuntimeException; @@ -399,7 +398,7 @@ public class ClassificationQueryImpl implements ClassificationQuery { LOGGER.debug( "exit from list(). Returning {} resulting Objects: {} ", result.size(), - LoggerUtils.listToString(result)); + result); } } } @@ -430,7 +429,7 @@ public class ClassificationQueryImpl implements ClassificationQuery { LOGGER.debug( "exit from list(offset,limit). Returning {} resulting Objects: {} ", result.size(), - LoggerUtils.listToString(result)); + result); } } } @@ -453,7 +452,7 @@ public class ClassificationQueryImpl implements ClassificationQuery { LOGGER.debug( "Exit from listValues. Returning {} resulting Objects: {} ", result.size(), - LoggerUtils.listToString(result)); + result); } } } diff --git a/lib/taskana-core/src/main/java/pro/taskana/common/api/BulkOperationResults.java b/lib/taskana-core/src/main/java/pro/taskana/common/api/BulkOperationResults.java index ed66d865d..0fed5a940 100644 --- a/lib/taskana-core/src/main/java/pro/taskana/common/api/BulkOperationResults.java +++ b/lib/taskana-core/src/main/java/pro/taskana/common/api/BulkOperationResults.java @@ -128,7 +128,7 @@ public class BulkOperationResults { @Override public String toString() { return "BulkOperationResults [BulkOperationResults= " - + LoggerUtils.mapToString(this.errorMap) + + this.errorMap + "]"; } } diff --git a/lib/taskana-core/src/main/java/pro/taskana/common/api/LoggerUtils.java b/lib/taskana-core/src/main/java/pro/taskana/common/api/LoggerUtils.java deleted file mode 100644 index 89915c2d8..000000000 --- a/lib/taskana-core/src/main/java/pro/taskana/common/api/LoggerUtils.java +++ /dev/null @@ -1,79 +0,0 @@ -package pro.taskana.common.api; - -import java.util.List; -import java.util.Map; -import java.util.Map.Entry; -import java.util.Set; - -/** - * Utility methods for logging. - * - * @author bbr - */ -public final class LoggerUtils { - - private LoggerUtils() {} - - /** - * Creating an appended log-string of a list with generic type T. The logging does append - * informations using toString() on the entries. - * - * @param list the input list to be stringified - * @param the type of the objects in the input list - * @return A String representation of the list. - */ - public static String listToString(List list) { - if (list == null || list.isEmpty()) { - return "[]"; - } else { - StringBuilder builder = new StringBuilder(); - builder.append("["); - for (T t : list) { - builder.append(String.valueOf(t)); - builder.append(";\n"); - } - builder.append("]"); - return builder.toString(); - } - } - - /** - * Creating an appended log-string of a map with generic types K/V. The logging does append - * informations using toString() on the entries. - * - * @param map the map to be stringified - * @param the type of the keys in the map - * @param the type of the values in the map - * @return A String representation of the map. - */ - public static String mapToString(Map map) { - if (map == null || map.isEmpty()) { - return "[]"; - } else { - StringBuilder builder = new StringBuilder(); - builder.append("["); - Set> entrySet = map.entrySet(); - for (Entry entry : entrySet) { - builder.append("("); - builder.append(entry.getKey()); - builder.append(" , "); - builder.append(entry.getValue()); - builder.append(")"); - builder.append(" , "); - } - builder.append("]"); - return builder.toString(); - } - } - - public static String setToString(Set set) { - if (set == null || set.isEmpty()) { - return "[]"; - } - - StringBuilder result = new StringBuilder("["); - set.forEach(e -> result.append("(").append(e).append(") ,")); - result.append("]"); - return result.toString(); - } -} diff --git a/lib/taskana-core/src/main/java/pro/taskana/common/internal/TaskanaEngineImpl.java b/lib/taskana-core/src/main/java/pro/taskana/common/internal/TaskanaEngineImpl.java index 052cf1ea4..9c4a9d0ae 100644 --- a/lib/taskana-core/src/main/java/pro/taskana/common/internal/TaskanaEngineImpl.java +++ b/lib/taskana-core/src/main/java/pro/taskana/common/internal/TaskanaEngineImpl.java @@ -33,7 +33,6 @@ import pro.taskana.classification.internal.ClassificationMapper; import pro.taskana.classification.internal.ClassificationQueryMapper; import pro.taskana.classification.internal.ClassificationServiceImpl; import pro.taskana.common.api.JobService; -import pro.taskana.common.api.LoggerUtils; import pro.taskana.common.api.TaskanaEngine; import pro.taskana.common.api.TaskanaRole; import pro.taskana.common.api.exceptions.AutocommitFailedException; @@ -209,11 +208,10 @@ public class TaskanaEngineImpl implements TaskanaEngine { public void checkRoleMembership(TaskanaRole... roles) throws NotAuthorizedException { if (!isUserInRole(roles)) { if (LOGGER.isDebugEnabled()) { - String accessIds = LoggerUtils.listToString(CurrentUserContext.getAccessIds()); String rolesAsString = Arrays.toString(roles); LOGGER.debug( "Throwing NotAuthorizedException because accessIds {} are not member of roles {}", - accessIds, + CurrentUserContext.getAccessIds(), rolesAsString); } throw new NotAuthorizedException( diff --git a/lib/taskana-core/src/main/java/pro/taskana/common/internal/security/GroupPrincipal.java b/lib/taskana-core/src/main/java/pro/taskana/common/internal/security/GroupPrincipal.java index e7ed11b63..32551af76 100644 --- a/lib/taskana-core/src/main/java/pro/taskana/common/internal/security/GroupPrincipal.java +++ b/lib/taskana-core/src/main/java/pro/taskana/common/internal/security/GroupPrincipal.java @@ -7,8 +7,6 @@ import java.util.Enumeration; import java.util.HashSet; import java.util.Set; -import pro.taskana.common.api.LoggerUtils; - /** Represents a group with a name and a set of members. */ public class GroupPrincipal implements Group { @@ -50,7 +48,7 @@ public class GroupPrincipal implements Group { return "GroupPrincipal [name=" + name + ", members=" - + LoggerUtils.setToString(this.members) + + this.members + "]"; } } diff --git a/lib/taskana-core/src/main/java/pro/taskana/monitor/api/reports/row/FoldableRow.java b/lib/taskana-core/src/main/java/pro/taskana/monitor/api/reports/row/FoldableRow.java index ef3e6d58b..7ec47077a 100644 --- a/lib/taskana-core/src/main/java/pro/taskana/monitor/api/reports/row/FoldableRow.java +++ b/lib/taskana-core/src/main/java/pro/taskana/monitor/api/reports/row/FoldableRow.java @@ -5,7 +5,6 @@ import java.util.Map; import java.util.Set; import java.util.function.Function; -import pro.taskana.common.api.LoggerUtils; import pro.taskana.monitor.api.reports.Report; import pro.taskana.monitor.api.reports.item.QueryItem; @@ -62,6 +61,6 @@ public abstract class FoldableRow extends SingleRow { public String toString() { return String.format( "FoldableRow [detailRows= %s, columnSize= %d]", - LoggerUtils.mapToString(this.foldableRows), columnSize); + this.foldableRows, columnSize); } } diff --git a/lib/taskana-core/src/main/java/pro/taskana/monitor/internal/preprocessor/WorkingDaysToDaysReportConverter.java b/lib/taskana-core/src/main/java/pro/taskana/monitor/internal/preprocessor/WorkingDaysToDaysReportConverter.java index 20a6543c2..3511aae2d 100644 --- a/lib/taskana-core/src/main/java/pro/taskana/monitor/internal/preprocessor/WorkingDaysToDaysReportConverter.java +++ b/lib/taskana-core/src/main/java/pro/taskana/monitor/internal/preprocessor/WorkingDaysToDaysReportConverter.java @@ -10,7 +10,6 @@ import java.util.stream.Collectors; import org.slf4j.Logger; import org.slf4j.LoggerFactory; -import pro.taskana.common.api.LoggerUtils; import pro.taskana.common.api.exceptions.InvalidArgumentException; import pro.taskana.common.internal.util.WorkingDaysToDaysConverter; import pro.taskana.monitor.api.reports.header.TimeIntervalColumnHeader; @@ -60,7 +59,7 @@ public class WorkingDaysToDaysReportConverter { if (LOGGER.isDebugEnabled()) { LOGGER.debug( "Initialize WorkingDaysToDaysConverter with columnHeaders: {}", - LoggerUtils.listToString(columnHeaders)); + columnHeaders); } if (columnHeaders == null) { throw new InvalidArgumentException( diff --git a/lib/taskana-core/src/main/java/pro/taskana/monitor/internal/reports/TimeIntervalReportBuilderImpl.java b/lib/taskana-core/src/main/java/pro/taskana/monitor/internal/reports/TimeIntervalReportBuilderImpl.java index 66c6ebd53..fb4908967 100644 --- a/lib/taskana-core/src/main/java/pro/taskana/monitor/internal/reports/TimeIntervalReportBuilderImpl.java +++ b/lib/taskana-core/src/main/java/pro/taskana/monitor/internal/reports/TimeIntervalReportBuilderImpl.java @@ -9,7 +9,6 @@ import org.slf4j.Logger; import org.slf4j.LoggerFactory; import pro.taskana.TaskanaEngineConfiguration; -import pro.taskana.common.api.LoggerUtils; import pro.taskana.common.api.TaskanaRole; import pro.taskana.common.api.exceptions.InvalidArgumentException; import pro.taskana.common.api.exceptions.NotAuthorizedException; @@ -119,7 +118,7 @@ abstract class TimeIntervalReportBuilderImpl< if (LOGGER.isDebugEnabled()) { LOGGER.debug( "entry to listTaskIdsForSelectedItems(selectedItems = {}), this = {}", - LoggerUtils.listToString(selectedItems), + selectedItems, this); } diff --git a/lib/taskana-core/src/main/java/pro/taskana/task/internal/ObjectReferenceQueryImpl.java b/lib/taskana-core/src/main/java/pro/taskana/task/internal/ObjectReferenceQueryImpl.java index 053663434..cacbefecc 100644 --- a/lib/taskana-core/src/main/java/pro/taskana/task/internal/ObjectReferenceQueryImpl.java +++ b/lib/taskana-core/src/main/java/pro/taskana/task/internal/ObjectReferenceQueryImpl.java @@ -8,7 +8,6 @@ import org.apache.ibatis.session.RowBounds; import org.slf4j.Logger; import org.slf4j.LoggerFactory; -import pro.taskana.common.api.LoggerUtils; import pro.taskana.common.api.exceptions.TaskanaRuntimeException; import pro.taskana.common.internal.InternalTaskanaEngine; import pro.taskana.task.api.ObjectReferenceQuery; @@ -87,7 +86,7 @@ public class ObjectReferenceQueryImpl implements ObjectReferenceQuery { LOGGER.debug( "exit from list(). Returning {} resulting Objects: {} ", result.size(), - LoggerUtils.listToString(result)); + result); } } } @@ -118,7 +117,7 @@ public class ObjectReferenceQueryImpl implements ObjectReferenceQuery { LOGGER.debug( "exit from list(offset,limit). Returning {} resulting Objects: {} ", result.size(), - LoggerUtils.listToString(result)); + result); } } } @@ -141,7 +140,7 @@ public class ObjectReferenceQueryImpl implements ObjectReferenceQuery { LOGGER.debug( "Exit from listValues. Returning {} resulting Objects: {} ", result.size(), - LoggerUtils.listToString(result)); + result); } } } diff --git a/lib/taskana-core/src/main/java/pro/taskana/task/internal/ServiceLevelHandler.java b/lib/taskana-core/src/main/java/pro/taskana/task/internal/ServiceLevelHandler.java index d155d192c..7c5a95aab 100644 --- a/lib/taskana-core/src/main/java/pro/taskana/task/internal/ServiceLevelHandler.java +++ b/lib/taskana-core/src/main/java/pro/taskana/task/internal/ServiceLevelHandler.java @@ -17,7 +17,6 @@ import org.slf4j.LoggerFactory; import pro.taskana.classification.api.models.ClassificationSummary; import pro.taskana.common.api.BulkOperationResults; -import pro.taskana.common.api.LoggerUtils; import pro.taskana.common.api.exceptions.InvalidArgumentException; import pro.taskana.common.api.exceptions.TaskanaException; import pro.taskana.common.internal.InternalTaskanaEngine; @@ -87,14 +86,14 @@ class ServiceLevelHandler { BulkLog bulkLog = new BulkLog(); List attachments = getAttachmentSummaries(tasks); if (LOGGER.isDebugEnabled()) { - LOGGER.debug("found attachments {}.", LoggerUtils.listToString(attachments)); + LOGGER.debug("found attachments {}.", attachments); } List allInvolvedClassifications = findAllClassificationsReferencedByTasksAndAttachments(tasks, attachments); if (LOGGER.isDebugEnabled()) { LOGGER.debug( "found involved classifications {}.", - LoggerUtils.listToString(allInvolvedClassifications)); + allInvolvedClassifications); } List allInvolvedClassificationsWithDuration = resolveDurationsInClassifications(allInvolvedClassifications); diff --git a/lib/taskana-core/src/main/java/pro/taskana/task/internal/TaskQueryImpl.java b/lib/taskana-core/src/main/java/pro/taskana/task/internal/TaskQueryImpl.java index a43de51cb..743c1329d 100644 --- a/lib/taskana-core/src/main/java/pro/taskana/task/internal/TaskQueryImpl.java +++ b/lib/taskana-core/src/main/java/pro/taskana/task/internal/TaskQueryImpl.java @@ -10,7 +10,6 @@ import org.slf4j.Logger; import org.slf4j.LoggerFactory; import pro.taskana.common.api.KeyDomain; -import pro.taskana.common.api.LoggerUtils; import pro.taskana.common.api.TaskanaRole; import pro.taskana.common.api.TimeInterval; import pro.taskana.common.api.exceptions.InvalidArgumentException; @@ -980,7 +979,7 @@ public class TaskQueryImpl implements TaskQuery { LOGGER.debug( "mapper returned {} resulting Objects: {} ", tasks.size(), - LoggerUtils.listToString(tasks)); + tasks); } result = taskService.augmentTaskSummariesByContainedSummaries(tasks); return result; @@ -990,7 +989,7 @@ public class TaskQueryImpl implements TaskQuery { LOGGER.debug( "exit from list(). Returning {} resulting Objects: {} ", result.size(), - LoggerUtils.listToString(result)); + result); } } } @@ -1025,7 +1024,7 @@ public class TaskQueryImpl implements TaskQuery { LOGGER.debug( "exit from list(offset,limit). Returning {} resulting Objects: {} ", result.size(), - LoggerUtils.listToString(result)); + result); } } } @@ -1064,7 +1063,7 @@ public class TaskQueryImpl implements TaskQuery { LOGGER.debug( "Exit from listValues. Returning {} resulting Objects: {} ", result.size(), - LoggerUtils.listToString(result)); + result); } } } diff --git a/lib/taskana-core/src/main/java/pro/taskana/task/internal/TaskServiceImpl.java b/lib/taskana-core/src/main/java/pro/taskana/task/internal/TaskServiceImpl.java index 4cc0ce783..affd4ec92 100644 --- a/lib/taskana-core/src/main/java/pro/taskana/task/internal/TaskServiceImpl.java +++ b/lib/taskana-core/src/main/java/pro/taskana/task/internal/TaskServiceImpl.java @@ -26,7 +26,6 @@ import pro.taskana.classification.api.exceptions.ClassificationNotFoundException import pro.taskana.classification.api.models.Classification; import pro.taskana.classification.api.models.ClassificationSummary; import pro.taskana.common.api.BulkOperationResults; -import pro.taskana.common.api.LoggerUtils; import pro.taskana.common.api.TaskanaRole; import pro.taskana.common.api.exceptions.ConcurrencyException; import pro.taskana.common.api.exceptions.InvalidArgumentException; @@ -481,7 +480,7 @@ public class TaskServiceImpl implements TaskService { public BulkOperationResults deleteTasks(List taskIds) throws InvalidArgumentException, NotAuthorizedException { if (LOGGER.isDebugEnabled()) { - LOGGER.debug("entry to deleteTasks(tasks = {})", LoggerUtils.listToString(taskIds)); + LOGGER.debug("entry to deleteTasks(tasks = {})", taskIds); } taskanaEngine.getEngine().checkRoleMembership(TaskanaRole.ADMIN); @@ -571,7 +570,7 @@ public class TaskServiceImpl implements TaskService { if (LOGGER.isDebugEnabled()) { LOGGER.debug( "updateTasks() updated the following tasks: {} ", - LoggerUtils.listToString(changedTasks)); + changedTasks); } } else { @@ -611,7 +610,7 @@ public class TaskServiceImpl implements TaskService { if (LOGGER.isDebugEnabled()) { LOGGER.debug( "updateTasks() updated the following tasks: {} ", - LoggerUtils.listToString(changedTasks)); + changedTasks); } } else { @@ -664,7 +663,7 @@ public class TaskServiceImpl implements TaskService { if (LOGGER.isDebugEnabled()) { LOGGER.debug( "entry to setCallbackStateForTasks(externalIds = {})", - LoggerUtils.listToString(externalIds)); + externalIds); } try { taskanaEngine.openConnection(); @@ -698,7 +697,7 @@ public class TaskServiceImpl implements TaskService { LOGGER.debug( "entry to setOwnerOfTasks(owner = {}, tasks = {})", owner, - LoggerUtils.listToString(argTaskIds)); + argTaskIds); } BulkOperationResults bulkLog = new BulkOperationResults<>(); if (argTaskIds == null || argTaskIds.isEmpty()) { @@ -751,7 +750,7 @@ public class TaskServiceImpl implements TaskService { LOGGER.debug( "entry to setPlannedPropertyOfTasks(planned = {}, tasks = {})", planned, - LoggerUtils.listToString(argTaskIds)); + argTaskIds); } BulkLog bulkLog = new BulkLog(); @@ -841,7 +840,7 @@ public class TaskServiceImpl implements TaskService { LOGGER.debug( "the following tasks are affected by the update of classification {} : {}", classificationId, - LoggerUtils.listToString(affectedTaskIds)); + affectedTaskIds); } LOGGER.debug("exit from findTasksIdsAffectedByClassificationChange(). "); return affectedTaskIds; @@ -852,7 +851,7 @@ public class TaskServiceImpl implements TaskService { if (LOGGER.isDebugEnabled()) { LOGGER.debug( "entry to refreshPriorityAndDueDateOfTasks(tasks = {})", - LoggerUtils.listToString(taskIds)); + taskIds); } Pair, BulkLog> resultsPair = getMinimalTaskSummaries(taskIds); List tasks = resultsPair.getLeft(); @@ -1010,7 +1009,7 @@ public class TaskServiceImpl implements TaskService { if (LOGGER.isDebugEnabled()) { LOGGER.debug( "entry to augmentTaskSummariesByContainedSummaries(taskSummaries= {})", - LoggerUtils.listToString(taskSummaries)); + taskSummaries); } List result = new ArrayList<>(); @@ -1432,8 +1431,8 @@ public class TaskServiceImpl implements TaskService { LOGGER.debug( "entry to checkIfTasksMatchCompleteCriteria(taskIds = {}, " + "taskSummaries = {}, bulkLog = {})", - LoggerUtils.listToString(taskIds), - LoggerUtils.listToString(taskSummaries), + taskIds, + taskSummaries, bulkLog); } @@ -1477,8 +1476,8 @@ public class TaskServiceImpl implements TaskService { if (LOGGER.isDebugEnabled()) { LOGGER.debug( "entry to updateTasksToBeCompleted(taskIds = {}, taskSummaries = {})", - LoggerUtils.listToString(taskIds), - LoggerUtils.listToString(taskSummaries)); + taskIds, + taskSummaries); } if (!taskIds.isEmpty() && !taskSummaries.isEmpty()) { @@ -1495,8 +1494,7 @@ public class TaskServiceImpl implements TaskService { if (LOGGER.isDebugEnabled()) { LOGGER.debug( "entry to addClassificationSummariesToTaskSummaries(tasks = {}, classifications = {})", - LoggerUtils.listToString(tasks), - LoggerUtils.listToString(classifications)); + tasks, classifications); } if (tasks == null || tasks.isEmpty()) { @@ -1619,9 +1617,9 @@ public class TaskServiceImpl implements TaskService { LOGGER.debug( "entry to addAttachmentSummariesToTaskSummaries(taskSummaries = {}, " + "attachmentSummaries = {}, classifications = {})", - LoggerUtils.listToString(taskSummaries), - LoggerUtils.listToString(attachmentSummaries), - LoggerUtils.listToString(classifications)); + taskSummaries, + attachmentSummaries, + classifications); } if (taskSummaries == null || taskSummaries.isEmpty()) { @@ -1680,8 +1678,8 @@ public class TaskServiceImpl implements TaskService { if (LOGGER.isDebugEnabled()) { LOGGER.debug( "entry to addClassificationSummariesToAttachments(targetWbId = {}, taskIds = {})", - LoggerUtils.listToString(attachmentImpls), - LoggerUtils.listToString(classifications)); + attachmentImpls, + classifications); } if (attachmentImpls == null || attachmentImpls.isEmpty()) { @@ -1717,7 +1715,7 @@ public class TaskServiceImpl implements TaskService { if (LOGGER.isDebugEnabled()) { LOGGER.debug( "entry to initUpdatedTask(customFieldsToUpdate = {}, fieldSelector = {})", - LoggerUtils.mapToString(customFieldsToUpdate), + customFieldsToUpdate, fieldSelector); } @@ -1741,7 +1739,7 @@ public class TaskServiceImpl implements TaskService { if (LOGGER.isDebugEnabled()) { LOGGER.debug( "entry to validateCustomFields(customFieldsToUpdate = {})", - LoggerUtils.mapToString(customFieldsToUpdate)); + customFieldsToUpdate); } if (customFieldsToUpdate == null || customFieldsToUpdate.isEmpty()) { diff --git a/lib/taskana-core/src/main/java/pro/taskana/task/internal/TaskTransferrer.java b/lib/taskana-core/src/main/java/pro/taskana/task/internal/TaskTransferrer.java index fc9919bed..e10a53043 100644 --- a/lib/taskana-core/src/main/java/pro/taskana/task/internal/TaskTransferrer.java +++ b/lib/taskana-core/src/main/java/pro/taskana/task/internal/TaskTransferrer.java @@ -11,7 +11,6 @@ import org.slf4j.Logger; import org.slf4j.LoggerFactory; import pro.taskana.common.api.BulkOperationResults; -import pro.taskana.common.api.LoggerUtils; import pro.taskana.common.api.exceptions.InvalidArgumentException; import pro.taskana.common.api.exceptions.NotAuthorizedException; import pro.taskana.common.api.exceptions.TaskanaException; @@ -188,7 +187,7 @@ public class TaskTransferrer { "entry to transferTasks(targetWbKey = {}, domain = {}, taskIds = {})", destinationWorkbasketKey, destinationWorkbasketDomain, - LoggerUtils.listToString(taskIds)); + taskIds); } // Check pre-conditions with trowing Exceptions @@ -207,7 +206,7 @@ public class TaskTransferrer { + "destination taskIds = {})", destinationWorkbasketKey, destinationWorkbasketDomain, - LoggerUtils.listToString(taskIds)); + taskIds); } taskanaEngine.returnConnection(); @@ -223,7 +222,7 @@ public class TaskTransferrer { LOGGER.debug( "entry to transferTasks(targetWbId = {}, taskIds = {})", destinationWorkbasketId, - LoggerUtils.listToString(taskIds)); + taskIds); } // Check pre-conditions with trowing Exceptions @@ -238,7 +237,7 @@ public class TaskTransferrer { LOGGER.debug( "exit from transferTasks(targetWbKey = {}, taskIds = {})", destinationWorkbasketId, - LoggerUtils.listToString(taskIds)); + taskIds); } taskanaEngine.returnConnection(); @@ -251,7 +250,7 @@ public class TaskTransferrer { if (LOGGER.isDebugEnabled()) { LOGGER.debug( "entry to transferTasks(taskIdsToBeTransferred = {}, destinationWorkbasket = {})", - LoggerUtils.listToString(taskIdsToBeTransferred), + taskIdsToBeTransferred, destinationWorkbasket); } @@ -292,8 +291,8 @@ public class TaskTransferrer { LOGGER.debug( "entry to checkIfTransferConditionsAreFulfilled(taskIds = {}, " + "taskSummaries = {}, bulkLog = {})", - LoggerUtils.listToString(taskIds), - LoggerUtils.listToString(taskSummaries), + taskIds, + taskSummaries, bulkLog); } @@ -324,9 +323,9 @@ public class TaskTransferrer { LOGGER.debug( "entry to checkIfTasksMatchTransferCriteria(taskIds = {}, taskSummaries = {}, " + "sourceWorkbaskets = {}, bulkLog = {})", - LoggerUtils.listToString(taskIds), - LoggerUtils.listToString(taskSummaries), - LoggerUtils.listToString(sourceWorkbaskets), + taskIds, + taskSummaries, + sourceWorkbaskets, bulkLog); } @@ -378,8 +377,8 @@ public class TaskTransferrer { LOGGER.debug( "entry to updateTasksToBeTransferred(taskIds = {}, taskSummaries = {}, " + "destinationWorkbasket = {})", - LoggerUtils.listToString(taskIds), - LoggerUtils.listToString(taskSummaries), + taskIds, + taskSummaries, destinationWorkbasket.getId()); } diff --git a/lib/taskana-core/src/main/java/pro/taskana/task/internal/jobs/TaskCleanupJob.java b/lib/taskana-core/src/main/java/pro/taskana/task/internal/jobs/TaskCleanupJob.java index 16c6d24b9..99fd2b21a 100644 --- a/lib/taskana-core/src/main/java/pro/taskana/task/internal/jobs/TaskCleanupJob.java +++ b/lib/taskana-core/src/main/java/pro/taskana/task/internal/jobs/TaskCleanupJob.java @@ -12,7 +12,6 @@ import org.slf4j.LoggerFactory; import pro.taskana.common.api.BaseQuery.SortDirection; import pro.taskana.common.api.BulkOperationResults; -import pro.taskana.common.api.LoggerUtils; import pro.taskana.common.api.ScheduledJob; import pro.taskana.common.api.TaskanaEngine; import pro.taskana.common.api.TimeInterval; @@ -135,7 +134,7 @@ public class TaskCleanupJob extends AbstractTaskanaJob { if (LOGGER.isDebugEnabled()) { LOGGER.debug( - "exit from getTasksCompletedBefore(), returning {}", LoggerUtils.listToString(taskList)); + "exit from getTasksCompletedBefore(), returning {}", taskList); } return taskList; @@ -145,7 +144,7 @@ public class TaskCleanupJob extends AbstractTaskanaJob { if (LOGGER.isDebugEnabled()) { LOGGER.debug( "entry to deleteTasksTransactionally(tasksToBeDeleted = {})", - LoggerUtils.listToString(tasksToBeDeleted)); + tasksToBeDeleted); } int deletedTaskCount = 0; diff --git a/lib/taskana-core/src/main/java/pro/taskana/task/internal/jobs/TaskRefreshJob.java b/lib/taskana-core/src/main/java/pro/taskana/task/internal/jobs/TaskRefreshJob.java index fbbca96ca..20dd46b1c 100644 --- a/lib/taskana-core/src/main/java/pro/taskana/task/internal/jobs/TaskRefreshJob.java +++ b/lib/taskana-core/src/main/java/pro/taskana/task/internal/jobs/TaskRefreshJob.java @@ -6,7 +6,6 @@ import java.util.Map; import org.slf4j.Logger; import org.slf4j.LoggerFactory; -import pro.taskana.common.api.LoggerUtils; import pro.taskana.common.api.ScheduledJob; import pro.taskana.common.api.TaskanaEngine; import pro.taskana.common.api.exceptions.TaskanaException; @@ -54,6 +53,6 @@ public class TaskRefreshJob extends AbstractTaskanaJob { @Override public String toString() { - return "TaskRefreshJob [affectedTaskIds= " + LoggerUtils.listToString(affectedTaskIds) + "]"; + return "TaskRefreshJob [affectedTaskIds= " + affectedTaskIds + "]"; } } diff --git a/lib/taskana-core/src/main/java/pro/taskana/workbasket/internal/AbstractWorkbasketAccessItemQueryImpl.java b/lib/taskana-core/src/main/java/pro/taskana/workbasket/internal/AbstractWorkbasketAccessItemQueryImpl.java index adccf14e8..cc8634c97 100644 --- a/lib/taskana-core/src/main/java/pro/taskana/workbasket/internal/AbstractWorkbasketAccessItemQueryImpl.java +++ b/lib/taskana-core/src/main/java/pro/taskana/workbasket/internal/AbstractWorkbasketAccessItemQueryImpl.java @@ -8,7 +8,6 @@ import org.apache.ibatis.session.RowBounds; import org.slf4j.Logger; import org.slf4j.LoggerFactory; -import pro.taskana.common.api.LoggerUtils; import pro.taskana.common.api.exceptions.TaskanaRuntimeException; import pro.taskana.common.internal.InternalTaskanaEngine; import pro.taskana.workbasket.api.AbstractWorkbasketAccessItemQuery; @@ -95,7 +94,7 @@ abstract class AbstractWorkbasketAccessItemQueryImpl< LOGGER.debug( "exit from list(). Returning {} resulting Objects: {} ", result.size(), - LoggerUtils.listToString(result)); + result); } } } @@ -126,7 +125,7 @@ abstract class AbstractWorkbasketAccessItemQueryImpl< LOGGER.debug( "exit from list(offset,limit). Returning {} resulting Objects: {} ", result.size(), - LoggerUtils.listToString(result)); + result); } } } @@ -150,7 +149,7 @@ abstract class AbstractWorkbasketAccessItemQueryImpl< LOGGER.debug( "Exit from listValues. Returning {} resulting Objects: {} ", numberOfResultObjects, - LoggerUtils.listToString(result)); + result); } } } diff --git a/lib/taskana-core/src/main/java/pro/taskana/workbasket/internal/WorkbasketAccessItemQueryImpl.java b/lib/taskana-core/src/main/java/pro/taskana/workbasket/internal/WorkbasketAccessItemQueryImpl.java index fbcfce8e5..e0bdfa4a7 100644 --- a/lib/taskana-core/src/main/java/pro/taskana/workbasket/internal/WorkbasketAccessItemQueryImpl.java +++ b/lib/taskana-core/src/main/java/pro/taskana/workbasket/internal/WorkbasketAccessItemQueryImpl.java @@ -8,7 +8,6 @@ import org.apache.ibatis.session.RowBounds; import org.slf4j.Logger; import org.slf4j.LoggerFactory; -import pro.taskana.common.api.LoggerUtils; import pro.taskana.common.api.exceptions.TaskanaRuntimeException; import pro.taskana.common.internal.InternalTaskanaEngine; import pro.taskana.workbasket.api.AccessItemQueryColumnName; @@ -111,7 +110,7 @@ public class WorkbasketAccessItemQueryImpl implements WorkbasketAccessItemQuery LOGGER.debug( "exit from list(). Returning {} resulting Objects: {} ", result.size(), - LoggerUtils.listToString(result)); + result); } return result; } @@ -142,7 +141,7 @@ public class WorkbasketAccessItemQueryImpl implements WorkbasketAccessItemQuery LOGGER.debug( "exit from list(offset,limit). Returning {} resulting Objects: {} ", result.size(), - LoggerUtils.listToString(result)); + result); } } } @@ -166,7 +165,7 @@ public class WorkbasketAccessItemQueryImpl implements WorkbasketAccessItemQuery LOGGER.debug( "Exit from listValues. Returning {} resulting Objects: {} ", numberOfResultObjects, - LoggerUtils.listToString(result)); + result); } } } diff --git a/lib/taskana-core/src/main/java/pro/taskana/workbasket/internal/WorkbasketQueryImpl.java b/lib/taskana-core/src/main/java/pro/taskana/workbasket/internal/WorkbasketQueryImpl.java index c52e51a89..3ef67bf3f 100644 --- a/lib/taskana-core/src/main/java/pro/taskana/workbasket/internal/WorkbasketQueryImpl.java +++ b/lib/taskana-core/src/main/java/pro/taskana/workbasket/internal/WorkbasketQueryImpl.java @@ -9,7 +9,6 @@ import org.slf4j.Logger; import org.slf4j.LoggerFactory; import pro.taskana.TaskanaEngineConfiguration; -import pro.taskana.common.api.LoggerUtils; import pro.taskana.common.api.TaskanaRole; import pro.taskana.common.api.TimeInterval; import pro.taskana.common.api.exceptions.InvalidArgumentException; @@ -398,7 +397,7 @@ public class WorkbasketQueryImpl implements WorkbasketQuery { LOGGER.debug( "exit from list(). Returning {} resulting Objects: {} ", numberOfResultObjects, - LoggerUtils.listToString(workbaskets)); + workbaskets); } } } @@ -428,7 +427,7 @@ public class WorkbasketQueryImpl implements WorkbasketQuery { LOGGER.debug( "exit from list(offset,limit). Returning {} resulting Objects: {} ", workbaskets.size(), - LoggerUtils.listToString(workbaskets)); + workbaskets); } } } @@ -450,7 +449,7 @@ public class WorkbasketQueryImpl implements WorkbasketQuery { LOGGER.debug( "Exit from listValues. Returning {} resulting Objects: {} ", result.size(), - LoggerUtils.listToString(result)); + result); } } } diff --git a/lib/taskana-core/src/main/java/pro/taskana/workbasket/internal/WorkbasketServiceImpl.java b/lib/taskana-core/src/main/java/pro/taskana/workbasket/internal/WorkbasketServiceImpl.java index 4b8d2f3eb..596088bc7 100644 --- a/lib/taskana-core/src/main/java/pro/taskana/workbasket/internal/WorkbasketServiceImpl.java +++ b/lib/taskana-core/src/main/java/pro/taskana/workbasket/internal/WorkbasketServiceImpl.java @@ -14,7 +14,6 @@ import org.slf4j.LoggerFactory; import pro.taskana.TaskanaEngineConfiguration; import pro.taskana.common.api.BulkOperationResults; -import pro.taskana.common.api.LoggerUtils; import pro.taskana.common.api.TaskanaRole; import pro.taskana.common.api.exceptions.ConcurrencyException; import pro.taskana.common.api.exceptions.DomainNotFoundException; @@ -428,7 +427,7 @@ public class WorkbasketServiceImpl implements WorkbasketService { LOGGER.debug( "exit from getWorkbasketAccessItems(workbasketId). Returning {} resulting Objects: {} ", result.size(), - LoggerUtils.listToString(result)); + result); } } } @@ -532,7 +531,7 @@ public class WorkbasketServiceImpl implements WorkbasketService { LOGGER.debug( "exit from getDistributionTargets(workbasketId). Returning {} resulting Objects: {} ", numberOfResultObjects, - LoggerUtils.listToString(result)); + result); } } } @@ -563,7 +562,7 @@ public class WorkbasketServiceImpl implements WorkbasketService { LOGGER.debug( "exit from getDistributionTargets(workbasketId). Returning {} resulting Objects: {} ", numberOfResultObjects, - LoggerUtils.listToString(result)); + result); } } } @@ -575,7 +574,7 @@ public class WorkbasketServiceImpl implements WorkbasketService { LOGGER.debug( "entry to setDistributionTargets(sourceWorkbasketId = {}, targetWorkazketIds = {})", sourceWorkbasketId, - LoggerUtils.listToString(targetWorkbasketIds)); + targetWorkbasketIds); } taskanaEngine.getEngine().checkRoleMembership(TaskanaRole.BUSINESS_ADMIN, TaskanaRole.ADMIN); try { @@ -746,7 +745,7 @@ public class WorkbasketServiceImpl implements WorkbasketService { if (LOGGER.isDebugEnabled()) { LOGGER.debug( "entry to deleteWorkbaskets(workbasketId = {})", - LoggerUtils.listToString(workbasketsIds)); + workbasketsIds); } taskanaEngine.getEngine().checkRoleMembership(TaskanaRole.BUSINESS_ADMIN, TaskanaRole.ADMIN); @@ -817,7 +816,7 @@ public class WorkbasketServiceImpl implements WorkbasketService { LOGGER.debug( "exit from getDistributionSources(workbasketId). Returning {} resulting Objects: {} ", numberOfResultObjects, - LoggerUtils.listToString(result)); + result); } } } @@ -846,7 +845,7 @@ public class WorkbasketServiceImpl implements WorkbasketService { LOGGER.debug( "exit from getDistributionSources(workbasketId). Returning {} resulting Objects: {} ", numberOfResultObjects, - LoggerUtils.listToString(result)); + result); } } } diff --git a/rest/taskana-rest-spring-example-common/src/test/java/pro/taskana/ldap/LdapTest.java b/rest/taskana-rest-spring-example-common/src/test/java/pro/taskana/ldap/LdapTest.java index 9f9b31a53..7090c8a47 100644 --- a/rest/taskana-rest-spring-example-common/src/test/java/pro/taskana/ldap/LdapTest.java +++ b/rest/taskana-rest-spring-example-common/src/test/java/pro/taskana/ldap/LdapTest.java @@ -11,7 +11,6 @@ import org.springframework.test.context.ActiveProfiles; import org.springframework.test.context.junit.jupiter.SpringExtension; import pro.taskana.RestConfiguration; -import pro.taskana.common.api.LoggerUtils; import pro.taskana.common.api.exceptions.InvalidArgumentException; import pro.taskana.common.rest.ldap.LdapClient; import pro.taskana.common.rest.models.AccessIdRepresentationModel; @@ -30,7 +29,7 @@ class LdapTest { void testFindUsers() throws InvalidArgumentException { if (ldapClient.useLdap()) { List usersAndGroups = ldapClient.searchUsersAndGroups("ser0"); - System.out.println("#### found " + LoggerUtils.listToString(usersAndGroups)); + System.out.println("#### found " + usersAndGroups); assertThat(usersAndGroups).hasSize(50); } } diff --git a/rest/taskana-rest-spring/src/main/java/pro/taskana/classification/rest/ClassificationDefinitionController.java b/rest/taskana-rest-spring/src/main/java/pro/taskana/classification/rest/ClassificationDefinitionController.java index 32e406520..e33fc998c 100644 --- a/rest/taskana-rest-spring/src/main/java/pro/taskana/classification/rest/ClassificationDefinitionController.java +++ b/rest/taskana-rest-spring/src/main/java/pro/taskana/classification/rest/ClassificationDefinitionController.java @@ -34,7 +34,6 @@ import pro.taskana.classification.api.models.Classification; import pro.taskana.classification.api.models.ClassificationSummary; import pro.taskana.classification.rest.assembler.ClassificationRepresentationModelAssembler; import pro.taskana.classification.rest.models.ClassificationRepresentationModel; -import pro.taskana.common.api.LoggerUtils; import pro.taskana.common.api.exceptions.ConcurrencyException; import pro.taskana.common.api.exceptions.DomainNotFoundException; import pro.taskana.common.api.exceptions.InvalidArgumentException; @@ -178,7 +177,7 @@ public class ClassificationDefinitionController { if (LOGGER.isDebugEnabled()) { LOGGER.debug( "Exit from mapChildrenToParentKeys(), returning {}", - LoggerUtils.mapToString(childrenInFile)); + childrenInFile); } return childrenInFile; diff --git a/rest/taskana-rest-spring/src/main/java/pro/taskana/common/rest/ldap/LdapClient.java b/rest/taskana-rest-spring/src/main/java/pro/taskana/common/rest/ldap/LdapClient.java index a0e5a7466..9dbc78b05 100644 --- a/rest/taskana-rest-spring/src/main/java/pro/taskana/common/rest/ldap/LdapClient.java +++ b/rest/taskana-rest-spring/src/main/java/pro/taskana/common/rest/ldap/LdapClient.java @@ -22,7 +22,6 @@ import org.springframework.ldap.filter.OrFilter; import org.springframework.ldap.filter.WhitespaceWildcardsFilter; import org.springframework.stereotype.Component; -import pro.taskana.common.api.LoggerUtils; import pro.taskana.common.api.exceptions.InvalidArgumentException; import pro.taskana.common.api.exceptions.SystemException; import pro.taskana.common.rest.models.AccessIdRepresentationModel; @@ -86,7 +85,7 @@ public class LdapClient { "exit from searchUsersAndGroups(name = {}). Returning {} users and groups: {}", name, accessIds.size(), - LoggerUtils.listToString(result)); + result); return result; } @@ -119,7 +118,7 @@ public class LdapClient { new UserContextMapper()); LOGGER.debug( "exit from searchUsersByName. Retrieved the following users: {}.", - LoggerUtils.listToString(accessIds)); + accessIds); return accessIds; } @@ -147,7 +146,7 @@ public class LdapClient { new GroupContextMapper()); LOGGER.debug( "Exit from searchGroupsByName. Retrieved the following groups: {}", - LoggerUtils.listToString(accessIds)); + accessIds); return accessIds; } @@ -189,7 +188,7 @@ public class LdapClient { new GroupContextMapper()); LOGGER.debug( "exit from searchGroupsofUsersIsMember. Retrieved the following users: {}.", - LoggerUtils.listToString(accessIds)); + accessIds); return accessIds; } diff --git a/rest/taskana-rest-spring/src/main/java/pro/taskana/common/rest/models/TaskanaUserInfoRepresentationModel.java b/rest/taskana-rest-spring/src/main/java/pro/taskana/common/rest/models/TaskanaUserInfoRepresentationModel.java index 13b66e9cd..f371ceb82 100644 --- a/rest/taskana-rest-spring/src/main/java/pro/taskana/common/rest/models/TaskanaUserInfoRepresentationModel.java +++ b/rest/taskana-rest-spring/src/main/java/pro/taskana/common/rest/models/TaskanaUserInfoRepresentationModel.java @@ -4,7 +4,6 @@ import java.util.ArrayList; import java.util.List; import org.springframework.hateoas.RepresentationModel; -import pro.taskana.common.api.LoggerUtils; import pro.taskana.common.api.TaskanaRole; /** EntityModel class for user information. */ @@ -45,9 +44,9 @@ public class TaskanaUserInfoRepresentationModel + "userId= " + this.userId + "groupIds= " - + LoggerUtils.listToString(this.groupIds) + + groupIds + "roles= " - + LoggerUtils.listToString(this.roles) + + this.roles + "]"; } } diff --git a/rest/taskana-rest-spring/src/main/java/pro/taskana/workbasket/rest/WorkbasketController.java b/rest/taskana-rest-spring/src/main/java/pro/taskana/workbasket/rest/WorkbasketController.java index 741c0a5cc..7d8cf2ddc 100644 --- a/rest/taskana-rest-spring/src/main/java/pro/taskana/workbasket/rest/WorkbasketController.java +++ b/rest/taskana-rest-spring/src/main/java/pro/taskana/workbasket/rest/WorkbasketController.java @@ -22,7 +22,6 @@ import org.springframework.web.bind.annotation.RequestParam; import org.springframework.web.bind.annotation.RestController; import pro.taskana.common.api.BaseQuery.SortDirection; -import pro.taskana.common.api.LoggerUtils; import pro.taskana.common.api.exceptions.ConcurrencyException; import pro.taskana.common.api.exceptions.DomainNotFoundException; import pro.taskana.common.api.exceptions.InvalidArgumentException; @@ -305,7 +304,7 @@ public class WorkbasketController extends AbstractPagingController { LOGGER.debug( "Entry to getTasksStatusReport(workbasketId= {}, targetWorkbasketIds´= {})", sourceWorkbasketId, - LoggerUtils.listToString(targetWorkbasketIds)); + targetWorkbasketIds); } workbasketService.setDistributionTargets(sourceWorkbasketId, targetWorkbasketIds);