nosu
/
taskana
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

bugfix(TSK-891): The bug resulted from an unchecked default-assign and the actual category was overwritten. Now it is wrapped in a check for an existing value. Refactoring will follow in its own task

This commit is contained in:
Patric Schumann 2019-10-01 09:59:15 +02:00 committed by Holger Hagen
parent b09567410e
commit 8f3b338cef
1 changed files with 11 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
web/src/app/administration/classification/details/classification-details.component.ts
View File

@ -124,8 +124,13 @@ export class ClassificationDetailsComponent implements OnInit, OnDestroy {
this.categoriesSubscription = this.categoryService.getCategories().subscribe((categories: Array<string>) => { this.categoriesSubscription = this.categoryService.getCategories().subscribe((categories: Array<string>) => {
this.categories = categories; this.categories = categories;
// ToDo: Remove this line during refactoring. Atm checking why it was written takes too long
if (categories.length > 0 && this.classification) { if (categories.length > 0 && this.classification) {
this.classification.category = categories[0]; // TSK-891 fix: The property is already set and is crucial value
// Wrapped with an if to set a default if not already set.
if ( !this.classification.category ) {
this.classification.category = categories[0];
}
} }
}); });
@ -177,7 +182,7 @@ export class ClassificationDetailsComponent implements OnInit, OnDestroy {
this.afterRequest(); this.afterRequest();
}, },
error => { error => {
this.generalModalService.triggerMessage(new MessageModal('There was an error creating a classification', error)) this.generalModalService.triggerMessage(new MessageModal('There was an error creating a classification', error));
this.afterRequest(); this.afterRequest();
}); });
} else { } else {
@ -189,7 +194,7 @@ export class ClassificationDetailsComponent implements OnInit, OnDestroy {
new AlertModel(AlertType.SUCCESS, `Classification ${this.classification.key} was saved successfully`)); new AlertModel(AlertType.SUCCESS, `Classification ${this.classification.key} was saved successfully`));
this.cloneClassification(this.classification); this.cloneClassification(this.classification);
} catch (error) { } catch (error) {
this.generalModalService.triggerMessage(new MessageModal('There was error while saving your classification', error)) this.generalModalService.triggerMessage(new MessageModal('There was error while saving your classification', error));
this.afterRequest(); this.afterRequest();
} }
} }
@ -197,7 +202,7 @@ export class ClassificationDetailsComponent implements OnInit, OnDestroy {
onClear() { onClear() {
this.formsValidatorService.formSubmitAttempt = false; this.formsValidatorService.formSubmitAttempt = false;
this.alertService.triggerAlert(new AlertModel(AlertType.INFO, 'Reset edited fields')) this.alertService.triggerAlert(new AlertModel(AlertType.INFO, 'Reset edited fields'));
this.classification = { ...this.classificationClone }; this.classification = { ...this.classificationClone };
} }
@ -223,7 +228,7 @@ export class ClassificationDetailsComponent implements OnInit, OnDestroy {
} }
this.requestInProgress = true; this.requestInProgress = true;
const classification = await this.classificationsService.getClassification(id); const classification = await this.classificationsService.getClassification(id);
this.fillClassificationInformation(classification) this.fillClassificationInformation(classification);
this.classificationsService.selectClassification(classification); this.classificationsService.selectClassification(classification);
this.requestInProgress = false; this.requestInProgress = false;
} }
@ -288,7 +293,7 @@ export class ClassificationDetailsComponent implements OnInit, OnDestroy {
this.router.navigate(['taskana/administration/classifications']); this.router.navigate(['taskana/administration/classifications']);
this.alertService.triggerAlert(new AlertModel(AlertType.SUCCESS, `Classification ${key} was removed successfully`)) this.alertService.triggerAlert(new AlertModel(AlertType.SUCCESS, `Classification ${key} was removed successfully`))
}, error => { }, error => {
this.generalModalService.triggerMessage(new MessageModal('There was error while removing your classification', error)) this.generalModalService.triggerMessage(new MessageModal('There was error while removing your classification', error));
this.afterRequest(); this.afterRequest();
}) })
} }