From 9aebda65b794488b9430a62bd51f0711b04abf1e Mon Sep 17 00:00:00 2001
From: jamesrdi <james.reynaldi@envite.de>
Date: Fri, 15 Sep 2023 14:58:08 +0200
Subject: [PATCH] Fixed Code Smells

---
 .../java/pro/taskana/task/internal/TaskServiceImpl.java     | 6 +-----
 .../pro/taskana/task/rest/TaskQueryFilterParameter.java     | 2 +-
 2 files changed, 2 insertions(+), 6 deletions(-)

diff --git a/lib/taskana-core/src/main/java/pro/taskana/task/internal/TaskServiceImpl.java b/lib/taskana-core/src/main/java/pro/taskana/task/internal/TaskServiceImpl.java
index 08e3baaac..951ab168e 100644
--- a/lib/taskana-core/src/main/java/pro/taskana/task/internal/TaskServiceImpl.java
+++ b/lib/taskana-core/src/main/java/pro/taskana/task/internal/TaskServiceImpl.java
@@ -2255,10 +2255,6 @@ public class TaskServiceImpl implements TaskService {
     String workbasketId = task.getWorkbasketSummary().getId();
     WorkbasketSummary workbasket =
         query.idIn(workbasketId).callerHasPermissions(WorkbasketPermission.EDITTASKS).single();
-    if (workbasket == null) {
-      return false;
-    } else {
-      return true;
-    }
+    return workbasket != null;
   }
 }
diff --git a/rest/taskana-rest-spring/src/main/java/pro/taskana/task/rest/TaskQueryFilterParameter.java b/rest/taskana-rest-spring/src/main/java/pro/taskana/task/rest/TaskQueryFilterParameter.java
index e69edbecb..c1af19acb 100644
--- a/rest/taskana-rest-spring/src/main/java/pro/taskana/task/rest/TaskQueryFilterParameter.java
+++ b/rest/taskana-rest-spring/src/main/java/pro/taskana/task/rest/TaskQueryFilterParameter.java
@@ -2205,7 +2205,7 @@ public class TaskQueryFilterParameter implements QueryParameter<TaskQuery, Void>
     if (this.ownerIn == null) {
       return new String[]{null};
     }
-    List<String> ownerInAsList = new ArrayList(Arrays.asList(this.ownerIn));
+    List<String> ownerInAsList = new ArrayList<>(Arrays.asList(this.ownerIn));
     ownerInAsList.add(null);
     return ownerInAsList.toArray(new String[ownerInAsList.size()]);
   }