TSK-1009: last automated refactoring

This commit is contained in:
Mustapha Zorgati 2020-01-08 09:59:37 +01:00 committed by Holger Hagen
parent 09adb30171
commit b47610b62e
5 changed files with 23 additions and 17 deletions

View File

@ -206,13 +206,6 @@ abstract class AbstractWorkbasketAccessItemQueryImpl<
return columnName; return columnName;
} }
@SuppressWarnings("checkstyle:MethodName")
abstract Q _this();
abstract String getLinkToMapper();
abstract String getLinkToValueMapper();
protected Q addOrderCriteria(String colName, SortDirection sortDirection) { protected Q addOrderCriteria(String colName, SortDirection sortDirection) {
String orderByDirection = String orderByDirection =
" " + (sortDirection == null ? SortDirection.ASCENDING : sortDirection); " " + (sortDirection == null ? SortDirection.ASCENDING : sortDirection);
@ -221,6 +214,13 @@ abstract class AbstractWorkbasketAccessItemQueryImpl<
return _this(); return _this();
} }
@SuppressWarnings("checkstyle:MethodName")
abstract Q _this();
abstract String getLinkToMapper();
abstract String getLinkToValueMapper();
@Override @Override
public String toString() { public String toString() {
return "AbstractWorkbasketAccessItemQueryImpl [" return "AbstractWorkbasketAccessItemQueryImpl ["

View File

@ -115,6 +115,16 @@ public class ClassificationImpl extends ClassificationSummaryImpl implements Cla
return summary; return summary;
} }
protected boolean canEqual(Object other) {
return (other instanceof ClassificationImpl);
}
@Override
public int hashCode() {
return Objects.hash(
super.hashCode(), isValidInDomain, created, modified, description, applicationEntryPoint);
}
@Override @Override
public boolean equals(Object obj) { public boolean equals(Object obj) {
if (this == obj) { if (this == obj) {
@ -134,16 +144,6 @@ public class ClassificationImpl extends ClassificationSummaryImpl implements Cla
&& Objects.equals(applicationEntryPoint, other.applicationEntryPoint); && Objects.equals(applicationEntryPoint, other.applicationEntryPoint);
} }
@Override
public int hashCode() {
return Objects.hash(
super.hashCode(), isValidInDomain, created, modified, description, applicationEntryPoint);
}
protected boolean canEqual(Object other) {
return (other instanceof ClassificationImpl);
}
@Override @Override
public String toString() { public String toString() {
return "ClassificationImpl [id=" return "ClassificationImpl [id="

View File

@ -47,8 +47,10 @@ import pro.taskana.sampledata.SampleDataGenerator;
public class ClassificationServiceImplIntExplicitTest { public class ClassificationServiceImplIntExplicitTest {
private static final String ID_PREFIX_CLASSIFICATION = "CLI"; private static final String ID_PREFIX_CLASSIFICATION = "CLI";
@SuppressWarnings("checkstyle:DeclarationOrder") @SuppressWarnings("checkstyle:DeclarationOrder")
static int counter = 0; static int counter = 0;
private DataSource dataSource; private DataSource dataSource;
private ClassificationService classificationService; private ClassificationService classificationService;
private TaskanaEngineConfiguration taskanaEngineConfiguration; private TaskanaEngineConfiguration taskanaEngineConfiguration;

View File

@ -46,8 +46,10 @@ import pro.taskana.security.WithAccessId;
class WorkbasketServiceImplIntExplicitTest { class WorkbasketServiceImplIntExplicitTest {
private static final int SLEEP_TIME = 100; private static final int SLEEP_TIME = 100;
@SuppressWarnings("checkstyle:DeclarationOrder") @SuppressWarnings("checkstyle:DeclarationOrder")
static int counter = 0; static int counter = 0;
private DataSource dataSource; private DataSource dataSource;
private TaskanaEngineConfiguration taskanaEngineConfiguration; private TaskanaEngineConfiguration taskanaEngineConfiguration;
private TaskanaEngine taskanaEngine; private TaskanaEngine taskanaEngine;

View File

@ -42,8 +42,10 @@ import pro.taskana.rest.resource.TaskResourceAssembler;
class AsyncUpdateJobIntTest { class AsyncUpdateJobIntTest {
private static final String CLASSIFICATION_ID = "CLI:100000000000000000000000000000000003"; private static final String CLASSIFICATION_ID = "CLI:100000000000000000000000000000000003";
@SuppressWarnings("checkstyle:DeclarationOrder") @SuppressWarnings("checkstyle:DeclarationOrder")
static RestTemplate template; static RestTemplate template;
@Autowired ClassificationResourceAssembler classificationResourceAssembler; @Autowired ClassificationResourceAssembler classificationResourceAssembler;
@Autowired TaskResourceAssembler taskResourceAssembler; @Autowired TaskResourceAssembler taskResourceAssembler;
@Autowired JobScheduler jobScheduler; @Autowired JobScheduler jobScheduler;