From b4ec24e705c5a31710926ef6b9aefd7e5729fc9f Mon Sep 17 00:00:00 2001 From: BerndBreier <33351391+BerndBreier@users.noreply.github.com> Date: Thu, 20 Dec 2018 20:37:46 +0100 Subject: [PATCH] TSK-756b - Comments from Holger --- .../java/acceptance/task/CreateTaskAccTest.java | 17 ++++++----------- 1 file changed, 6 insertions(+), 11 deletions(-) diff --git a/lib/taskana-core/src/test/java/acceptance/task/CreateTaskAccTest.java b/lib/taskana-core/src/test/java/acceptance/task/CreateTaskAccTest.java index bc4c2c766..a6a4342cf 100644 --- a/lib/taskana-core/src/test/java/acceptance/task/CreateTaskAccTest.java +++ b/lib/taskana-core/src/test/java/acceptance/task/CreateTaskAccTest.java @@ -85,7 +85,7 @@ public class CreateTaskAccTest extends AbstractAccTest { @WithAccessId( userName = "user_1_1", groupNames = {"group_1"}) - @Test + @Test(expected = TaskAlreadyExistException.class) public void testIdempotencyOfTaskCreation() throws NotAuthorizedException, InvalidArgumentException, ClassificationNotFoundException, WorkbasketNotFoundException, TaskAlreadyExistException { @@ -115,16 +115,11 @@ public class CreateTaskAccTest extends AbstractAccTest { assertEquals(false, createdTask.isRead()); assertEquals(false, createdTask.isTransferred()); - try { - newTask = taskService.newTask("USER_1_1", "DOMAIN_A"); - newTask.setExternalId("MyExternalId"); - newTask.setClassificationKey("T2100"); - newTask.setPrimaryObjRef(createObjectReference("COMPANY_A", "SYSTEM_A", "INSTANCE_A", "VNR", "1234567")); - taskService.createTask(newTask); - assertTrue("This line of code must not be reached", false); - } catch (TaskAlreadyExistException ex) { - assertTrue("correctly enforced Idempotency", true); - } + newTask = taskService.newTask("USER_1_1", "DOMAIN_A"); + newTask.setExternalId("MyExternalId"); + newTask.setClassificationKey("T2100"); + newTask.setPrimaryObjRef(createObjectReference("COMPANY_A", "SYSTEM_A", "INSTANCE_A", "VNR", "1234567")); + taskService.createTask(newTask); } @WithAccessId(