nosu
/
taskana
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

TSK-991: Make archunit tests more readable

This commit is contained in:
Benjamin Eckstein 2020-02-06 11:50:06 +01:00
parent 819b4ca699
commit be06d36a96
1 changed files with 38 additions and 38 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

76
lib/taskana-core/src/test/java/pro/taskana/ArchitectureTest.java
View File

@ -11,9 +11,7 @@ import com.tngtech.archunit.core.domain.JavaClasses;
import com.tngtech.archunit.core.importer.ClassFileImporter;
import com.tngtech.archunit.core.importer.ImportOption.DoNotIncludeTests;
import com.tngtech.archunit.lang.ArchRule;
import java.util.Collection;
import java.util.regex.Pattern;
import java.util.stream.Collectors;
import java.util.stream.Stream;
import org.junit.jupiter.api.BeforeAll;
import org.junit.jupiter.api.Disabled;
@ -99,7 +97,7 @@ class ArchitectureTest {
* https://www.archunit.org/userguide/html/000_Index.html#_cycle_checks
*/
@TestFactory
Collection<DynamicTest> freeOfCycles_subpackages() {
Stream<DynamicTest> freeOfCycles_subpackages() {
Stream<String> packagesToTest =
Stream.of(
@ -116,54 +114,56 @@ class ArchitectureTest {
"pro.taskana.task.internal.(*)..",
"pro.taskana.workbasket.api.(*)..",
"pro.taskana.workbasket.internal.(*)..");
return packagesToTest
.map(
p ->
dynamicTest(
p.replaceAll(Pattern.quote("pro.taskana."), "") + " is free of cycles",
() -> slices().matching(p).should().beFreeOfCycles().check(importedClasses)))
.collect(Collectors.toList());
return packagesToTest.map(
p ->
dynamicTest(
p.replaceAll(Pattern.quote("pro.taskana."), "") + " is free of cycles",
() -> slices().matching(p).should().beFreeOfCycles().check(importedClasses)));
}
@Disabled("TBD")
@Test
void commonClassesShouldNotDependOnOtherDomainClasses() {
ArchRule myRule =
noClasses()
.that()
.resideInAPackage("..common..")
.should()
.dependOnClassesThat()
.resideInAnyPackage(
"..classification..", "..history..", "..report..", "..task..", "..workbasket..");
myRule.check(importedClasses);
@TestFactory
Stream<DynamicTest> commonClassesShouldNotDependOnOtherDomainClasses() {
Stream<String> packagesToTest =
Stream.of("..workbasket..", "..report..", "..history..", "..task..", "..classification..");
return packagesToTest.map(
p ->
dynamicTest(
p.replaceAll(Pattern.quote("."), "") + " should not be used by common",
() ->
noClasses()
.that()
.resideInAPackage("..common..")
.should()
.dependOnClassesThat()
.resideInAPackage(p)
.check(importedClasses)));
}
@TestFactory
Collection<DynamicTest> classesShouldNotDependOnReportDomainClasses() {
Stream<DynamicTest> classesShouldNotDependOnReportDomainClasses() {
Stream<String> packagesToTest =
Stream.of(
"..workbasket..",
"..history..",
"..task..",
// TBD
// "..common..",
"..classification..");
return packagesToTest
.map(
p ->
dynamicTest(
"Domain "
+ p.replaceAll(Pattern.quote("."), "")
+ " should not depend on reports",
() ->
noClasses()
.that()
.resideInAPackage(p)
.should()
.dependOnClassesThat()
.resideInAnyPackage("..report..")
.check(importedClasses)))
.collect(Collectors.toList());
return packagesToTest.map(
p ->
dynamicTest(
"Domain " + p.replaceAll(Pattern.quote("."), "") + " should not depend on reports",
() ->
noClasses()
.that()
.resideInAPackage(p)
.should()
.dependOnClassesThat()
.resideInAnyPackage("..report..")
.check(importedClasses)));
}
@Disabled