TSK-1544: Removed duplicated tests

This commit is contained in:
Joerg Heffner 2021-02-24 10:49:26 +01:00 committed by gitgoodjhe
parent e7ac77cd39
commit be4f6c997a
4 changed files with 0 additions and 72 deletions

View File

@ -125,23 +125,6 @@ class TaskHistoryEventControllerIntTest {
.containsExactly("THI:000000000000000000000000000000000000");
}
@Test
@Disabled("no solution for this")
void should_ReturnBadStatusErrorCode_When_InvalidQueryParameterIsUsed() {
ThrowingCallable httpCall =
() ->
TEMPLATE.exchange(
restHelper.toUrl(HistoryRestEndpoints.URL_HISTORY_EVENTS + "?invalid=BPI:01"),
HttpMethod.GET,
restHelper.defaultRequest(),
TASK_HISTORY_EVENT_PAGED_REPRESENTATION_MODEL_TYPE);
assertThatThrownBy(httpCall)
.isInstanceOf(HttpClientErrorException.class)
.hasMessageContaining("[invalid]")
.extracting(ex -> ((HttpClientErrorException) ex).getStatusCode())
.isEqualTo(HttpStatus.BAD_REQUEST);
}
@Test
@Disabled("Jörg pls fix this")
void should_ReturnBadStatusErrorCode_When_CreatedQueryParameterIsWrongFormatted() {

View File

@ -16,7 +16,6 @@ import java.util.List;
import javax.sql.DataSource;
import org.assertj.core.api.ThrowableAssert.ThrowingCallable;
import org.junit.jupiter.api.BeforeAll;
import org.junit.jupiter.api.Disabled;
import org.junit.jupiter.api.Test;
import org.springframework.beans.factory.annotation.Autowired;
import org.springframework.beans.factory.annotation.Value;
@ -496,23 +495,6 @@ class TaskControllerIntTest {
+ "&sort-by=POR_VALUE&order=DESCENDING");
}
@Test
@Disabled("currently no solution for this")
void testThrowsExceptionIfInvalidFilterIsUsed() {
ThrowingCallable httpCall =
() ->
TEMPLATE.exchange(
restHelper.toUrl(RestEndpoints.URL_TASKS) + "?invalid=VNR",
HttpMethod.GET,
restHelper.defaultRequest(),
TASK_SUMMARY_PAGE_MODEL_TYPE);
assertThatThrownBy(httpCall)
.isInstanceOf(HttpClientErrorException.class)
.hasMessageContaining("[invalid]")
.extracting(ex -> ((HttpClientErrorException) ex).getStatusCode())
.isEqualTo(HttpStatus.BAD_REQUEST);
}
@Test
void testGetLastPageSortedByPorValue() {

View File

@ -7,7 +7,6 @@ import static pro.taskana.common.test.rest.RestHelper.TEMPLATE;
import java.util.List;
import java.util.stream.Stream;
import org.assertj.core.api.ThrowableAssert.ThrowingCallable;
import org.junit.jupiter.api.Disabled;
import org.junit.jupiter.api.DynamicTest;
import org.junit.jupiter.api.MethodOrderer;
import org.junit.jupiter.api.Test;
@ -76,24 +75,6 @@ class WorkbasketAccessItemControllerIntTest {
.isTrue();
}
@Test
@Disabled("currently no solution for this.")
void testThrowsExceptionIfInvalidFilterIsUsed() {
ThrowingCallable httpCall =
() ->
TEMPLATE.exchange(
restHelper.toUrl(RestEndpoints.URL_WORKBASKET_ACCESS_ITEMS)
+ "?sort-by=WORKBASKET_KEY&order=ASCENDING&page=1&page-size=9&invalid=user-1-1",
HttpMethod.GET,
restHelper.defaultRequest(),
WORKBASKET_ACCESS_ITEM_PAGED_REPRESENTATION_MODEL_TYPE);
assertThatThrownBy(httpCall)
.isInstanceOf(HttpClientErrorException.class)
.hasMessageContaining("[invalid]")
.extracting(ex -> ((HttpClientErrorException) ex).getStatusCode())
.isEqualTo(HttpStatus.BAD_REQUEST);
}
@Test
void testGetSecondPageSortedByWorkbasketKey() {
String parameters =

View File

@ -7,7 +7,6 @@ import static pro.taskana.common.test.rest.RestHelper.TEMPLATE;
import java.time.Instant;
import java.util.Optional;
import org.assertj.core.api.ThrowableAssert.ThrowingCallable;
import org.junit.jupiter.api.Disabled;
import org.junit.jupiter.api.Test;
import org.springframework.beans.factory.annotation.Autowired;
import org.springframework.core.ParameterizedTypeReference;
@ -117,23 +116,6 @@ class WorkbasketControllerIntTest {
.isTrue();
}
@Test
@Disabled("no solution for this yet")
void testThrowsExceptionIfInvalidFilterIsUsed() {
ThrowingCallable httpCall =
() ->
TEMPLATE.exchange(
restHelper.toUrl(RestEndpoints.URL_WORKBASKET) + "?invalid=PERSONAL",
HttpMethod.GET,
restHelper.defaultRequest(),
WORKBASKET_SUMMARY_PAGE_MODEL_TYPE);
assertThatThrownBy(httpCall)
.isInstanceOf(HttpClientErrorException.class)
.hasMessageContaining("[invalid]")
.extracting(ex -> ((HttpClientErrorException) ex).getStatusCode())
.isEqualTo(HttpStatus.BAD_REQUEST);
}
@Test
void testUpdateWorkbasketWithConcurrentModificationShouldThrowException() {