TSK-1775: reformatted entire backend code base

with new formatter
This commit is contained in:
Mustapha Zorgati 2021-11-24 18:25:35 +01:00
parent 3c86ff2969
commit c7742b3056
14 changed files with 23 additions and 48 deletions

View File

@ -12,5 +12,4 @@ public class SystemException extends TaskanaRuntimeException {
public SystemException(String msg, Throwable cause) {
super(msg, ErrorCode.of(ERROR_KEY), cause);
}
}

View File

@ -24,11 +24,11 @@ import pro.taskana.spi.history.api.events.workbasket.WorkbasketHistoryEventType;
class LogfileHistoryServiceImplTest {
static TaskanaEngine taskanaEngineMock;
private final ObjectMapper objectMapper = new ObjectMapper().registerModule(new JavaTimeModule());
private final LogfileHistoryServiceImpl logfileHistoryServiceImpl =
new LogfileHistoryServiceImpl();
private final TestLogger logger = TestLoggerFactory.getTestLogger("AUDIT");
static TaskanaEngine taskanaEngineMock;
@AfterEach
public void clearLoggers() {

View File

@ -82,8 +82,7 @@ public class TaskHistoryQueryImpl implements TaskHistoryQuery {
private String[] custom3Like;
private String[] custom4Like;
public TaskHistoryQueryImpl(
TaskanaHistoryEngineImpl taskanaHistoryEngine) {
public TaskHistoryQueryImpl(TaskanaHistoryEngineImpl taskanaHistoryEngine) {
this.taskanaHistoryEngine = taskanaHistoryEngine;
this.orderBy = new ArrayList<>();
this.orderColumns = new ArrayList<>();
@ -266,7 +265,6 @@ public class TaskHistoryQueryImpl implements TaskHistoryQuery {
return custom4Like;
}
@Override
public TaskHistoryQuery idIn(String... idIn) {
this.idIn = toUpperCopy(idIn);

View File

@ -501,9 +501,7 @@ class QueryTaskHistoryAccTest extends AbstractAccTest {
.list();
assertThat(taskHistoryEvents).hasSize(1);
assertThat(taskHistoryEvents.get(0))
.extracting(TaskHistoryEvent::getUserLongName)
.isNull();
assertThat(taskHistoryEvents.get(0)).extracting(TaskHistoryEvent::getUserLongName).isNull();
}
@WithAccessId(user = "user-1-1")
@ -533,8 +531,6 @@ class QueryTaskHistoryAccTest extends AbstractAccTest {
.list();
assertThat(taskHistoryEvents).hasSize(1);
assertThat(taskHistoryEvents.get(0))
.extracting(TaskHistoryEvent::getUserLongName)
.isNull();
assertThat(taskHistoryEvents.get(0)).extracting(TaskHistoryEvent::getUserLongName).isNull();
}
}

View File

@ -13,12 +13,12 @@ import pro.taskana.common.internal.transaction.TaskanaTransactionProvider;
/** Abstract base for all background jobs of TASKANA. */
public abstract class AbstractTaskanaJob implements TaskanaJob {
protected Instant firstRun;
protected Duration runEvery;
protected final TaskanaEngineImpl taskanaEngineImpl;
protected final TaskanaTransactionProvider txProvider;
protected final ScheduledJob scheduledJob;
private final boolean async;
protected Instant firstRun;
protected Duration runEvery;
protected AbstractTaskanaJob(
TaskanaEngine taskanaEngine,

View File

@ -51,7 +51,6 @@ public interface TaskCommentQuery extends BaseQuery<TaskComment, TaskCommentQuer
*/
TaskCommentQuery taskIdIn(String... taskIds);
/**
* Add your texts for pattern matching to your query. It will be compared in SQL with the LIKE
* operator. You may use a wildcard like % to specify the pattern. If you specify multiple

View File

@ -3,7 +3,6 @@ package pro.taskana.task.api;
import pro.taskana.common.api.QueryColumnName;
public enum TaskCommentQueryColumnName implements QueryColumnName {
ID("tc.id"),
TASK_ID("tc.task_id"),
TEXT_FIELD("tc.text_field"),
@ -22,6 +21,4 @@ public enum TaskCommentQueryColumnName implements QueryColumnName {
public String toString() {
return name;
}
}

View File

@ -385,8 +385,7 @@ public class TaskServiceImpl implements TaskService {
@Override
public TaskCommentQuery createTaskCommentQuery() {
return new TaskCommentQueryImpl(
taskanaEngine);
return new TaskCommentQueryImpl(taskanaEngine);
}
@Override

View File

@ -186,5 +186,4 @@ public interface User {
void setData(String data);
User copy();
}

View File

@ -100,12 +100,8 @@ class GetTaskAccTest extends AbstractAccTest {
Task task = taskService.getTask("TKI:000000000000000000000000000000000000");
String userLongName =
taskanaEngine.getUserService().getUser(task.getOwner()).getLongName();
assertThat(task)
.extracting(Task::getOwnerLongName)
.isEqualTo(userLongName);
String userLongName = taskanaEngine.getUserService().getUser(task.getOwner()).getLongName();
assertThat(task).extracting(Task::getOwnerLongName).isEqualTo(userLongName);
}
@WithAccessId(user = "admin")
@ -117,10 +113,7 @@ class GetTaskAccTest extends AbstractAccTest {
Task task = taskService.getTask("TKI:000000000000000000000000000000000000");
assertThat(task)
.extracting(Task::getOwnerLongName)
.isNull();
assertThat(task).extracting(Task::getOwnerLongName).isNull();
}
@WithAccessId(user = "user-1-2")

View File

@ -5,5 +5,4 @@ import pro.taskana.TaskanaEngineConfiguration;
public interface TaskanaEngineConfigurationModifier {
void modify(TaskanaEngineConfiguration taskanaEngineConfiguration);
}

View File

@ -460,5 +460,4 @@ public class ReportFilterParameter {
this.custom16Like = custom16Like;
this.custom16NotIn = custom16NotIn;
}
}

View File

@ -17,7 +17,6 @@ public interface DmnValidator {
* Validates a DmnModelInstance.
*
* @param dmnModelInstance the DMN model to validate
*
*/
void validate(DmnModelInstance dmnModelInstance);
}

View File

@ -8,12 +8,10 @@ import pro.taskana.routing.dmn.spi.api.DmnValidator;
public class TestDmnValidatorImpl implements DmnValidator {
@Override
public void initialize(TaskanaEngine taskanaEngine) {
}
public void initialize(TaskanaEngine taskanaEngine) {}
@Override
public void validate(DmnModelInstance dmnModelInstance) {
//custom validation logic
// custom validation logic
}
}