TSK-637: Initialized return values to empty lists

lib/taskana-core/src/main/java/pro/taskana/impl/AttachmentImpl.java

@@ -117,6 +117,9 @@ public class AttachmentImpl implements Attachment {
 
     @Override
     public Map<String, String> getCustomAttributes() {
+        if (customAttributes == null) {
+            customAttributes = new HashMap<>();
+        }
         return customAttributes;
     }
 

lib/taskana-core/src/main/java/pro/taskana/impl/ClassificationQueryImpl.java

@@ -374,7 +374,7 @@ public class ClassificationQueryImpl implements ClassificationQuery {
     @Override
     public List<ClassificationSummary> list() {
         LOGGER.debug("entry to list(), this = {}", this);
-        List<ClassificationSummary> result = null;
+        List<ClassificationSummary> result = new ArrayList<>();
         try {
             taskanaEngine.openConnection();
             result = taskanaEngine.getSqlSession().selectList(LINK_TO_SUMMARYMAPPER, this);
@@ -392,7 +392,7 @@ public class ClassificationQueryImpl implements ClassificationQuery {
     @Override
     public List<ClassificationSummary> list(int offset, int limit) {
         LOGGER.debug("entry to list(offset = {}, limit = {}), this = {}", offset, limit, this);
-        List<ClassificationSummary> result = null;
+        List<ClassificationSummary> result = new ArrayList<>();
         try {
             taskanaEngine.openConnection();
             RowBounds rowBounds = new RowBounds(offset, limit);
@@ -421,7 +421,7 @@ public class ClassificationQueryImpl implements ClassificationQuery {
     @Override
     public List<String> listValues(String columnName, SortDirection sortDirection) {
         LOGGER.debug("Entry to listValues(dbColumnName={}) this = {}", columnName, this);
-        List<String> result = null;
+        List<String> result = new ArrayList<>();
         try {
             taskanaEngine.openConnection();
             this.columnName = columnName;

lib/taskana-core/src/main/java/pro/taskana/impl/ObjectReferenceQueryImpl.java

@@ -73,7 +73,7 @@ public class ObjectReferenceQueryImpl implements ObjectReferenceQuery {
     @Override
     public List<ObjectReference> list() {
         LOGGER.debug("entry to list(), this = {}", this);
-        List<ObjectReference> result = null;
+        List<ObjectReference> result = new ArrayList<>();
         try {
             taskanaEngine.openConnection();
             result = taskanaEngine.getSqlSession().selectList(LINK_TO_MAPPER, this);
@@ -91,7 +91,7 @@ public class ObjectReferenceQueryImpl implements ObjectReferenceQuery {
     @Override
     public List<String> listValues(String columnName, SortDirection sortDirection) {
         LOGGER.debug("Entry to listValues(dbColumnName={}) this = {}", columnName, this);
-        List<String> result = null;
+        List<String> result = new ArrayList<>();
         try {
             taskanaEngine.openConnection();
             this.columnName = columnName;
@@ -112,7 +112,7 @@ public class ObjectReferenceQueryImpl implements ObjectReferenceQuery {
     @Override
     public List<ObjectReference> list(int offset, int limit) {
         LOGGER.debug("entry to list(offset = {}, limit = {}), this = {}", offset, limit, this);
-        List<ObjectReference> result = null;
+        List<ObjectReference> result = new ArrayList<>();
         try {
             taskanaEngine.openConnection();
             RowBounds rowBounds = new RowBounds(offset, limit);

lib/taskana-core/src/main/java/pro/taskana/impl/ReportBuilder.java

@@ -1,6 +1,8 @@
 package pro.taskana.impl;
 
+import java.util.ArrayList;
 import java.util.Collections;
+import java.util.HashMap;
 import java.util.List;
 import java.util.Map;
 
@@ -52,6 +54,9 @@ public abstract class ReportBuilder {
     }
 
     public List<TimeIntervalColumnHeader> getColumnHeaders() {
+        if (columnHeaders == null) {
+            columnHeaders = new ArrayList<>();
+        }
         return this.columnHeaders;
     }
 
@@ -60,30 +65,51 @@ public abstract class ReportBuilder {
     }
 
     public List<String> getWorkbasketIdIn() {
+        if (workbasketIds == null) {
+            workbasketIds = new ArrayList<>();
+        }
         return this.workbasketIds;
     }
 
     public List<TaskState> getStateIn() {
+        if (states == null) {
+            states = new ArrayList<>();
+        }
         return this.states;
     }
 
     public List<String> getCategoryIn() {
+        if (categories == null) {
+            categories = new ArrayList<>();
+        }
         return this.categories;
     }
 
     public List<String> getDomainIn() {
+        if (domains == null) {
+            domains = new ArrayList<>();
+        }
         return this.domains;
     }
 
     public List<String> getClassificationIdsIn() {
+        if (classificationIds == null) {
+            classificationIds = new ArrayList<>();
+        }
         return this.classificationIds;
     }
 
     public List<String> getExcludedClassificationIdsIn() {
+        if (excludedClassificationIds == null) {
+            excludedClassificationIds = new ArrayList<>();
+        }
         return this.excludedClassificationIds;
     }
 
     public Map<CustomField, String> getCustomAttributeFilter() {
+        if (customAttributeFilter == null) {
+            customAttributeFilter = new HashMap<>();
+        }
         return this.customAttributeFilter;
     }
 

lib/taskana-core/src/main/java/pro/taskana/impl/TaskImpl.java

@@ -3,6 +3,7 @@ package pro.taskana.impl;
 import java.time.Instant;
 import java.util.ArrayList;
 import java.util.Collections;
+import java.util.HashMap;
 import java.util.Iterator;
 import java.util.List;
 import java.util.Map;
@@ -307,6 +308,9 @@ public class TaskImpl implements Task {
 
     @Override
     public Map<String, String> getCustomAttributes() {
+        if (customAttributes == null) {
+            customAttributes = new HashMap<>();
+        }
         return customAttributes;
     }
 
@@ -317,6 +321,9 @@ public class TaskImpl implements Task {
 
     @Override
     public Map<String, String> getCallbackInfo() {
+        if (callbackInfo == null) {
+            callbackInfo = new HashMap<>();
+        }
         return callbackInfo;
     }
 
@@ -464,6 +471,9 @@ public class TaskImpl implements Task {
 
     @Override
     public List<Attachment> getAttachments() {
+        if (attachments == null) {
+            attachments = new ArrayList<>();
+        }
         return attachments;
     }
 

lib/taskana-core/src/main/java/pro/taskana/impl/TaskQueryImpl.java

@@ -773,7 +773,7 @@ public class TaskQueryImpl implements TaskQuery {
     @Override
     public List<String> listValues(String columnName, SortDirection sortDirection) {
         LOGGER.debug("Entry to listValues(dbColumnName={}) this = {}", columnName, this);
-        List<String> result = null;
+        List<String> result = new ArrayList<>();
         try {
             taskanaEngine.openConnection();
             this.columnName = columnName;

lib/taskana-core/src/main/java/pro/taskana/impl/TaskSummaryImpl.java

@@ -347,6 +347,9 @@ public class TaskSummaryImpl implements TaskSummary {
 
     @Override
     public List<AttachmentSummary> getAttachmentSummaries() {
+        if (attachmentSummaries == null) {
+            attachmentSummaries = new ArrayList<>();
+        }
         return attachmentSummaries;
     }
 

lib/taskana-core/src/main/java/pro/taskana/impl/WorkbasketQueryImpl.java

@@ -371,7 +371,7 @@ public class WorkbasketQueryImpl implements WorkbasketQuery {
     @Override
     public List<WorkbasketSummary> list() {
         LOGGER.debug("entry to list(), this = {}", this);
-        List<WorkbasketSummary> workbaskets = null;
+        List<WorkbasketSummary> workbaskets = new ArrayList<>();
         try {
             taskanaEngine.openConnection();
             handleCallerRolesAndAccessIds();
@@ -390,7 +390,7 @@ public class WorkbasketQueryImpl implements WorkbasketQuery {
     @Override
     public List<String> listValues(String columnName, SortDirection sortDirection) {
         LOGGER.debug("Entry to listValues(dbColumnName={}) this = {}", columnName, this);
-        List<String> result = null;
+        List<String> result = new ArrayList<>();
         try {
             taskanaEngine.openConnection();
             this.columnName = columnName;
@@ -412,7 +412,7 @@ public class WorkbasketQueryImpl implements WorkbasketQuery {
     @Override
     public List<WorkbasketSummary> list(int offset, int limit) {
         LOGGER.debug("entry to list(offset = {}, limit = {}), this = {}", offset, limit, this);
-        List<WorkbasketSummary> workbaskets = null;
+        List<WorkbasketSummary> workbaskets = new ArrayList<>();
         try {
             taskanaEngine.openConnection();
             RowBounds rowBounds = new RowBounds(offset, limit);

lib/taskana-core/src/main/java/pro/taskana/impl/WorkbasketReportBuilderImpl.java

@@ -1,5 +1,6 @@
 package pro.taskana.impl;
 
+import java.util.ArrayList;
 import java.util.List;
 import java.util.Map;
 
@@ -94,6 +95,9 @@ public class WorkbasketReportBuilderImpl extends ReportBuilder implements Workba
     }
 
     public List<CombinedClassificationFilter> getCombinedClassificationFilterIn() {
+        if (combinedClassificationFilter == null) {
+            combinedClassificationFilter = new ArrayList<>();
+        }
         return this.combinedClassificationFilter;
     }
 

lib/taskana-core/src/test/java/pro/taskana/impl/CategoryReportBuilderImplTest.java

@@ -208,6 +208,15 @@ public class CategoryReportBuilderImplTest {
         assertEquals(expectedResult, actualResult);
     }
 
+    @Test
+    public void testListTaskIdsForSelectedItemsIsEmptyResult() throws NotAuthorizedException, InvalidArgumentException {
+        SelectedItem selectedItem = new SelectedItem();
+        List<SelectedItem> selectedItems = Collections.singletonList(selectedItem);
+        List<String> result = cut.createCategoryReportBuilder()
+                .listTaskIdsForSelectedItems(selectedItems);
+        assertNotNull(result);
+    }
+
     @Test
     public void testListCustomAttributeValuesForCustomAttributeName()
         throws NotAuthorizedException {
@@ -257,4 +266,12 @@ public class CategoryReportBuilderImplTest {
         assertNotNull(actualResult);
         assertEquals(expectedResult, actualResult);
     }
+
+    @Test
+    public void testListCustomAttributeValuesForCustomAttributeNameIsEmptyResult() throws NotAuthorizedException {
+        List<String> result = cut.createCategoryReportBuilder()
+                .workbasketIdIn(Arrays.asList("DieGibtsSicherNed"))
+                .listCustomAttributeValuesForCustomAttributeName(CustomField.CUSTOM_1);
+        assertNotNull(result);
+    }
 }

lib/taskana-core/src/test/java/pro/taskana/impl/ClassificationReportBuilderImplTest.java

@@ -318,6 +318,17 @@ public class ClassificationReportBuilderImplTest {
         assertEquals(expectedResult, actualResult);
     }
 
+    @Test
+    public void testGetTaskIdsForSelectedItemsIsEmptyResult() throws NotAuthorizedException, InvalidArgumentException {
+        SelectedItem selectedItem = new SelectedItem();
+        selectedItem.setKey("GIBTSNED");
+        List<SelectedItem> selectedItems = Collections.singletonList(selectedItem);
+        List<String> result = cut.createClassificationReportBuilder()
+                .workbasketIdIn(Arrays.asList("DieGibtsEhNed"))
+                .listTaskIdsForSelectedItems(selectedItems);
+        assertNotNull(result);
+    }
+
     @Test
     public void testListCustomAttributeValuesForCustomAttributeName()
         throws NotAuthorizedException {
@@ -368,4 +379,13 @@ public class ClassificationReportBuilderImplTest {
         assertEquals(expectedResult, actualResult);
     }
 
+    @Test
+    public void testListCustomAttributeValuesForCustomAttributeNameIsEmptyResult()
+        throws NotAuthorizedException {
+        List<String> result = cut.createClassificationReportBuilder()
+                .workbasketIdIn(Arrays.asList("DieGibtsGarantiertNed"))
+                .listCustomAttributeValuesForCustomAttributeName(CustomField.CUSTOM_10);
+        assertNotNull(result);
+    }
+
 }

lib/taskana-core/src/test/java/pro/taskana/impl/TestClassificationQuery.java

@@ -197,7 +197,7 @@ public class TestClassificationQuery implements ClassificationQuery {
 
     @Override
     public List<ClassificationSummary> list(int offset, int limit) {
-        return null;
+        return new ArrayList<>();
     }
 
     @Override

lib/taskana-core/src/test/java/pro/taskana/impl/WorkbasketReportBuilderImplTest.java

@@ -222,6 +222,16 @@ public class WorkbasketReportBuilderImplTest {
         assertEquals(expectedResult, actualResult);
     }
 
+    @Test(expected = InvalidArgumentException.class)
+    public void testlistTaskIdsForSelectedItemsIsEmptyResult()
+        throws NotAuthorizedException, InvalidArgumentException {
+        List<SelectedItem> selectedItems = new ArrayList<>();
+        List<String> result = cut.createWorkbasketReportBuilder()
+                .workbasketIdIn(Arrays.asList("DieGibtsGarantiertNed"))
+                .listTaskIdsForSelectedItems(selectedItems);
+        assertNotNull(result);
+    }
+
     @Test
     public void testListCustomAttributeValuesForCustomAttributeName()
         throws NotAuthorizedException {
@@ -271,4 +281,13 @@ public class WorkbasketReportBuilderImplTest {
         assertNotNull(actualResult);
         assertEquals(expectedResult, actualResult);
     }
+
+    @Test
+    public void testListCustomAttributeValuesForCustomAttributeNameIsEmptyResult()
+        throws NotAuthorizedException {
+        List<String> result = cut.createWorkbasketReportBuilder()
+                .workbasketIdIn(Arrays.asList("GibtsSicherNed"))
+                .listCustomAttributeValuesForCustomAttributeName(CustomField.CUSTOM_14);
+        assertNotNull(result);
+    }
 }