TSK-1576: Implemented tests to retrieve tasks for different user roles (#1505)

* TSK-1576: Implemented tests to retrieve tasks for different user roles

* TSK-1576: Apply suggestions from code review

Co-authored-by: Mustapha Zorgati <15628173+mustaphazorgati@users.noreply.github.com>

Co-authored-by: Patrick Treyer <ptreyer@users.noreply.github.com>
Co-authored-by: Mustapha Zorgati <15628173+mustaphazorgati@users.noreply.github.com>

lib/taskana-core/src/test/java/acceptance/classification/ClassificationQueryAccTest.java

@@ -1,4 +1,4 @@
-package acceptance.security;
+package acceptance.classification;
 
 import static org.assertj.core.api.Assertions.assertThat;
 

lib/taskana-core/src/test/java/acceptance/security/TaskQueryAccTest.java

@@ -1,57 +0,0 @@
-package acceptance.security;
-
-import static org.assertj.core.api.Assertions.assertThat;
-
-import acceptance.AbstractAccTest;
-import java.util.List;
-import org.junit.jupiter.api.Test;
-import org.junit.jupiter.api.extension.ExtendWith;
-
-import pro.taskana.common.test.security.JaasExtension;
-import pro.taskana.common.test.security.WithAccessId;
-import pro.taskana.task.api.TaskService;
-import pro.taskana.task.api.models.TaskSummary;
-
-/** Acceptance test for task queries and authorization. */
-@ExtendWith(JaasExtension.class)
-class TaskQueryAccTest extends AbstractAccTest {
-
-  @Test
-  void testTaskQueryUnauthenticated() {
-    TaskService taskService = taskanaEngine.getTaskService();
-
-    List<TaskSummary> results = taskService.createTaskQuery().ownerLike("%a%", "%u%").list();
-
-    assertThat(results).isEmpty();
-  }
-
-  @WithAccessId(user = "user-1-1")
-  @Test
-  void testTaskQueryUser_1_1() {
-    TaskService taskService = taskanaEngine.getTaskService();
-
-    List<TaskSummary> results = taskService.createTaskQuery().ownerLike("%a%", "%u%").list();
-
-    assertThat(results).hasSize(7);
-  }
-
-  @WithAccessId(user = "user-1-1", groups = "businessadmin")
-  @Test
-  void testTaskQueryUser_1_1BusinessAdm() {
-    TaskService taskService = taskanaEngine.getTaskService();
-
-    List<TaskSummary> results = taskService.createTaskQuery().ownerLike("%a%", "%u%").list();
-
-    assertThat(results).hasSize(7);
-  }
-
-  @WithAccessId(user = "user-1-1", groups = "admin")
-  @Test
-  void testTaskQueryUser_1_1Admin() {
-    TaskService taskService = taskanaEngine.getTaskService();
-
-    List<TaskSummary> results = taskService.createTaskQuery().ownerLike("%a%", "%u%").list();
-
-    assertThat(results).hasSize(39);
-  }
-}

lib/taskana-core/src/test/java/acceptance/task/QueryTasksByRoleAccTest.java

@@ -0,0 +1,88 @@
+package acceptance.task;
+
+import static org.assertj.core.api.Assertions.assertThat;
+
+import acceptance.AbstractAccTest;
+import java.util.List;
+import org.junit.jupiter.api.Test;
+import org.junit.jupiter.api.extension.ExtendWith;
+
+import pro.taskana.common.test.security.JaasExtension;
+import pro.taskana.common.test.security.WithAccessId;
+import pro.taskana.task.api.TaskService;
+import pro.taskana.task.api.models.TaskSummary;
+
+/** Acceptance test for task queries and authorization. */
+@ExtendWith(JaasExtension.class)
+class QueryTasksByRoleAccTest extends AbstractAccTest {
+
+  @Test
+  void should_ReturnNoResult_When_UserIsNotAuthenticated() {
+    TaskService taskService = taskanaEngine.getTaskService();
+
+    List<TaskSummary> results = taskService.createTaskQuery().list();
+
+    assertThat(results).isEmpty();
+  }
+
+  @WithAccessId(user = "admin")
+  @Test
+  void should_ReturnAllTasks_For_Admin() {
+    TaskService taskService = taskanaEngine.getTaskService();
+
+    List<TaskSummary> results = taskService.createTaskQuery().list();
+
+    assertThat(results).hasSize(87);
+  }
+
+  @WithAccessId(user = "taskadmin")
+  @Test
+  void should_ReturnAllTasks_For_TaskAdmin() {
+    TaskService taskService = taskanaEngine.getTaskService();
+
+    List<TaskSummary> results = taskService.createTaskQuery().list();
+
+    assertThat(results).hasSize(87);
+  }
+
+  @WithAccessId(user = "businessadmin")
+  @Test
+  void should_ReturnAllTasks_For_BusinessAdmin() {
+    TaskService taskService = taskanaEngine.getTaskService();
+
+    List<TaskSummary> results = taskService.createTaskQuery().list();
+
+    assertThat(results).isEmpty();
+  }
+
+  @WithAccessId(user = "monitor")
+  @Test
+  void should_ReturnAllTasks_For_MonitorUser() {
+    TaskService taskService = taskanaEngine.getTaskService();
+
+    List<TaskSummary> results = taskService.createTaskQuery().list();
+
+    assertThat(results).isEmpty();
+  }
+
+  @WithAccessId(user = "teamlead-1")
+  @Test
+  void should_ReturnAllTasks_For_TeamLead1() {
+    TaskService taskService = taskanaEngine.getTaskService();
+
+    List<TaskSummary> results = taskService.createTaskQuery().list();
+
+    assertThat(results).hasSize(25);
+  }
+
+  @WithAccessId(user = "user-1-1")
+  @Test
+  void should_ReturnAllTasks_For_User11() {
+    TaskService taskService = taskanaEngine.getTaskService();
+
+    List<TaskSummary> results = taskService.createTaskQuery().list();
+
+    assertThat(results).hasSize(7);
+  }
+
+}

lib/taskana-core/src/test/java/acceptance/task/TaskEngineAccTest.java

@@ -1,4 +1,4 @@
-package acceptance.security;
+package acceptance.task;
 
 import static org.assertj.core.api.Assertions.assertThat;
 import static org.assertj.core.api.Assertions.assertThatThrownBy;

lib/taskana-core/src/test/java/acceptance/workbasket/WorkbasketQueryAccTest.java

@@ -1,4 +1,4 @@
-package acceptance.security;
+package acceptance.workbasket;
 
 import static org.assertj.core.api.Assertions.assertThat;
 import static org.assertj.core.api.Assertions.assertThatThrownBy;