TSK-2003: minor refactoring

This commit is contained in:
Mustapha Zorgati 2023-02-16 14:58:29 +01:00
parent 3af17ece6a
commit e40417f1fd
1 changed files with 6 additions and 4 deletions

View File

@ -422,8 +422,9 @@ public class WorkbasketServiceImpl implements WorkbasketService {
taskanaEngine.getEngine().getCurrentUserContext().getAccessIds()))
.map(this::getPermissionsFromWorkbasketAccessItem);
if (!grantedPermissions.isPresent()
|| !grantedPermissions.get().containsAll(Arrays.asList(requestedPermissions))) {
if (grantedPermissions.isEmpty()
|| !new HashSet<>(grantedPermissions.get())
.containsAll(Arrays.asList(requestedPermissions))) {
throw new MismatchedWorkbasketPermissionException(
taskanaEngine.getEngine().getCurrentUserContext().getUserid(),
workbasketId,
@ -456,8 +457,9 @@ public class WorkbasketServiceImpl implements WorkbasketService {
taskanaEngine.getEngine().getCurrentUserContext().getAccessIds()))
.map(this::getPermissionsFromWorkbasketAccessItem);
if (!grantedPermissions.isPresent()
|| !grantedPermissions.get().containsAll(Arrays.asList(requestedPermissions))) {
if (grantedPermissions.isEmpty()
|| !new HashSet<>(grantedPermissions.get())
.containsAll(Arrays.asList(requestedPermissions))) {
throw new MismatchedWorkbasketPermissionException(
taskanaEngine.getEngine().getCurrentUserContext().getUserid(),
workbasketKey,