nosu
/
taskana
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

TSK-1031: removed unnecessary throws statements

This commit is contained in:
Holger Hagen 2020-02-05 09:46:57 +01:00
parent 448d4fb8fc
commit e6f8883e49
10 changed files with 1410 additions and 1421 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
lib/taskana-core/src/main/java/pro/taskana/common/internal/jobs/WorkbasketCleanupJob.java
View File

@ -15,8 +15,6 @@ import pro.taskana.common.api.exceptions.NotAuthorizedException;
import pro.taskana.common.api.exceptions.TaskanaException;
import pro.taskana.common.internal.transaction.TaskanaTransactionProvider;
import pro.taskana.workbasket.api.WorkbasketQueryColumnName;
import pro.taskana.workbasket.api.exceptions.WorkbasketInUseException;
import pro.taskana.workbasket.api.exceptions.WorkbasketNotFoundException;
/**
* Job to cleanup completed workbaskets after a period of time if there are no pending tasks
@ -113,8 +111,7 @@ public class WorkbasketCleanupJob extends AbstractTaskanaJob {
}
private int deleteWorkbaskets(List<String> workbasketsToBeDeleted)
throws InvalidArgumentException, NotAuthorizedException, WorkbasketNotFoundException,
WorkbasketInUseException {
throws InvalidArgumentException, NotAuthorizedException {
BulkOperationResults<String, TaskanaException> results =
taskanaEngineImpl.getWorkbasketService().deleteWorkbaskets(workbasketsToBeDeleted);

3
rest/taskana-rest-spring-example-boot/src/main/java/pro/taskana/rest/ExampleRestApplication.java
View File

@ -1,6 +1,5 @@
package pro.taskana.rest;
import java.sql.SQLException;
import javax.annotation.PostConstruct;
import javax.sql.DataSource;
import org.springframework.beans.factory.annotation.Autowired;
@ -63,7 +62,7 @@ public class ExampleRestApplication {
}
@PostConstruct
private void init() throws SQLException {
private void init() {
if (!ldapClient.useLdap()) {
AccessIdController.setLdapCache(ldapCacheTest);
}

3
rest/taskana-rest-spring-example-common/src/test/java/pro/taskana/rest/ExampleRestApplication.java
View File

@ -1,6 +1,5 @@
package pro.taskana.rest;
import java.sql.SQLException;
import javax.annotation.PostConstruct;
import javax.sql.DataSource;
import org.springframework.beans.factory.annotation.Autowired;
@ -63,7 +62,7 @@ public class ExampleRestApplication {
}
@PostConstruct
private void init() throws SQLException {
private void init() {
if (!ldapClient.useLdap()) {
AccessIdController.setLdapCache(ldapCacheTest);
}

3
rest/taskana-rest-spring-example-wildfly/src/main/java/pro/taskana/TaskanaWildFlyApplication.java
View File

@ -1,7 +1,6 @@
package pro.taskana;
import java.io.InputStream;
import java.sql.SQLException;
import java.util.Properties;
import javax.annotation.PostConstruct;
import javax.naming.Context;
@ -111,7 +110,7 @@ public class TaskanaWildFlyApplication extends SpringBootServletInitializer {
}
@PostConstruct
private void init() throws SQLException {
private void init() {
if (!ldapClient.useLdap()) {
AccessIdController.setLdapCache(ldapCacheTest);
}

2
rest/taskana-rest-spring-example-wildfly/src/main/java/pro/taskana/wildfly/security/WildflyWebSecurityConfig.java
View File

@ -42,7 +42,7 @@ public class WildflyWebSecurityConfig extends WebSecurityConfig {
private boolean devMode;
@Bean
public J2eePreAuthenticatedProcessingFilter preAuthFilter() throws Exception {
public J2eePreAuthenticatedProcessingFilter preAuthFilter() {
J2eePreAuthenticatedProcessingFilter filter = new J2eePreAuthenticatedProcessingFilter();
filter.setAuthenticationManager(preAuthManager());
return filter;

6
rest/taskana-rest-spring/src/main/java/pro/taskana/rest/WorkbasketController.java
View File

@ -156,7 +156,7 @@ public class WorkbasketController extends AbstractPagingController {
public ResponseEntity<WorkbasketResource> createWorkbasket(
@RequestBody WorkbasketResource workbasketResource)
throws InvalidWorkbasketException, NotAuthorizedException, WorkbasketAlreadyExistException,
WorkbasketNotFoundException, DomainNotFoundException {
DomainNotFoundException {
if (LOGGER.isDebugEnabled()) {
LOGGER.debug("Entry to createWorkbasket(workbasketResource= {})", workbasketResource);
}
@ -178,8 +178,8 @@ public class WorkbasketController extends AbstractPagingController {
public ResponseEntity<WorkbasketResource> updateWorkbasket(
@PathVariable(value = "workbasketId") String workbasketId,
@RequestBody WorkbasketResource workbasketResource)
throws InvalidWorkbasketException, WorkbasketNotFoundException,
NotAuthorizedException, ConcurrencyException {
throws InvalidWorkbasketException, WorkbasketNotFoundException, NotAuthorizedException,
ConcurrencyException {
LOGGER.debug("Entry to updateWorkbasket(workbasketId= {})", workbasketId);
ResponseEntity<WorkbasketResource> result;
if (workbasketId.equals(workbasketResource.workbasketId)) {

8
rest/taskana-rest-spring/src/test/java/pro/taskana/rest/ClassificationControllerIntTest.java
View File

@ -5,7 +5,6 @@ import static org.junit.Assert.assertNotNull;
import static org.junit.Assert.assertTrue;
import static org.junit.jupiter.api.Assertions.assertThrows;
import java.io.IOException;
import org.junit.jupiter.api.Assertions;
import org.junit.jupiter.api.Test;
import org.springframework.beans.factory.annotation.Autowired;
@ -180,8 +179,7 @@ class ClassificationControllerIntTest {
@Test
@DirtiesContext
void testCreateClassificationWithParentKeyInDomain_aShouldCreateAClassificationInRootDomain()
throws IOException {
void testCreateClassificationWithParentKeyInDomain_aShouldCreateAClassificationInRootDomain() {
String newClassification =
"{\"classificationId\":\"\",\"category\":\"MANUAL\",\"domain\":\"DOMAIN_A\","
+ "\"key\":\"NEW_CLASS_P2\",\"name\":\"new classification\","
@ -218,7 +216,7 @@ class ClassificationControllerIntTest {
@Test
@DirtiesContext
void testReturn400IfCreateClassificationWithIncompatibleParentIdAndKey() throws IOException {
void testReturn400IfCreateClassificationWithIncompatibleParentIdAndKey() {
String newClassification =
"{\"classificationId\":\"\",\"category\":\"MANUAL\",\"domain\":\"DOMAIN_B\","
+ "\"key\":\"NEW_CLASS_P3\",\"name\":\"new classification\","
@ -241,7 +239,7 @@ class ClassificationControllerIntTest {
@Test
@DirtiesContext
void testCreateClassificationWithClassificationIdReturnsError400() throws IOException {
void testCreateClassificationWithClassificationIdReturnsError400() {
String newClassification =
"{\"classificationId\":\"someId\",\"category\":\"MANUAL\","
+ "\"domain\":\"DOMAIN_A\",\"key\":\"NEW_CLASS\","

3
rest/taskana-rest-spring/src/test/java/pro/taskana/rest/ExampleDocumentationApp.java
View File

@ -1,6 +1,5 @@
package pro.taskana.rest;
import java.sql.SQLException;
import javax.annotation.PostConstruct;
import javax.sql.DataSource;
import org.springframework.beans.factory.annotation.Autowired;
@ -66,7 +65,7 @@ public class ExampleDocumentationApp {
}
@PostConstruct
private void init() throws SQLException {
private void init() {
AccessIdController.setLdapCache(new LdapCacheTestImpl());
sampleDataGenerator.generateSampleData();
}

2
rest/taskana-rest-spring/src/test/java/pro/taskana/rest/WorkbasketDefinitionControllerIntTest.java
View File

@ -209,7 +209,7 @@ class WorkbasketDefinitionControllerIntTest {
}
@Test
void testErrorWhenImportWithSameAccessIdAndWorkbasket() throws IOException {
void testErrorWhenImportWithSameAccessIdAndWorkbasket() {
WorkbasketDefinitionResource w = executeExportRequestForDomain("DOMAIN_A").getBody().get(0);
String w1String = workbasketToString(w);

4
rest/taskana-rest-spring/src/test/java/pro/taskana/rest/resource/WorkbasketResourceAssemblerTest.java
View File

@ -6,12 +6,10 @@ import org.junit.jupiter.api.Test;
import org.springframework.beans.factory.annotation.Autowired;
import pro.taskana.TaskanaSpringBootTest;
import pro.taskana.common.api.exceptions.NotAuthorizedException;
import pro.taskana.rest.Mapping;
import pro.taskana.workbasket.api.Workbasket;
import pro.taskana.workbasket.api.WorkbasketService;
import pro.taskana.workbasket.api.WorkbasketType;
import pro.taskana.workbasket.api.exceptions.WorkbasketNotFoundException;
import pro.taskana.workbasket.internal.WorkbasketImpl;
/** Test for {@link WorkbasketResourceAssembler}. */
@ -22,7 +20,7 @@ class WorkbasketResourceAssemblerTest {
@Autowired WorkbasketResourceAssembler workbasketResourceAssembler;
@Test
void workbasketToResource() throws NotAuthorizedException, WorkbasketNotFoundException {
void workbasketToResource() {
// given
Workbasket workbasket = workbasketService.newWorkbasket("1", "DOMAIN_A");
((WorkbasketImpl) workbasket).setId("ID");