nosu
/
taskana
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

TSK-1981: Fixed code smells

This commit is contained in:
Yakup Ensar Evli 2023-01-25 17:06:21 +01:00 committed by Mustapha Zorgati
parent f854e3d579
commit e789a62213
2 changed files with 6 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
rest/taskana-rest-spring/src/main/java/pro/taskana/common/rest/InitBinderControllerAdvice.java
View File

@ -22,12 +22,15 @@ public class InitBinderControllerAdvice {
} }
@InitBinder @InitBinder
@SuppressWarnings("ConstantConditions")
public void initBinder(WebDataBinder binder) { public void initBinder(WebDataBinder binder) {
binder.registerCustomEditor( binder.registerCustomEditor(
PriorityColumnHeaderRepresentationModel.class, PriorityColumnHeaderRepresentationModel.class,
new JsonPropertyEditor(objectMapper, PriorityColumnHeaderRepresentationModel.class)); new JsonPropertyEditor(objectMapper, PriorityColumnHeaderRepresentationModel.class));
binder.registerCustomEditor( binder.registerCustomEditor(
ObjectReference.class, new JsonPropertyEditor(objectMapper, ObjectReferenceImpl.class)); ObjectReference.class, new JsonPropertyEditor(objectMapper, ObjectReferenceImpl.class));
// @see https://stackoverflow.com/questions/75133732/spring-boot-rest-controller-array-handling
binder.registerCustomEditor(String[].class, new StringArrayPropertyEditor(null)); binder.registerCustomEditor(String[].class, new StringArrayPropertyEditor(null));
} }
} }

6
rest/taskana-rest-spring/src/test/java/pro/taskana/workbasket/rest/WorkbasketAccessItemControllerIntTest.java
View File

@ -114,10 +114,10 @@ class WorkbasketAccessItemControllerIntTest {
TEMPLATE.exchange( TEMPLATE.exchange(
url, HttpMethod.GET, auth, WORKBASKET_ACCESS_ITEM_PAGED_REPRESENTATION_MODEL_TYPE); url, HttpMethod.GET, auth, WORKBASKET_ACCESS_ITEM_PAGED_REPRESENTATION_MODEL_TYPE);
assertThat(response.getBody()).isNotNull(); assertThat(response.getBody()).isNotNull();
assertThat(response.getBody().getContent()).hasSize(0); assertThat(response.getBody().getContent()).isEmpty();
assertThat(response.getBody().getPageMetadata().getSize()).isEqualTo(9); assertThat(response.getBody().getPageMetadata().getSize()).isEqualTo(9);
assertThat(response.getBody().getPageMetadata().getTotalElements()).isEqualTo(0); assertThat(response.getBody().getPageMetadata().getTotalElements()).isZero();
assertThat(response.getBody().getPageMetadata().getTotalPages()).isEqualTo(0); assertThat(response.getBody().getPageMetadata().getTotalPages()).isZero();
assertThat(response.getBody().getPageMetadata().getNumber()).isEqualTo(1); assertThat(response.getBody().getPageMetadata().getNumber()).isEqualTo(1);
} }