TSK-860: Beautify the build log by correcting DB operations

lib/taskana-core/src/main/java/pro/taskana/configuration/DbSchemaCreator.java

@@ -88,12 +88,17 @@ public class DbSchemaCreator {
 
     private boolean isSchemaPreexisting(Connection connection) {
         ScriptRunner runner = getScriptRunnerInstance(connection);
+        StringWriter errorWriter = new StringWriter();
+        runner.setErrorLogWriter(new PrintWriter(errorWriter));
         try {
             BufferedReader reader = new BufferedReader(new InputStreamReader(this.getClass()
                 .getResourceAsStream(selectDbSchemaDetectionScript(connection.getMetaData().getDatabaseProductName()))));
             runner.runScript(getSqlSchemaNameParsed(reader));
         } catch (Exception e) {
             LOGGER.debug("Schema does not exist.");
+            if (!errorWriter.toString().trim().isEmpty()) {
+                LOGGER.debug(errorWriter.toString());
+            }
             return false;
         }
         LOGGER.debug("Schema does exist.");

lib/taskana-core/src/main/java/pro/taskana/impl/TaskanaEngineImpl.java

@@ -303,10 +303,10 @@ public class TaskanaEngineImpl implements TaskanaEngine {
     @Override
     public void checkRoleMembership(TaskanaRole... roles) throws NotAuthorizedException {
         if (!isUserInRole(roles)) {
-            if (LOGGER.isErrorEnabled()) {
+            if (LOGGER.isDebugEnabled()) {
                 String accessIds = LoggerUtils.listToString(CurrentUserContext.getAccessIds());
                 String rolesAsString = Arrays.toString(roles);
-                LOGGER.error("Throwing NotAuthorizedException because accessIds {} are not member of roles {}",
+                LOGGER.debug("Throwing NotAuthorizedException because accessIds {} are not member of roles {}",
                     accessIds,
                     rolesAsString);
             }

lib/taskana-core/src/test/java/acceptance/AbstractAccTest.java

@@ -33,19 +33,18 @@ public abstract class AbstractAccTest {
 
     protected static TaskanaEngineConfiguration taskanaEngineConfiguration;
     protected static TaskanaEngine taskanaEngine;
+    private static DBCleaner cleaner = new DBCleaner();
+    protected static TestDataGenerator testDataGenerator = new TestDataGenerator();
 
     @BeforeClass
     public static void setupTest() throws Exception {
-        resetDb();
+        resetDb(false);
     }
 
-    public static void resetDb(boolean... dropTables) throws SQLException, IOException {
+    public static void resetDb(boolean dropTables) throws SQLException, IOException {
         DataSource dataSource = TaskanaEngineConfigurationTest.getDataSource();
-        DBCleaner cleaner = new DBCleaner();
+        if (dropTables) {
-        if (dropTables == null || dropTables.length == 0) {
+            cleaner.clearDb(dataSource, dropTables);
-            cleaner.clearDb(dataSource, true);
-        } else {
-            cleaner.clearDb(dataSource, dropTables[0]);
         }
         dataSource = TaskanaEngineConfigurationTest.getDataSource();
         taskanaEngineConfiguration = new TaskanaEngineConfiguration(dataSource, false,
@@ -53,7 +52,6 @@ public abstract class AbstractAccTest {
         taskanaEngine = taskanaEngineConfiguration.buildTaskanaEngine();
         taskanaEngine.setConnectionManagementMode(ConnectionManagementMode.AUTOCOMMIT);
         cleaner.clearDb(dataSource, false);
-        TestDataGenerator testDataGenerator = new TestDataGenerator();
         testDataGenerator.generateTestData(dataSource);
     }
 

lib/taskana-core/src/test/java/acceptance/report/AbstractReportAccTest.java

@@ -33,8 +33,6 @@ public class AbstractReportAccTest {
     private static void resetDb() throws SQLException, IOException {
         DataSource dataSource = TaskanaEngineConfigurationTest.getDataSource();
         DBCleaner cleaner = new DBCleaner();
-        cleaner.clearDb(dataSource, true);
-        dataSource = TaskanaEngineConfigurationTest.getDataSource();
         taskanaEngineConfiguration = new TaskanaEngineConfiguration(dataSource, false,
             TaskanaEngineConfigurationTest.getSchemaName());
         taskanaEngineConfiguration.setGermanPublicHolidaysEnabled(false);

lib/taskana-core/src/test/java/acceptance/workbasket/DeleteWorkbasketAccTest.java

@@ -159,12 +159,13 @@ public class DeleteWorkbasketAccTest extends AbstractAccTest {
         workbasket.setOrgLevel1("company");
         workbasket = workbasketService.createWorkbasket(workbasket);
 
+        boolean failed = false;
         try {
             workbasketService.deleteWorkbasket(workbasket.getId());
         } catch (Exception e) {
-            // TODO Auto-generated catch block
+            failed = true;
-            e.printStackTrace();
         }
+        assertTrue(failed);
     }
 
     @WithAccessId(userName = "teamlead_2", groupNames = {"businessadmin"})

lib/taskana-core/src/test/java/pro/taskana/impl/integration/TaskServiceImplIntAutocommitTest.java

@@ -13,7 +13,6 @@ import javax.sql.DataSource;
 
 import org.junit.Assert;
 import org.junit.Before;
-import org.junit.BeforeClass;
 import org.junit.Test;
 import org.junit.runner.RunWith;
 
@@ -72,12 +71,6 @@ public class TaskServiceImplIntAutocommitTest {
     private ClassificationService classificationService;
     private WorkbasketService workbasketService;
 
-    @BeforeClass
-    public static void resetDb() {
-        DataSource ds = TaskanaEngineConfigurationTest.getDataSource();
-        DBCleaner cleaner = new DBCleaner();
-        cleaner.clearDb(ds, true);
-    }
 
     @Before
     public void setup() throws SQLException {
@@ -113,7 +106,6 @@ public class TaskServiceImplIntAutocommitTest {
         task.setClassificationKey(classification.getKey());
         task.setPrimaryObjRef(JunitHelper.createDefaultObjRef());
         task = taskServiceImpl.createTask(task);
-        // skanaEngineImpl.getSqlSession().commit(); // needed so that the change is visible in the other session
 
         TaskanaEngine te2 = taskanaEngineConfiguration.buildTaskanaEngine();
         TaskServiceImpl taskServiceImpl2 = (TaskServiceImpl) te2.getTaskService();
@@ -157,8 +149,6 @@ public class TaskServiceImplIntAutocommitTest {
         WorkbasketNotFoundException, ClassificationNotFoundException, ClassificationAlreadyExistException,
         TaskAlreadyExistException, InvalidWorkbasketException, InvalidArgumentException,
         WorkbasketAlreadyExistException, DomainNotFoundException {
-        DBCleaner cleaner = new DBCleaner();
-        cleaner.clearDb(TaskanaEngineConfiguration.createDefaultDataSource(), false);
         TaskanaEngineConfiguration taskanaEngineConfiguration = new TaskanaEngineConfiguration(null, false, false,
             null);
         TaskanaEngine te = taskanaEngineConfiguration.buildTaskanaEngine();

lib/taskana-core/src/test/java/pro/taskana/impl/integration/TaskServiceImplIntExplicitTest.java

@@ -98,7 +98,6 @@ public class TaskServiceImplIntExplicitTest {
         taskanaEngineImpl.setConnectionManagementMode(ConnectionManagementMode.EXPLICIT);
         workbasketService = taskanaEngine.getWorkbasketService();
         cleaner = new DBCleaner();
-        cleaner.clearDb(dataSource, true);
         DbSchemaCreator creator = new DbSchemaCreator(dataSource, dataSource.getConnection().getSchema());
         creator.run();
     }
@@ -181,8 +180,6 @@ public class TaskServiceImplIntExplicitTest {
         TaskAlreadyExistException, InvalidWorkbasketException, InvalidArgumentException,
         WorkbasketAlreadyExistException, DomainNotFoundException {
         DataSource ds = TaskanaEngineConfiguration.createDefaultDataSource();
-        DBCleaner cleaner = new DBCleaner();
-        cleaner.clearDb(ds, false);
         TaskanaEngineConfiguration taskanaEngineConfiguration = new TaskanaEngineConfiguration(ds, false, false,
             null);
         TaskanaEngine te = taskanaEngineConfiguration.buildTaskanaEngine();