Commit Graph

344 Commits

Author SHA1 Message Date
Jörg Heffner 8d4d46de6a Comments from Holger Hagen 2020-04-22 13:41:20 +02:00
Jörg Heffner d5674ed11a TSK-746 Add simple history event tracking to update and create task method 2020-04-22 13:41:20 +02:00
Jörg Heffner c36933b450 Comments from Holger Hagen 2020-04-22 10:05:43 +02:00
Jörg Heffner 101072d3e9 TSK-1188 Enable combo filter for tasks 2020-04-22 10:05:43 +02:00
Sascha Frevel 2c5634c917 TSK-1180: migrate from JUnit 5 assertions to assertJ assertions
TSK-1180: remove hemcrest dependency

TSK-1180: convertes junit Assertions.ThrownBy to assertJ style

TSK-1180: add archUnit rule for checking if org.junit.jupiter.api.Assertions is used in classes

TSK-1080: fixed archunit tests which failed due to rebase

test

fixed order problem with H2 database -> set collation to DEFAULT_de_DE

disabled test with collation problems, readded old style assrtj test
2020-04-20 08:10:16 +02:00
Mustapha Zorgati 05818cabad Updated poms to version 2.1.2-SNAPSHOT 2020-04-15 13:15:08 +00:00
Mustapha Zorgati eef64bc1b3 Updated poms to version 2.1.1-SNAPSHOT 2020-04-14 12:03:41 +00:00
Sofie Hofmann 673f1896da TSK-652, TSK-1170, TSK-1023 Fixed various bugs by introducing ngxs state management
TSK-1170 Remove @inputs from classification-types-selector

TSK-1170 Import Store in Classification-Detail-Component



TSK-1170 Removed getSelectedClassificationType() from category service

TSK-1170 Removed getSelectedClassificationType() from category service

TSK-1170 Put icons in store

TSK-1170 Removed selectCategoryType from service

TSK-1170 Refactored classification-category service

TSK-1170 Fixed multiple calls of actions

TSK-1170

TSK-1170: build ngxs store in parallel to the ngrx store


TSK-1170: replaced ngrx store with ngxs store

tests are still failing.
TSK-1170 Split store into two stores

TSK-1170 Fixed tests

TSK-1170 added categories service test

TSK-1170 Fixed checkstyle and test

TSK-1170: minimized diff for classification-details component


TSK-1170: replaced state with store observable in classificaiton details


TSK-1170 Incorporated requested changes in spec files


TSK-1170 Removed @output from classification-types-selector

Removed getClassifications() call when selecting a classification type because the code is duplicated in performRequest() 
TSK-1170 Extracted selectors and actions


TSK-1170 Dispatch action in classification-service




TSK-1170 Incorporated 'set-value' function


dynamically rendering classification types

TSK-1170: disabled parent reference while creating classification


TSK-1170 fixed two ways binding for classification types

TSK-1170 removed console log

TSK-1170: Category dropdown shows correct values

TSK-1170 Renamed selectors




TSK-1170
2020-04-09 17:34:01 +02:00
Jörg Heffner b79c4891e3 TSK-1178 2020-04-09 09:59:02 +02:00
Jörg Heffner dffb139a82 comments from Holger Hagen 2020-03-31 11:56:59 +02:00
Jörg Heffner 636135bf1a Comments from Mustapha Zorgati 2020-03-31 11:56:59 +02:00
Jörg Heffner c5bb6fb32c TSK-1150 - added taskId as pathvariable to updateTaskComment and createTaskComment
-Added tests
2020-03-31 11:56:59 +02:00
Mustapha Zorgati 4eba81bd57 TSK-1150: now returning 404 StatusCode for TaskCommentNotFoundException 2020-03-31 11:56:59 +02:00
Mustapha Zorgati 93a94f0458 TSK-1150: added taskId as pathvariable to getTaskComment and deleteTaskComment
this is necessary since the path variable {taskId} is not used otherwise. Furthermore this will require that the search for a comment must match a given taskId.
2020-03-31 11:56:59 +02:00
Jörg Heffner ce571722d5 TSK-1150: Added REST-API for task comments 2020-03-31 11:56:59 +02:00
BerndBreier d6505284f7 TSK-1160 - terminate/cancel task Holger's comments 2020-03-30 13:21:06 +02:00
Sascha Frevel fc3f9e1868 TSK-1164: refactor code which is using assertJ's assertThatThrownBy and lambda expression with line breaks 2020-03-23 07:37:54 +01:00
Holger Hagen c9791b01b8 TSK-1029: Proper distinction between delete and markForFeletion for
workbaskets
2020-03-19 09:53:54 +01:00
Sascha Frevel d574cfa06f TSK-1145: enabled validateThrows property for JavadocMethod.checkstyle and added missing throws javadoc 2020-03-17 09:41:18 +01:00
Mustapha Zorgati b386af1a30 Updated poms to version 2.0.2-SNAPSHOT 2020-03-05 17:03:05 +00:00
Holger Hagen 32d069ac97 TSK-1152: added test coverage for util methods. 2020-03-05 13:27:41 +01:00
Holger Hagen 9615e8f77d TSK-1152: checkstyle fix. 2020-03-05 13:27:41 +01:00
Holger Hagen 545c706547 TSK-1152: removed stacktrace from log for InvalidArgumentException. 2020-03-05 13:27:41 +01:00
Holger Hagen ad31328e1b TSK-1152: using embedded ldap for integration tests. 2020-03-05 13:27:41 +01:00
Holger Hagen bbd6686248 TSK-1052: added inmemory ldap server for int testing. 2020-03-05 13:27:41 +01:00
Sascha Frevel 89de71f242 TSK-1151: fixed pretty printing configuration for spring rest doc 2020-03-05 10:46:20 +01:00
Holger Hagen 22b1db4a23 TSK-1024: Add base dn to dn if it does not exist. 2020-03-04 16:39:59 +01:00
Jörg Heffner 80d813709b TSK-1148 Include Comments from Holger Hagen 2020-03-03 12:32:45 +01:00
Jörg Heffner 349d24d7b8 TSK-1148 Application-Entry-Point in ClassificationSummaryResource 2020-03-03 12:32:45 +01:00
Sofie Hofmann ebd2098434 TSK-1147 Replaced getRestTemplate() by constant TEMPLATE
TSK-1147 Usage of AssertJ ListAsserts

TSK-1147 Usage of AssertJ ListAssert

TSK-1147 Removed doesNotContain
2020-03-03 11:40:47 +01:00
Mustapha Zorgati 5770ddd63e TSK-1146: added ConstantNameCheck to checkstyle 2020-02-26 08:45:12 +01:00
Sofie Hofmann 1109a01349 TSK-1140 Corrected ClassificationResourceAssembler and corresponding test 2020-02-23 10:26:15 +01:00
Jörg Heffner d34a44a32a TSK-1137 Endpoint to cancel claim task for REST-API
-Added endpoint
-Added tests
-updated REST documentation
-removed unnecessary delete documentation from unrelated test in TaskControllerRestDocumentation
2020-02-21 11:32:45 +01:00
Sofie Hofmann 9546ff37b2 TSK-1112 Changed @RequestMapping to @PostMapping / @GetMapping / ...
TSK-1112 deleted suppressWarnings

TSK-1112 Removed duplicated method
2020-02-17 14:26:28 +01:00
Mustapha Zorgati 5dc185daeb Updated poms to version 2.0.1-SNAPSHOT 2020-02-14 14:48:18 +00:00
Jörg Heffner ddb12a6ad1 TSK-1095
-Removed internal imports from api classes
-moved 3 exceptions from common.api.exceptions to task.api.exceptions
-Adjusted package structure of taskana-cdi and taskana-spring to match taskana-core
2020-02-14 12:04:52 +01:00
Holger Hagen f64053ec4e TSK-1125: distributiontargets now produce application/hal-json 2020-02-13 16:12:39 +01:00
Jörg Heffner 5c7d38451c TSK-1094 introduce models package for */api and */internal 2020-02-13 15:09:39 +01:00
Holger Hagen 4c884819d5 TSK-1123: workbasketaccessitems now produce application/hal-json 2020-02-13 14:20:17 +01:00
Sofie Hofmann fc812cb9ea TSK-1109 Make WorkbasketResource attributes private and convert tests to AssertJ 2020-02-13 09:25:08 +01:00
Sofie Hofmann 71761c1328 TSK-1108 Made attributes in WorkbasketAccessItemResource private and converted tests to AssertJ
TSK-1108
2020-02-12 16:24:14 +01:00
Jörg Heffner 507a37ba70 TSK-1101 minor refactoring of method names and javadoc 2020-02-12 16:20:27 +01:00
Mustapha Zorgati a26e536b91 TSK-1101: restructured report-sub-package to match architecture tests 2020-02-12 16:20:27 +01:00
Holger Hagen 95495e4894 TSK-1110: Enforce application/hal+json MediaType for classification and
workbasket
2020-02-12 15:31:34 +01:00
Sofie Hofmann 01545e476e TSK-1106 Make ClassificationSummaryResource attributes private
TSK-1106 Converted tests to AssertJ

TSK-1106 Converted assertThrows to AssertJ

TSK-1106 Removed suppress checkstyle for lambdas
2020-02-12 12:53:08 +01:00
Holger Hagen 60d4b29015 TSK-1031: formatting issues fixed. 2020-02-11 17:05:34 +01:00
Holger Hagen 007f268be5 TSK-1031: update Spring Boot to 2.2.4.RELEASE except Hateoas. 2020-02-11 17:05:34 +01:00
Holger Hagen e6f8883e49 TSK-1031: removed unnecessary throws statements 2020-02-11 17:05:34 +01:00
Sofie Hofmann 38d5c8535c TSK-1105 Make attributes in ClassificationResource private
TSK-1105 Converted tests to AssertJ
2020-02-11 14:07:00 +01:00
Jörg Heffner dcc72d1781 TSK-1088 optimistic locking on workbasket update
- Added optimistic locking for workbasket update
- Adjusted WorkbasketDefinitionController
- Added tests in UpdateWorkbasketAccTest
- Added tests in WorkbasketControllerIntTest
- Changed ConcurrencyException HTTP-Status Code to CONFLICT (409)
2020-02-11 09:33:54 +01:00
Sofie Hofmann 6eeff1ba22 TSK-1065 Refactor TaskImpl 2020-02-07 08:36:52 +01:00
Mustapha Zorgati e308578ced TSK-991: refactored report structure to meet api -> internal agreement 2020-02-06 17:26:05 +01:00
BerndBreier 12a94193be TSK-927 set owner - comments from Holger 2020-02-06 14:05:27 +01:00
BerndBreier 22ac25f5c9 TSK-927 reserve a task via SetOwner 2020-02-06 14:05:27 +01:00
BerndBreier 77663f02ca TSK-991
-prevent api classes from accessing internal classes
-disable architecture test for mapper classes / package
-added architecture tests for exceptions and api/internal
-defined exceptional classes: TaskanaHistory* and BulkOperationResults
2020-02-03 11:41:02 +01:00
BerndBreier 4423854822 TSK-991 fix dependent projects 2020-02-03 11:41:02 +01:00
BerndBreier 3b13b9a95e TSK-991 after initial refactoring 2020-02-03 11:41:02 +01:00
Benjamin Eckstein a1f1e72afc TSK-1024: Make LdapClient more testable 2020-01-30 17:24:45 +01:00
Sofie Hofmann 57cb37fb0d TSK-1077 added ClassificationSummaryAssemblerTest 2020-01-30 16:45:52 +01:00
BVier b68043a078 changes 2020-01-30 14:09:11 +01:00
BVier 0c63dfaea3 TSK-1037: WBDefinitonController accepts existing distributionTargets 2020-01-30 14:09:11 +01:00
Mustapha Zorgati 659272fda9 Updated poms to version 1.2.3-SNAPSHOT 2020-01-30 10:41:25 +00:00
Jörg Heffner b01e5c3de6 TSK-989 Filter Tasks by planned TimeIntervals (REST)
-Added planned, planned-from and planned-until params in filter list
-Added due, due-from and due-until params in filter list
-Implemented needed methods
-Added Test
-Updated rest-api.doc
-Refactored TaskControllerIntTests to use AssertJ
2020-01-30 11:08:58 +01:00
Benjamin Eckstein 99e2caadec TSK-1024: Refactor and clean up LdapClient changes 2020-01-30 10:03:34 +01:00
Mustapha Zorgati 34d6bfdae6 TSK-1024: removed lenient() and replaced MockitoSettings annotation 2020-01-30 10:03:34 +01:00
Benjamin Eckstein 08571e7216 TSK-1024: Add tests for ldapclient 2020-01-30 10:03:34 +01:00
Sofie Hofmann dbe17fff57 TSK-1051 Expose task description via rest
TSK-1051 Expose task description via rest

TSK-1051 changed devMode property
2020-01-29 17:11:57 +01:00
Benjamin Eckstein 0d9ebe07c5 TSK-987: Fix Spotbugs - Write to static field from instance method 2020-01-29 09:27:08 +01:00
Mustapha Zorgati 9b61abda37 TSK-1038: added WAIAlreadyExistsException to missing operations with access Items 2020-01-28 12:27:37 +01:00
Mustapha Zorgati 7477092a69 automated formatting
changes most likely method order
2020-01-27 20:40:43 +01:00
Benjamin Eckstein b86f3e5b65 TSK-987: Fix Spotbugs - Dead store to local variable 2020-01-27 11:49:59 +01:00
Benjamin Eckstein 2f7d0d359b TSK-987: Fix Spotbugs - exception is caught when exception is not thrown 2020-01-27 11:49:59 +01:00
Benjamin Eckstein 3e9ea4d1d9 TSK-987: Fix Spotbugs - inner class could be made static 2020-01-27 11:49:59 +01:00
Mustapha Zorgati 5b68922590 TSK-1025: added assertj dependency to every module 2020-01-26 20:11:42 +01:00
Mustapha Zorgati afcc47dcd5 Updated poms to version 1.2.2-SNAPSHOT 2020-01-24 13:19:17 +00:00
Holger Hagen 226c30bf73 TSK-1024: add LDAP lookup for group by dn 2020-01-23 17:49:30 +01:00
BerndBreier 16a82efcb5 TSK-1038 duplicate workbasket errors in Rest tests 2020-01-23 16:58:49 +01:00
BerndBreier 3709d98511 TSK-1038 prevent duplicate workbasket access items 2020-01-23 16:58:49 +01:00
Benjamin Eckstein 4d560532bd TSK-987: Fix Spotbugs - reliance on default encoding 2020-01-23 14:23:56 +01:00
Benjamin Eckstein 0262121041 TSK-1029: Test and fix privilege for runasadmin is only temporary 2020-01-23 13:00:04 +01:00
Benjamin Eckstein 1d15f5102f TSK-1029: Fix side effect of tests 2020-01-23 13:00:04 +01:00
Benjamin Eckstein fae9d1fb9b TSK-1029: Fix deletion of workbasket as business admin not possible 2020-01-23 13:00:04 +01:00
Benjamin Eckstein 5a08fd4b03 TSK-1029: Add test to trigger permission bug 2020-01-23 13:00:04 +01:00
Benjamin Eckstein c92190ca70 TSK-987: Fix some problems reported by spotbugs 2020-01-23 09:35:19 +01:00
BerndBreier 6c8fb69f60 TSK-1042 use try-with-resources for connections 2020-01-22 16:40:19 +01:00
Benjamin Eckstein 25919195ed TSK-369: Fix rest documentation 2020-01-22 13:57:07 +01:00
Benjamin Eckstein c92f4a42ed TSK-369: Add sonarcloud to travis 2020-01-22 13:57:07 +01:00
Mustapha Zorgati 3bea7412c4 Revert "TSK-369: Add sonarcloud to travis"
This reverts commit 4e7a71bf94.
2020-01-21 16:59:03 +01:00
Benjamin Eckstein 6999f255df TSK-369: Add sonarcloud to travis 2020-01-21 12:57:03 +01:00
Benjamin Eckstein 6a6dcb9c1e TSK-889: Standardise paginated List behaviour and sub classes 2020-01-14 15:58:16 +01:00
Benjamin Eckstein f06f87f41e TSK-889: Replace WorkbasketAccessItemListResource with equivalent PaginatedListResource 2020-01-14 15:58:16 +01:00
Holger Hagen 09adb30171 Updated poms to version 1.2.1-SNAPSHOT 2020-01-08 09:05:14 +00:00
Mustapha Zorgati 67ab7e2792 TSK-1014 fixed checkstyle and enabled checkstyle verification for tests 2020-01-08 00:02:52 +01:00
Mustapha Zorgati 1a77810fc2 TSK-1014: Fixed hateoas links 2020-01-07 21:35:01 +01:00
Mustapha Zorgati c1d74b2126 TSK-1009: automatic formatting number 2 2020-01-07 21:15:05 +01:00
Mustapha Zorgati 78cfd64902 TSK-1009: replaced MessageFormat with String.format 2020-01-07 21:15:05 +01:00
Benjamin Eckstein c4cd616e35 TSK-1009: Fix building errors after checkstyle changes 2020-01-07 21:15:05 +01:00
Benjamin Eckstein 7509bb0f1c TSK-1009: Fix simple checkstyle warnings 2020-01-07 21:15:05 +01:00
Mustapha Zorgati af0bd0156e TSK-1009: refactored project 2020-01-07 21:15:05 +01:00
Benjamin Eckstein 7ba8def59a TSK-987: Check and fix problems identified by spotbugs 2019-12-26 00:34:38 +01:00