nosu
/
taskana
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fixed Code Smells

This commit is contained in:
jamesrdi 2023-09-15 14:58:08 +02:00
parent f29d5942ab
commit 9aebda65b7
2 changed files with 2 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
lib/taskana-core/src/main/java/pro/taskana/task/internal/TaskServiceImpl.java
View File

@ -2255,10 +2255,6 @@ public class TaskServiceImpl implements TaskService {
String workbasketId = task.getWorkbasketSummary().getId(); String workbasketId = task.getWorkbasketSummary().getId();
WorkbasketSummary workbasket = WorkbasketSummary workbasket =
query.idIn(workbasketId).callerHasPermissions(WorkbasketPermission.EDITTASKS).single(); query.idIn(workbasketId).callerHasPermissions(WorkbasketPermission.EDITTASKS).single();
if (workbasket == null) { return workbasket != null;
return false;
} else {
return true;
}
} }
} }

2
rest/taskana-rest-spring/src/main/java/pro/taskana/task/rest/TaskQueryFilterParameter.java
View File

@ -2205,7 +2205,7 @@ public class TaskQueryFilterParameter implements QueryParameter<TaskQuery, Void>
if (this.ownerIn == null) { if (this.ownerIn == null) {
return new String[]{null}; return new String[]{null};
} }
List<String> ownerInAsList = new ArrayList(Arrays.asList(this.ownerIn)); List<String> ownerInAsList = new ArrayList<>(Arrays.asList(this.ownerIn));
ownerInAsList.add(null); ownerInAsList.add(null);
return ownerInAsList.toArray(new String[ownerInAsList.size()]); return ownerInAsList.toArray(new String[ownerInAsList.size()]);
} }