Commit Graph

1060 Commits

Author SHA1 Message Date
Luis Rivas d13b3542f0 Update lib/taskana-core/src/main/java/pro/taskana/task/api/TaskService.java
Co-authored-by: Mustapha Zorgati <15628173+mustaphazorgati@users.noreply.github.com>
2023-03-28 07:38:57 +02:00
Luis Rivas 180dcef03f Update lib/taskana-core/src/main/java/pro/taskana/task/api/TaskService.java
Co-authored-by: Mustapha Zorgati <15628173+mustaphazorgati@users.noreply.github.com>
2023-03-28 07:38:57 +02:00
Luis Rivas a5f323a38f Updating JavaDoc 2023-03-28 07:38:57 +02:00
Luis Rivas 5ffccd216e removing NotAuthorizedOnWorkbasketException from interface method 2023-03-28 07:38:57 +02:00
Luis Rivas 0ec00c37bd Update lib/taskana-core/src/main/java/pro/taskana/task/internal/TaskServiceImpl.java
Co-authored-by: Mustapha Zorgati <15628173+mustaphazorgati@users.noreply.github.com>
2023-03-28 07:38:57 +02:00
Luis Rivas ae51e9c0e7 Returning TaskService.java to original form 2023-03-28 07:38:57 +02:00
Luis Rivas 06b7404ecd Surround NotAuthorizedException with try catch #2162 2023-03-28 07:38:57 +02:00
Luis Rivas 62c2defeff Returning TaskService.java to original form 2023-03-28 07:38:57 +02:00
Luis Rivas 7fdbaccae0 Surround NotAuthorizedException with try catch in the force-methods of TaskService #2162 2023-03-28 07:38:57 +02:00
Mustapha Zorgati f6380c2d3c #2181: init PriorityServiceProviders during TaskanaEngine init 2023-03-22 09:48:40 +01:00
Mustapha Zorgati 3f60a98ef2 TSK-1991: fixed renaming of user properties 2023-03-21 12:08:57 +01:00
Mustapha Zorgati d3b59dfd6a TSK-2016: replaced MapCreator methods with Map#of calls 2023-03-16 16:52:24 +01:00
Mustapha Zorgati 2592a7f562 TSK-1991: verify immutability for TaskanaConf Map<?, Collection<?>>
and restructured TaskanaConfigurationTest for better readability / maintainability
2023-03-16 16:29:09 +01:00
Mustapha Zorgati 42e6c9bb47 fixed documentation smoke tests 2023-03-15 11:22:47 +01:00
Mustapha Zorgati d96b1c392a TSK-1991: rework of property names 2023-03-15 01:00:50 +01:00
Mustapha Zorgati 55d939ca7b format entire codebase with new google-java-format version 2023-03-13 19:02:53 +01:00
Mustapha Zorgati fb11ff97b3 TSK-1972: Task.dueDate is inclusive. 2023-03-13 10:39:04 +01:00
Mustapha Zorgati b916d577ca TSK-1972: Uses time zone for working time calculations 2023-03-13 10:39:04 +01:00
arolfes 37280cc73b TSK-2013 selectAndClaim TasK return Optional and does not throw Exception if Task is notFound 2023-03-13 10:39:04 +01:00
Mustapha Zorgati 0d66e9b09d TSK-1988: cleanup of TaskanaConfiguration 2023-03-13 10:39:04 +01:00
Holger Hagen d21eb47ffe TSK-2012: renamed Mismatched_Exceptions to NotAuthorizedExceptions 2023-03-13 10:39:04 +01:00
Mustapha Zorgati ac95f8b181 TSK-2002: rename taskanaEngineConfiguration to taskanaConfiguration 2023-03-13 10:39:04 +01:00
arolfes 773ac7619d TSK-2005: validate TaskanaConfiguration 2023-03-13 10:39:04 +01:00
Mustapha Zorgati b2be25e2ef TSK-1997: refactoring DB Enum 2023-03-13 10:39:04 +01:00
Alex f64e38eb27 TSK-1989: integrate execution of jobs in taskana core (#2087)
Co-authored-by: Mustapha Zorgati <15628173+mustaphazorgati@users.noreply.github.com>
2023-03-13 10:39:04 +01:00
Jochen Just 4a42a35a21 TSK-1972: calculates working time in any resolution
Prior working time calculation only happened in a full day.
2023-03-13 10:39:04 +01:00
Mustapha Zorgati 4697fbe5be TSK-2004: JavaDoc 4 TaskanaConfiguration.Builder#initTaskanaProperties
And refactoring of some components around the TaskanaConfiguration
2023-03-13 10:39:04 +01:00
arolfes f9e6b26817 TSK-1993 InvalidArgumentException extends TaskanaRuntimeException 2023-03-13 10:39:04 +01:00
arolfes 20d389a7d5 TSK-1992 remove unnecessary ParentExceptions
Deleted Exceptions:
* NotAuthorizedException
* NotFoundException
* InvalidStateException
2023-03-13 10:39:04 +01:00
Mustapha Zorgati e40417f1fd TSK-2003: minor refactoring 2023-03-13 10:39:04 +01:00
Mustapha Zorgati 3af17ece6a TSK-2003: removed reset of schema name in SqlConRunner#runWithConnection 2023-03-13 10:39:04 +01:00
arolfes b96c68ac6f TSK-1996 taskana.properties file is optional 2023-03-13 10:39:04 +01:00
arolfes 61a5e32865 TSK-1987 immutable TaskanaEngineConfiguration 2023-03-13 10:39:04 +01:00
Alex 53f9dce1db TSK-1986 remove cycle between TaskanaEngineConfiguration und TaskanaEngine (#2078) 2023-03-13 10:39:04 +01:00
Elena Mokeeva 73fed96627 TSK-2001: add filtering by priorityWithin and notWithin 2023-03-03 12:56:38 +01:00
Elena Mokeeva 3dbf98bf92
TSK-2000: add filtering by classification parent key 2023-02-16 12:17:13 +01:00
Elena Mokeeva 68eacbbc3e TSK-1976: set ownerLongName during Task creation 2023-02-14 13:57:06 +01:00
arolfes a6ede02524 TSK-1975 new indices for Object_Reference Table
3 new Indices for Table Object_Reference
* IDX_OBJECT_REFERENCE_PK_ID
* IDX_OBJECT_REFERENCE_FK_TASK_ID
* IDX_OBJECT_REFERENCE_ACCESS_LIST

Fixed Default Sorting when searching or accessing ObjectReferences
2023-02-14 13:53:37 +01:00
Elena Mokeeva 8bfb7fae95 TSK-1977: fix setting ownerLongName while claiming 2023-02-14 09:40:46 +01:00
Alex 291cc38ea6
TSK-1971 support for oracle databases (#2050)
* local testcontainer, sql script to setup table
* handle empty strings and null values
* prepare all SQL Staments for oracle
* run external oracle db
2023-02-13 08:00:43 +01:00
Elena Mokeeva f25b6eb550 fix resquestReview for an IN_REVIEW Task 2023-02-09 14:18:56 +01:00
Yakup Ensar Evli 131c1f0cb9 TSK-1866: Refactor UpdateClassificationAccTest to use Test-API
Compressed UpdateTaskPriority/ServiceLevel-Test. Check error messages. Cleaned comments. Reordered some methods.
Move test to taskana-core-test according to new structure.
2023-01-30 12:42:56 +01:00
Norman Schmidt 48d85e0ee7
TSK-1946: update to Spring Boot 2.7.8 (#1999)
* TSK-1946: H2 Update

* TSK-1946: add new run configurations

* TSK-1946: update to Spring Boot 2.7.3

Updated Spring Security Configs to new component-based configuration.
See https://spring.io/blog/2022/02/21/spring-security-without-the-websecurityconfigureradapter

Co-authored-by: Marcel Bagemihl <marcel.bagemihl@novatec-gmbh.de>

* TSK-1946: wildfly now only starting postgres db

* TSK-1946: drop sup 4 sys prop db.type. We only execute PSQL

* TSK-1946: create new module 'taskana-rest-spring-test-lib' to simplify the Spring Security Configuration Setup for Spring Tests

* TSK-1946: H2 Update

* TSK-1946: add new run configurations

* TSK-1946: update to Spring Boot 2.7.3

Updated Spring Security Configs to new component-based configuration.
See https://spring.io/blog/2022/02/21/spring-security-without-the-websecurityconfigureradapter

Co-authored-by: Marcel Bagemihl <marcel.bagemihl@novatec-gmbh.de>

* TSK-1946: wildfly now only starting postgres db

* TSK-1946: drop sup 4 sys prop db.type. We only execute PSQL

* TSK-1946: create new module 'taskana-rest-spring-test-lib' to simplify the Spring Security Configuration Setup for Spring Tests

* TSK-1946: update to Spring Boot 2.7.8

---------

Co-authored-by: Yakup Ensar Evli <54323073+ensarevlideveloper@users.noreply.github.com>
Co-authored-by: Mustapha Zorgati <15628173+mustaphazorgati@users.noreply.github.com>
Co-authored-by: Marcel Bagemihl <marcel.bagemihl@novatec-gmbh.de>
Co-authored-by: arolfes <arolfes@users.noreply.github.com>
2023-01-30 12:33:41 +01:00
Norman Schmidt e72ef4ac4e TSK-1969: added getUsers method to UserService 2023-01-11 07:05:24 +01:00
Mustapha Zorgati deba2009e7 TSK-1970: removed deprecated methods from WorkbasketQuery 2022-10-21 10:46:53 +02:00
Mustapha Zorgati 45417f887d TSK-1957: exposed domain attribute via REST 2022-10-20 22:38:54 +02:00
Norman Schmidt dc9e2e1d5f TSK-1967: make owner of Task updatable when Task is 'READY_FOR_REVIEW' 2022-10-20 21:49:16 +02:00
norman-schmidt b9b49f47a1
TSK-1965: create endpoints for all state transitions (#2024)
* TSK-1965: created endpoint for force claiming a task

* TSK-1965: created endpoint for force completing a task

* TSK-1965: restructured TaskController to match TaskService structure

* TSK-1965: structured TaskControllerIntTest

* TSK-1965: created endpoint for terminating a task

* TSK-1965: created endpoint for setting a task read
2022-10-20 14:20:24 +02:00
norman-schmidt e40623ce0f
TSK-1957: groups are included in the domain aggregation (#2021)
* TSK-1957: groups are included in the domain aggregation

- added schema GROUP_INFO
- added group related methods to UserMapper / UserMapperSqlProvider
- User API extended with groups
- UserInfoRefreshJob includes groups
2022-10-20 14:16:47 +02:00
Mustapha Zorgati 9a188f015f TSK-1919: fixed query offeset tests by comparing entire object 2022-10-17 11:27:04 +02:00
Norman Schmidt 90a64a9b88 TSK-1957: extend getUser() method with domain information
- extended WorkbasketQuery methods 'accessIdsHavePermission' & 'callerHasPermission' to accept multiple permissions
- added domain attribute to User API
- extended UserService to aggregate domain information

Co-authored-by: Mustapha Zorgati <15628173+mustaphazorgati@users.noreply.github.com>
2022-10-11 17:43:31 +02:00
Norman Schmidt 5a14c00fa1 TSK-1957: add taskana property 'minimalPermissionsToAssignDomains' 2022-10-11 17:43:31 +02:00
Norman Schmidt d6da6f8124 TSK-1957: migrate UserServiceAccTest to new test-api 2022-10-11 17:43:31 +02:00
norman-schmidt 6c6f1b56c4
TSK-1961: Remove AbstractWorkbasketAccessItemQuery and AbstractWorkbasketAccessItemQueryImpl (#2014) 2022-09-28 12:57:44 +02:00
ryzheboka d77c4846ed TSK-1925: clean up claimTaskAccTest 2022-09-20 09:05:27 +02:00
ryzheboka a6567b6eda TSK-1958: fix status changes for Task transfer 2022-09-19 13:35:48 +02:00
ryzheboka e1d205d4ef TSK-1947: processing of LDAP-data after refresh 2022-09-14 17:53:35 +02:00
ryzheboka 316c173663 TSK-1955: Add javadoc for two SPIs 2022-09-13 13:07:50 +02:00
ryzheboka 084dc2b99b TSK-1954: Clean up codesmells 2022-09-07 16:26:23 +02:00
ryzheboka 0060368905 TSK-1952: adjust parameter names in queries + some clean up 2022-09-06 17:43:43 +02:00
ryzheboka dc5efe527b TSK-1951: Extend WorkbasketPriorityReport for customInt 2022-09-06 12:00:06 +02:00
Yakup Ensar Evli e074a90222 TSK-1816: Update QueryClassificationAccTest to use Test-API
Used new builder to create classifications.
Instead of working with a clean database for each test, we create a scenario. In that scenario we use ClassificationCustomField#CUSTOM_1 to filter out all the other created Classifications. Therefore, all tests regarding ClassificationCustomFields are executed first.
The alternative is to create a "big" scenario as a test setup. But that would result to the same issues we have with the sql file.
Corrected assertion for should_FindClassifications_When_QueryingForListValueField():167. The databases (H2, POSTGRES) have different interpretations for boolean values.
getCustomAttribute got deprecated, now getCustomField is being used.
Move test to taskana-core-test according to new project structure.
Separated QueryClassificationsAccTest to filtering and sorting class.
ClassificationQueryAccTest resolved to QueryClassifications classes.
TSK-1816: X
2022-08-24 14:29:05 +03:00
ryzheboka 657e8ea81b TSK-1840: refactor DeleteClassificationAccTest to use test-api 2022-08-24 12:58:39 +02:00
ryzheboka 3575b8aa17 TSK-1926: Remove duplicate from TaskServiceImpl 2022-08-24 12:32:26 +02:00
Mustapha Zorgati 62844c7b9f TSK-1944: expanded Javadoc for review SPIs to include force methods 2022-08-20 18:16:23 +02:00
Mustapha Zorgati d8ffdb1824 TSK-1944: Implemented BeforeRequestChanges SPI 2022-08-20 18:16:23 +02:00
Mustapha Zorgati 151d23d98d TSK-1945: minor cleanup of TaskServiceImpl
blub2
2022-08-20 17:46:27 +02:00
Mustapha Zorgati 1188f6396c TSK-1945: implemented BeforeRequestReview SPI
blub
2022-08-20 17:46:27 +02:00
ryzheboka 897b469aeb TSK-1829: refactor testSetPlannedPropertyOnAllTasks 2022-08-18 10:58:41 +02:00
ryzheboka 709736ddc9 TSK-1843: refactor GetTaskCommentAccTest to use test-api 2022-08-18 10:43:09 +02:00
Yakup Ensar Evli 33a8852995 TSK-1864: Reorder methods in TaskService
New ordering follows CRUD principles for better readability.
2022-08-18 00:02:18 +03:00
ryzheboka 387a95c4ce TSK-1844: Refactor CreateTaskCommentAccTest to use test-api 2022-08-17 10:08:45 +02:00
Mustapha Zorgati 6997d64083 TSK-1943: added REST endpoint for force requesting changes on a Task 2022-08-11 17:08:10 +02:00
Mustapha Zorgati cf690bf6b5 TSK-1941: implemented ReviewRequired SPI 2022-08-11 12:36:39 +02:00
ryzheboka 340236c4a2 TSK-1938: Add RequestChangesProvider 2022-08-11 12:17:08 +02:00
Mustapha Zorgati 1f9d20f76f TSK-1937: implemented AfterRequestReviewProvider
Co-authored-by: ryzheboka <25465835+ryzheboka@users.noreply.github.com>
2022-08-10 12:18:14 +02:00
ryzheboka ba5e582beb TSK-1911: Fix details of TaskHistoryEvents 2022-08-09 14:41:56 +02:00
ryzheboka d83678ac54 TSK-1916: test history when requesting changes 2022-08-09 13:19:02 +02:00
ryzheboka cc32b10d82 TSK-1916: Add requestChanges functionality 2022-08-09 13:19:02 +02:00
ryzheboka 0b4445b97b TSK-1923: clean parameter names in Query entities 2022-08-09 13:17:48 +02:00
ryzheboka ef875dd42a TSK-1915: Add requestReview functionality 2022-08-06 14:30:59 +02:00
ryzheboka 70c64dd66e TSK-1837: Add custom-int-x-from and custom-int-x-to to rest 2022-08-02 14:35:13 +02:00
ryzheboka 803b4b20a2 TSK-1837: Add within and notWithin filter criteria 2022-08-02 14:35:13 +02:00
ryzheboka 18ee26ba80 TSK-1837: Add custom_int fields and standard operations on them 2022-08-02 14:35:13 +02:00
ryzheboka 83890ddd16 TSK-1914: introduce IN_REVIEW and READY_FOR_REVIEW Task status 2022-07-19 15:27:44 +02:00
ryzheboka 6591478ebb TSK-1858: Remove test-api duplicates 2022-07-13 09:02:02 +02:00
ryzheboka 8d87d15e7c TSK-1909: optimize authorization in db2 query 2022-07-05 14:24:27 +02:00
Mustapha Zorgati 1f4c3ad5fb
removed region comments from TaskQueryImpl 2022-06-22 11:35:25 +02:00
Mustapha Zorgati 20787a2166 TSK-1887: taskana-simplehistory-provider is now using our docker dbs 2022-06-22 11:18:12 +02:00
ryzheboka a9936f243d TSK-1902: fix wrong time conversion 2022-06-15 14:05:34 +02:00
ryzheboka 3b43b6c038 TSK-1811: Refactor Java-doc in ClassificationQuery 2022-06-14 15:39:29 +02:00
ryzheboka 59a4968106 TSK-1841: refactor GetClassificationAccTest to use test-api 2022-06-14 15:02:21 +02:00
ryzheboka 1b9794d34a TSK-1886: add MASTER_DOMAIN into the SharedConstants class 2022-06-14 09:59:19 +02:00
Oliver Koch 96804ef1d7 TSK-1900: fix checkstyle issue 2022-06-10 15:49:27 +02:00
Oliver Koch 3eb0d6b288 TSK-1900: refactored ArchUnit Tests
* Bump up the Version for ArchUnit from 0.22.0 to 0.23.1
* Added Regions to structure the ArchUnit Tests
* Refined Tests, so they better fit
2022-06-10 15:49:27 +02:00
Yakup Ensar Evli f6ce6439cc TSK-1888: Restructure method order of ConfigurationService, UserService
New ordering follows CRUD principles for better readability.
2022-06-08 18:34:14 +03:00
ryzheboka a23060ba64 TSK-1836: add withoutAttachment as query parameter in REST and taskana-core 2022-06-01 12:15:03 +02:00
ryzheboka a2e0681190 TSK-1852: refactor JavaDoc in TaskService 2022-05-31 16:01:49 +02:00
Yakup Ensar Evli 43ed441daf TSK-1812: Added details in task-history for claim/cancel
Detect changes and pass them in the specific event in TaskServiceImpl class. For saving the old state of the specified task, I had to use copy() since getTask returns the same object reference, thus no changes can be detected. 
In the specified events details are accepted as parameters.
Extended Tests for Claim and Cancel Events to check correct details.
2022-05-31 16:54:29 +03:00
Yakup Ensar Evli db88d93017 TSK-1865: Reorder methods in ClassificationService
New ordering follows CRUD principles for better readability.
2022-05-31 13:14:37 +03:00